[PATCH v4 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm

[PATCH v4 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm

[Jerin Jacob]

v1..v2
created common arm64 configs under common_arm64 file.
let  each armv8 machine targets  capture only the differences
between the common arm64 config.

v2..v3
Fix whitespace issue with git am

v3..v4
removed common_arm64 file and used defconfig_arm64-armv8a-linuxapp-gcc
as base

Jerin Jacob (2):
  config: use defconfig_arm64-armv8a-linuxapp-gcc as base for arm64
    targets
  config: disable CONFIG_RTE_SCHED_VECTOR for arm

 config/defconfig_arm-armv7a-linuxapp-gcc     |  1 +
 config/defconfig_arm64-armv8a-linuxapp-gcc   |  1 +
 config/defconfig_arm64-thunderx-linuxapp-gcc | 22 +---------------------
 config/defconfig_arm64-xgene1-linuxapp-gcc   | 24 +-----------------------
 4 files changed, 4 insertions(+), 44 deletions(-)

-- 
2.1.0

[PATCH v4 1/2] config: use defconfig_arm64-armv8a-linuxapp-gcc as base for arm64 targets

[Jerin Jacob]

let each armv8 machine targets  capture only the differences
between the common defconfig_arm64-armv8a-linuxapp-gcc

Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 config/defconfig_arm64-thunderx-linuxapp-gcc | 22 +---------------------
 config/defconfig_arm64-xgene1-linuxapp-gcc   | 24 +-----------------------
 2 files changed, 2 insertions(+), 44 deletions(-)

diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
index 6b2048b..fe5e987 100644
--- a/config/defconfig_arm64-thunderx-linuxapp-gcc
+++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
@@ -29,28 +29,8 @@
 #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #
 
-#include "common_linuxapp"
+#include "defconfig_arm64-armv8a-linuxapp-gcc"
 
 CONFIG_RTE_MACHINE="thunderx"
 
-CONFIG_RTE_ARCH="arm64"
-CONFIG_RTE_ARCH_ARM64=y
-CONFIG_RTE_ARCH_64=y
-CONFIG_RTE_ARCH_ARM_NEON=y
-
-CONFIG_RTE_FORCE_INTRINSICS=y
-
-CONFIG_RTE_TOOLCHAIN="gcc"
-CONFIG_RTE_TOOLCHAIN_GCC=y
-
 CONFIG_RTE_CACHE_LINE_SIZE=128
-
-CONFIG_RTE_IXGBE_INC_VECTOR=n
-CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
-CONFIG_RTE_LIBRTE_IVSHMEM=n
-CONFIG_RTE_LIBRTE_FM10K_PMD=n
-CONFIG_RTE_LIBRTE_I40E_PMD=n
-
-CONFIG_RTE_LIBRTE_LPM=n
-CONFIG_RTE_LIBRTE_TABLE=n
-CONFIG_RTE_LIBRTE_PIPELINE=n
diff --git a/config/defconfig_arm64-xgene1-linuxapp-gcc b/config/defconfig_arm64-xgene1-linuxapp-gcc
index d75f8f0..f096166 100644
--- a/config/defconfig_arm64-xgene1-linuxapp-gcc
+++ b/config/defconfig_arm64-xgene1-linuxapp-gcc
@@ -29,28 +29,6 @@
 #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #
 
-#include "common_linuxapp"
+#include "defconfig_arm64-armv8a-linuxapp-gcc"
 
 CONFIG_RTE_MACHINE="xgene1"
-
-CONFIG_RTE_ARCH="arm64"
-CONFIG_RTE_ARCH_ARM64=y
-CONFIG_RTE_ARCH_64=y
-CONFIG_RTE_ARCH_ARM_NEON=y
-
-CONFIG_RTE_FORCE_INTRINSICS=y
-
-CONFIG_RTE_TOOLCHAIN="gcc"
-CONFIG_RTE_TOOLCHAIN_GCC=y
-
-CONFIG_RTE_CACHE_LINE_SIZE=64
-
-CONFIG_RTE_IXGBE_INC_VECTOR=n
-CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
-CONFIG_RTE_LIBRTE_IVSHMEM=n
-CONFIG_RTE_LIBRTE_FM10K_PMD=n
-CONFIG_RTE_LIBRTE_I40E_PMD=n
-
-CONFIG_RTE_LIBRTE_LPM=n
-CONFIG_RTE_LIBRTE_TABLE=n
-CONFIG_RTE_LIBRTE_PIPELINE=n
-- 
2.1.0

[PATCH v4 2/2] config: disable CONFIG_RTE_SCHED_VECTOR for arm

[Jerin Jacob]

Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR
does support only SSE intrinsic, so disable it till we have neon support.

Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config")

Acked-By: Jan Viktorin <viktorin@rehivetech.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 config/defconfig_arm-armv7a-linuxapp-gcc   | 1 +
 config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc
index 82143af..9924ff9 100644
--- a/config/defconfig_arm-armv7a-linuxapp-gcc
+++ b/config/defconfig_arm-armv7a-linuxapp-gcc
@@ -57,6 +57,7 @@ CONFIG_RTE_LIBRTE_ACL=n
 CONFIG_RTE_LIBRTE_LPM=n
 CONFIG_RTE_LIBRTE_TABLE=n
 CONFIG_RTE_LIBRTE_PIPELINE=n
+CONFIG_RTE_SCHED_VECTOR=n
 
 # cannot use those on ARM
 CONFIG_RTE_KNI_KMOD=n
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 49e7056..504f3ed 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -54,3 +54,4 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
 CONFIG_RTE_LIBRTE_LPM=n
 CONFIG_RTE_LIBRTE_TABLE=n
 CONFIG_RTE_LIBRTE_PIPELINE=n
+CONFIG_RTE_SCHED_VECTOR=n
-- 
2.1.0

Re: [PATCH v4 1/2] config: use defconfig_arm64-armv8a-linuxapp-gcc as base for arm64 targets

[Jianbo Liu]

Reviewed-by: Jianbo Liu <jianbo.liu@linaro.org>

On 1 December 2015 at 01:20, Jerin Jacob <jerin.jacob@caviumnetworks.com>
wrote:
> let each armv8 machine targets  capture only the differences
> between the common defconfig_arm64-armv8a-linuxapp-gcc
>
> Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  config/defconfig_arm64-thunderx-linuxapp-gcc | 22 +---------------------
>  config/defconfig_arm64-xgene1-linuxapp-gcc   | 24
+-----------------------
>  2 files changed, 2 insertions(+), 44 deletions(-)
>
> diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc
b/config/defconfig_arm64-thunderx-linuxapp-gcc
> index 6b2048b..fe5e987 100644
> --- a/config/defconfig_arm64-thunderx-linuxapp-gcc
> +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
> @@ -29,28 +29,8 @@
>  #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  #
>
> -#include "common_linuxapp"
> +#include "defconfig_arm64-armv8a-linuxapp-gcc"
>
>  CONFIG_RTE_MACHINE="thunderx"
>
> -CONFIG_RTE_ARCH="arm64"
> -CONFIG_RTE_ARCH_ARM64=y
> -CONFIG_RTE_ARCH_64=y
> -CONFIG_RTE_ARCH_ARM_NEON=y
> -
> -CONFIG_RTE_FORCE_INTRINSICS=y
> -
> -CONFIG_RTE_TOOLCHAIN="gcc"
> -CONFIG_RTE_TOOLCHAIN_GCC=y
> -
>  CONFIG_RTE_CACHE_LINE_SIZE=128
> -
> -CONFIG_RTE_IXGBE_INC_VECTOR=n
> -CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
> -CONFIG_RTE_LIBRTE_IVSHMEM=n
> -CONFIG_RTE_LIBRTE_FM10K_PMD=n
> -CONFIG_RTE_LIBRTE_I40E_PMD=n
> -
> -CONFIG_RTE_LIBRTE_LPM=n
> -CONFIG_RTE_LIBRTE_TABLE=n
> -CONFIG_RTE_LIBRTE_PIPELINE=n
> diff --git a/config/defconfig_arm64-xgene1-linuxapp-gcc
b/config/defconfig_arm64-xgene1-linuxapp-gcc
> index d75f8f0..f096166 100644
> --- a/config/defconfig_arm64-xgene1-linuxapp-gcc
> +++ b/config/defconfig_arm64-xgene1-linuxapp-gcc
> @@ -29,28 +29,6 @@
>  #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  #
>
> -#include "common_linuxapp"
> +#include "defconfig_arm64-armv8a-linuxapp-gcc"
>
>  CONFIG_RTE_MACHINE="xgene1"
> -
> -CONFIG_RTE_ARCH="arm64"
> -CONFIG_RTE_ARCH_ARM64=y
> -CONFIG_RTE_ARCH_64=y
> -CONFIG_RTE_ARCH_ARM_NEON=y
> -
> -CONFIG_RTE_FORCE_INTRINSICS=y
> -
> -CONFIG_RTE_TOOLCHAIN="gcc"
> -CONFIG_RTE_TOOLCHAIN_GCC=y
> -
> -CONFIG_RTE_CACHE_LINE_SIZE=64
> -
> -CONFIG_RTE_IXGBE_INC_VECTOR=n
> -CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
> -CONFIG_RTE_LIBRTE_IVSHMEM=n
> -CONFIG_RTE_LIBRTE_FM10K_PMD=n
> -CONFIG_RTE_LIBRTE_I40E_PMD=n
> -
> -CONFIG_RTE_LIBRTE_LPM=n
> -CONFIG_RTE_LIBRTE_TABLE=n
> -CONFIG_RTE_LIBRTE_PIPELINE=n
> --
> 2.1.0
>

Re: [PATCH v4 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm

[Thomas Monjalon]

2015-11-30 22:50, Jerin Jacob:
> 
> v1..v2
> created common arm64 configs under common_arm64 file.
> let  each armv8 machine targets  capture only the differences
> between the common arm64 config.
> 
> v2..v3
> Fix whitespace issue with git am
> 
> v3..v4
> removed common_arm64 file and used defconfig_arm64-armv8a-linuxapp-gcc
> as base
> 
> Jerin Jacob (2):
>   config: use defconfig_arm64-armv8a-linuxapp-gcc as base for arm64
>     targets
>   config: disable CONFIG_RTE_SCHED_VECTOR for arm

Applied, thanks
Even if the compilation is already fixed, it is a good idea to explicitly
mark SCHED_VECTOR as disabled instead of relying on internal disabling.