All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniele Fucini <dfucini@gmail.com>
Cc: Cong Wang <cwang@twopensource.com>,
	netdev <netdev@vger.kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	David Miller <davem@davemloft.net>,
	spender@grsecurity.net, pageexec@freemail.hu, re.emese@gmail.com
Subject: Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c
Date: Tue, 01 Dec 2015 06:06:47 -0800	[thread overview]
Message-ID: <1448978807.25582.19.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20151201111943.GA4036@Fux-PC>

On Tue, 2015-12-01 at 12:19 +0100, Daniele Fucini wrote:
> Thanks for the reply. Here's the output of `tc qdisc show`:
> https://gist.github.com/1847102c8fe08f63e9e7
> 
> Daniele
> 
> 
> On Mon, Nov 30, 2015 at 08:50:29PM -0800, Cong Wang wrote:
> > On Mon, Nov 30, 2015 at 5:00 PM, Daniele Fucini <dfucini@gmail.com> wrote:
> > > Hello,
> > >
> > > I'm using a Grsecurity patched kernel (version 4.2.6-201511282239) and
> > > I'm getting system freezes due to PaX detecting a size overflow in
> > > function qdisc_tree_decrease_qlen net/sched/sch_api.c:769 whenever I use
> > > Transmission BitTorrent client.
> > >
> > > On the Grsecurity forum I was told it's probably an unintended integer
> > > underflow that I should report upstream.
> > >
> > > Here's the relevant log:
> > > https://gist.github.com/cf54ccbb12ea65e146d4
> > >
> > 
> > Looks like we miss some sch->q.qlen accounting somewhere...
> > 
> > What is your qdisc setup? Is your fq_codel the default one or you installed it
> > or some other qdisc somewhere (`tc qdisc show` could tell)?
> > 
> > I will take a deeper look tomorrow, or maybe Jamal could find something
> > before I wake up. ;)

Hmm... I do not think we ever took care of MQ in
qdisc_tree_decrease_qlen()

  reply	other threads:[~2015-12-01 14:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01  1:00 size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c Daniele Fucini
2015-12-01  4:50 ` Cong Wang
2015-12-01 11:19   ` Daniele Fucini
2015-12-01 14:06     ` Eric Dumazet [this message]
2015-12-01 14:10       ` Eric Dumazet
2015-12-01 16:13         ` PaX Team
2015-12-01 16:34           ` Eric Dumazet
2015-12-01 18:43             ` Cong Wang
2015-12-01 19:09               ` Eric Dumazet
2015-12-01 19:17                 ` Cong Wang
2015-12-01 20:06                   ` Eric Dumazet
2015-12-01 22:33                     ` Eric Dumazet
2015-12-01 22:47                       ` Cong Wang
2015-12-01 23:10                         ` Eric Dumazet
2015-12-02  4:08                           ` [PATCH net] net_sched: fix qdisc_tree_decrease_qlen() races Eric Dumazet
2015-12-03 19:59                             ` David Miller
2015-12-01 22:40                     ` size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c Cong Wang
2015-12-01 14:15       ` Eric Dumazet
2015-12-01 19:13         ` Daniele Fucini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448978807.25582.19.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=cwang@twopensource.com \
    --cc=davem@davemloft.net \
    --cc=dfucini@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=pageexec@freemail.hu \
    --cc=re.emese@gmail.com \
    --cc=spender@grsecurity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.