From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932106AbbLAWGR (ORCPT ); Tue, 1 Dec 2015 17:06:17 -0500 Received: from outbound.smtp.vt.edu ([198.82.183.121]:46419 "EHLO omr1.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756950AbbLAWGO (ORCPT ); Tue, 1 Dec 2015 17:06:14 -0500 From: Valdis Kletnieks To: Oleg Drokin , Andreas Dilger Cc: lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org, Valdis Kletnieks Subject: [lustre cleanups 2/6] Fix set-but-unused whinge. Date: Tue, 1 Dec 2015 17:05:15 -0500 Message-Id: <1449007519-73974-3-git-send-email-Valdis.Kletnieks@vt.edu> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> References: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/staging/lustre/lustre/fid/lproc_fid.c: In function 'ldebugfs_fid_write_common': drivers/staging/lustre/lustre/fid/lproc_fid.c:67:6: warning: variable 'rc' set but not used [-Wunused-but-set-variable] int rc; We fix it by *using* the return code to help bulletproof it. It says it's test code - it should be *more* bulletproof than production, not less. Signed-off-by: Valdis Kletnieks --- diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c b/drivers/staging/lustre/lustre/fid/lproc_fid.c index ce90c1c54a63..eff011f30fa5 100644 --- a/drivers/staging/lustre/lustre/fid/lproc_fid.c +++ b/drivers/staging/lustre/lustre/fid/lproc_fid.c @@ -85,6 +85,8 @@ ldebugfs_fid_write_common(const char __user *buffer, size_t count, rc = sscanf(kernbuf, "[%llx - %llx]\n", (unsigned long long *)&tmp.lsr_start, (unsigned long long *)&tmp.lsr_end); + if (rc != 2) + return -EINVAL; if (!range_is_sane(&tmp) || range_is_zero(&tmp) || tmp.lsr_start < range->lsr_start || tmp.lsr_end > range->lsr_end) return -EINVAL; -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valdis Kletnieks Date: Tue, 1 Dec 2015 17:05:15 -0500 Subject: [lustre-devel] [lustre cleanups 2/6] Fix set-but-unused whinge. In-Reply-To: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> References: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> Message-ID: <1449007519-73974-3-git-send-email-Valdis.Kletnieks@vt.edu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Oleg Drokin , Andreas Dilger Cc: lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org, Valdis Kletnieks drivers/staging/lustre/lustre/fid/lproc_fid.c: In function 'ldebugfs_fid_write_common': drivers/staging/lustre/lustre/fid/lproc_fid.c:67:6: warning: variable 'rc' set but not used [-Wunused-but-set-variable] int rc; We fix it by *using* the return code to help bulletproof it. It says it's test code - it should be *more* bulletproof than production, not less. Signed-off-by: Valdis Kletnieks --- diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c b/drivers/staging/lustre/lustre/fid/lproc_fid.c index ce90c1c54a63..eff011f30fa5 100644 --- a/drivers/staging/lustre/lustre/fid/lproc_fid.c +++ b/drivers/staging/lustre/lustre/fid/lproc_fid.c @@ -85,6 +85,8 @@ ldebugfs_fid_write_common(const char __user *buffer, size_t count, rc = sscanf(kernbuf, "[%llx - %llx]\n", (unsigned long long *)&tmp.lsr_start, (unsigned long long *)&tmp.lsr_end); + if (rc != 2) + return -EINVAL; if (!range_is_sane(&tmp) || range_is_zero(&tmp) || tmp.lsr_start < range->lsr_start || tmp.lsr_end > range->lsr_end) return -EINVAL; -- 2.6.3