All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
	Marcel Apfelbaum <marcel.a@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument
Date: Tue,  1 Dec 2015 23:46:59 -0200	[thread overview]
Message-ID: <1449020831-8414-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1449020831-8414-1-git-send-email-ehabkost@redhat.com>

Lots of PcGuestInfo fields are duplicates of PCMachineClass or
PCMachineState fields. Pass PCMachineState as argument to
acpi_setup(), so we can simply let the ACPI code use those fields
directly.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/i386/acpi-build.c | 3 ++-
 hw/i386/acpi-build.h | 2 +-
 hw/i386/pc.c         | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index bca3f06..74f0922 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1893,8 +1893,9 @@ static const VMStateDescription vmstate_acpi_build = {
     },
 };
 
-void acpi_setup(PcGuestInfo *guest_info)
+void acpi_setup(PCMachineState *pcms)
 {
+    PcGuestInfo *guest_info = &pcms->acpi_guest_info;
     AcpiBuildTables tables;
     AcpiBuildState *build_state;
 
diff --git a/hw/i386/acpi-build.h b/hw/i386/acpi-build.h
index e57b1aa..132aba2 100644
--- a/hw/i386/acpi-build.h
+++ b/hw/i386/acpi-build.h
@@ -4,6 +4,6 @@
 
 #include "qemu/typedefs.h"
 
-void acpi_setup(PcGuestInfo *);
+void acpi_setup(PCMachineState *pcms);
 
 #endif
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index a17e5b3e..fc98a20 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1179,7 +1179,7 @@ void pc_machine_done(Notifier *notifier, void *data)
         }
     }
 
-    acpi_setup(&pcms->acpi_guest_info);
+    acpi_setup(pcms);
 }
 
 PcGuestInfo *pc_guest_info_init(PCMachineState *pcms)
-- 
2.1.0

  parent reply	other threads:[~2015-12-02  1:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02  1:46 [Qemu-devel] [PATCH 00/16] pc: Eliminate struct PcGuestInfo Eduardo Habkost
2015-12-02  1:46 ` [Qemu-devel] [PATCH 01/16] pc: Move PcGuestInfo declaration to top of file Eduardo Habkost
2015-12-02  1:46 ` [Qemu-devel] [PATCH 02/16] pc: Eliminate struct PcGuestInfoState Eduardo Habkost
2015-12-07 15:19   ` Marcel Apfelbaum
2015-12-02  1:46 ` [Qemu-devel] [PATCH 03/16] pc: Remove guest_info parameter from pc_memory_init() Eduardo Habkost
2015-12-02  1:46 ` Eduardo Habkost [this message]
2015-12-07 15:24   ` [Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument Marcel Apfelbaum
2015-12-08 17:40     ` Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 05/16] acpi: Remove unused build_facs() PcGuestInfo paramter Eduardo Habkost
2015-12-07 15:25   ` Marcel Apfelbaum
2015-12-02  1:47 ` [Qemu-devel] [PATCH 06/16] acpi: Save PCMachineState on AcpiBuildState Eduardo Habkost
2015-12-07 15:39   ` Marcel Apfelbaum
2015-12-08 17:59     ` Eduardo Habkost
2015-12-08 18:44       ` Marcel Apfelbaum
2015-12-09 19:37         ` Igor Mammedov
2015-12-11 14:12           ` Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 07/16] acpi: Make acpi_build() get PCMachineState as argument Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 08/16] acpi: Make build_srat() " Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 09/16] acpi: Remove ram size fields fron PcGuestInfo Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 10/16] pc: Move PcGuestInfo.fw_cfg field to PCMachineState Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 11/16] pc: Simplify signature of xen_load_linux() Eduardo Habkost
2015-12-11 11:40   ` Stefano Stabellini
2015-12-02  1:47 ` [Qemu-devel] [PATCH 12/16] pc: Remove PcGuestInfo.isapc_ram_fw field Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 13/16] q35: Remove MCHPCIState.guest_info field Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 14/16] acpi: Use PCMachineClass fields directly Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 15/16] pc: Move PcGuestInfo.apic_xrupt_override field to PCMachineState Eduardo Habkost
2015-12-02  1:47 ` [Qemu-devel] [PATCH 16/16] pc: Move APIC and NUMA data from PcGuestInfo " Eduardo Habkost
2015-12-07 18:57 ` [Qemu-devel] [PATCH 00/16] pc: Eliminate struct PcGuestInfo Marcel Apfelbaum
2015-12-08 17:53   ` Eduardo Habkost
2015-12-10 11:27     ` Marcel Apfelbaum
2015-12-10 17:45       ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449020831-8414-5-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.