From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Charles (Chas) Williams" <3chas3@gmail.com>
Subject: Re: [PATCH] bnx2x: tx_start_bd->vlan_or_ethertype is le16
Date: Wed, 02 Dec 2015 05:18:55 -0500
Message-ID: <1449051535.2645.49.camel@gmail.com>
References: <1446571576-28399-1-git-send-email-3chas3@gmail.com>
 <3362628.iLARgdqr6m@xps13> <1449014294.2645.42.camel@gmail.com>
 <1462827.BQfOhHUEb5@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com
 [209.85.192.50]) by dpdk.org (Postfix) with ESMTP id CB81A594B
 for <dev@dpdk.org>; Wed,  2 Dec 2015 11:18:56 +0100 (CET)
Received: by qgec40 with SMTP id c40so28702381qge.2
 for <dev@dpdk.org>; Wed, 02 Dec 2015 02:18:56 -0800 (PST)
In-Reply-To: <1462827.BQfOhHUEb5@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 2015-12-02 at 02:04 +0100, Thomas Monjalon wrote:
> 2015-12-01 18:58, Charles  Williams:
> > On Wed, 2015-12-02 at 00:34 +0100, Thomas Monjalon wrote:
> > > 2015-12-01 14:37, Stephen Hemminger:
> > > > Harish Patil <harish.patil@qlogic.com> wrote:
> > > > > >2015-11-03 12:26, Chas Williams:  
> > > > > >> --- a/drivers/net/bnx2x/bnx2x.c
> > > > > >> +++ b/drivers/net/bnx2x/bnx2x.c
> > > > > >> -                            tx_start_bd->vlan_or_ethertype = eh->ether_type;
> > > > > >> +                            tx_start_bd->vlan_or_ethertype
> > > > > >> +                                = rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type));
> > > > > 
> > > > > Minor question - any specific reason to use rte_be_to_cpu_16() on
> > > > > ether_type alone before converting from native order to le16?
> > > > 
> > > > ether_type is in network byte order (big endian)
> > > > and hardware wants little endian. On x86 the second step is a nop.
> > > 
> > > Doesn't it deserve a macro rte_ntole16()?
> > > It may be in lib/librte_eal/common/include/generic/rte_byteorder.h.
> > 
> > I looked I didn't see anything.  This value, according to the linux
> > driver, wants to be little endian regardless of the host endian.
> 
> Yes, that's why I suggest to create some macros to do this kind of conversion.
> Example: rte_ntole16 means "network to little endian 16-bit".
> Do you think it would be clearer to use?

This is the only example of this kind of conversion in the source code
so it would be a macro for one user.  If you create rte_ntole16() you
might feel obligated to create the various permutations for which there
are no consumers.