From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965000AbbLBRj4 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Dec 2015 12:39:56 -0500
Received: from youngberry.canonical.com ([91.189.89.112]:44364 "EHLO
	youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964982AbbLBRjx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Dec 2015 12:39:53 -0500
Message-ID: <1449077987.19481.1.camel@fourier>
Subject: Re: [PATCH 3.19.y-ckt 065/164] megaraid_sas: Expose TAPE drives
 unconditionally
From: Kamal Mostafa <kamal@canonical.com>
To: Sumit Saxena <sumit.saxena@avagotech.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        kernel-team@lists.ubuntu.com,
        Kashyap Desai <kashyap.desai@avagotech.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Date: Wed, 02 Dec 2015 09:39:47 -0800
In-Reply-To: <5ceae479e0184f6578c7e074f51c5de1@mail.gmail.com>
References: <1449075615-20754-1-git-send-email-kamal@canonical.com>
	 <1449075615-20754-66-git-send-email-kamal@canonical.com>
	 <5ceae479e0184f6578c7e074f51c5de1@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-12-02 at 22:39 +0530, Sumit Saxena wrote:
> patch- "aed335e megaraid_sas: Make tape drives visible on PERC5
> controllers" is must along with current patch. Please consider.

Thanks Sumit.  I will pick up aed335e for this 3.19.8-ckt11 release as
well then.

 -Kamal


> > -----Original Message-----
> > From: Kamal Mostafa [mailto:kamal@canonical.com]
> > Sent: Wednesday, December 02, 2015 10:29 PM
> > To: linux-kernel@vger.kernel.org; stable@vger.kernel.org; kernel-
> > team@lists.ubuntu.com
> > Cc: Sumit Saxena; Kashyap Desai; Martin K. Petersen; Kamal Mostafa
> > Subject: [PATCH 3.19.y-ckt 065/164] megaraid_sas: Expose TAPE drives
> > unconditionally
> >
> > 3.19.8-ckt11 -stable review patch.  If anyone has any objections, please
> let me
> > know.
> >
> > ------------------
> >
> > From: "sumit.saxena@avagotech.com" <sumit.saxena@avagotech.com>
> >
> > commit 0d5b47a724bab0ebaaa933d6ff5e584957aaa188 upstream.
> >
> > Expose non-disk (TAPE drive, CD-ROM) unconditionally.
> >
> > Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
> > Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
> > Reviewed-by: Tomas Henzl <thenzl@redhat.com>
> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> > Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> > ---
> >  drivers/scsi/megaraid/megaraid_sas_base.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> > b/drivers/scsi/megaraid/megaraid_sas_base.c
> > index e541c6c..70cf60a 100644
> > --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> > @@ -1681,8 +1681,9 @@ static int megasas_slave_alloc(struct scsi_device
> > *sdev)
> >  		pd_index =
> >  			(sdev->channel * MEGASAS_MAX_DEV_PER_CHANNEL)
> > +
> >  			sdev->id;
> > -		if (instance->pd_list[pd_index].driveState ==
> > -					MR_PD_STATE_SYSTEM) {
> > +		if ((instance->pd_list[pd_index].driveState ==
> > +			MR_PD_STATE_SYSTEM) ||
> > +			(instance->pd_list[pd_index].driveType !=
> TYPE_DISK)) {
> >  			return 0;
> >  		}
> >  		return -ENXIO;
> > --
> > 1.9.1
>