From: Johannes Berg <johannes@sipsolutions.net>
To: "Adam R. Welle" <arwelle@cert.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211_hwsim: check ATTR_FREQ for wmediumd (netlink) packets
Date: Thu, 03 Dec 2015 10:10:34 +0100 [thread overview]
Message-ID: <1449133834.2181.7.camel@sipsolutions.net> (raw)
In-Reply-To: <2DE9F46DD36D2A458CD6347950113F25350A9B@marathon>
On Wed, 2015-12-02 at 19:30 +0000, Adam R. Welle wrote:
> > Applied. I added locking and made a change to accept both the off-
> > channel and non-offchannel since the internal datapath also does
> > that
> > and we don't stop other operation for off-channel.
>
> Does your change only throw away packets when tmp_chan is set? I was
> under the impression that most of the time tmp_chan would be null.
>
Yeah, umm, that expression was wrong. Thanks.
It should be
if (rx_status.freq != data2->channel->center_freq &&
(!data2->tmp_chan ||
rx_status.freq != data2->tmp_chan->center_freq)) {
I'll fix it.
johannes
next prev parent reply other threads:[~2015-12-03 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 22:13 [PATCH v2] mac80211_hwsim: check ATTR_FREQ for wmediumd (netlink) packets arwelle
2015-12-02 9:57 ` Johannes Berg
2015-12-02 19:30 ` Adam R. Welle
2015-12-03 9:10 ` Johannes Berg [this message]
2015-12-03 14:18 ` Adam R. Welle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449133834.2181.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arwelle@cert.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.