All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haozhong Zhang <haozhong.zhang@intel.com>
To: xen-devel@lists.xen.org
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
	Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: [PATCH v2 05/14] x86/hvm: Scale host TSC when setting/getting guest TSC
Date: Mon,  7 Dec 2015 04:58:40 +0800	[thread overview]
Message-ID: <1449435529-12989-6-git-send-email-haozhong.zhang@intel.com> (raw)
In-Reply-To: <1449435529-12989-1-git-send-email-haozhong.zhang@intel.com>

The existing hvm_[set|get]_guest_tsc_fixed() calculate the guest TSC by
adding the TSC offset to the host TSC. When the TSC scaling is enabled,
the host TSC should be scaled first. This patch adds the scaling logic
to those two functions.

Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
---
 xen/arch/x86/hvm/hvm.c        | 17 +++++++----------
 xen/arch/x86/hvm/svm/svm.c    | 12 ++++++++++++
 xen/include/asm-x86/hvm/hvm.h |  2 ++
 3 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 6c2b512..0e63c33 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -60,6 +60,7 @@
 #include <asm/hvm/nestedhvm.h>
 #include <asm/hvm/event.h>
 #include <asm/hvm/vmx/vmx.h>
+#include <asm/hvm/svm/svm.h> /* for cpu_has_tsc_ratio */
 #include <asm/altp2m.h>
 #include <asm/mtrr.h>
 #include <asm/apic.h>
@@ -310,13 +311,11 @@ void hvm_set_guest_tsc_fixed(struct vcpu *v, u64 guest_tsc, u64 at_tsc)
         tsc = hvm_get_guest_time_fixed(v, at_tsc);
         tsc = gtime_to_gtsc(v->domain, tsc);
     }
-    else if ( at_tsc )
-    {
-        tsc = at_tsc;
-    }
     else
     {
-        tsc = rdtsc();
+        tsc = at_tsc ?: rdtsc();
+        if ( cpu_has_tsc_ratio )
+            tsc = hvm_funcs.scale_tsc(v, tsc);
     }
 
     delta_tsc = guest_tsc - tsc;
@@ -344,13 +343,11 @@ u64 hvm_get_guest_tsc_fixed(struct vcpu *v, uint64_t at_tsc)
         tsc = hvm_get_guest_time_fixed(v, at_tsc);
         tsc = gtime_to_gtsc(v->domain, tsc);
     }
-    else if ( at_tsc )
-    {
-        tsc = at_tsc;
-    }
     else
     {
-        tsc = rdtsc();
+        tsc = at_tsc ?: rdtsc();
+        if ( cpu_has_tsc_ratio )
+            tsc = hvm_funcs.scale_tsc(v, tsc);
     }
 
     return tsc + v->arch.hvm_vcpu.cache_tsc_offset;
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 1e6529e..9d5f2c3 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -804,6 +804,16 @@ static uint64_t scale_tsc(uint64_t host_tsc, uint64_t ratio)
     return scaled_host_tsc;
 }
 
+static uint64_t svm_scale_tsc(struct vcpu *v, uint64_t tsc)
+{
+    struct domain *d = v->domain;
+
+    if ( !cpu_has_tsc_ratio || d->arch.vtsc )
+        return tsc;
+
+    return scale_tsc(tsc, vcpu_tsc_ratio(v));
+}
+
 static uint64_t svm_get_tsc_offset(uint64_t host_tsc, uint64_t guest_tsc,
     uint64_t ratio)
 {
@@ -2270,6 +2280,8 @@ static struct hvm_function_table __initdata svm_function_table = {
     .nhvm_vmcx_hap_enabled = nsvm_vmcb_hap_enabled,
     .nhvm_intr_blocked = nsvm_intr_blocked,
     .nhvm_hap_walk_L1_p2m = nsvm_hap_walk_L1_p2m,
+
+    .scale_tsc            = svm_scale_tsc,
 };
 
 void svm_vmexit_handler(struct cpu_user_regs *regs)
diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h
index f80e143..aba63ab 100644
--- a/xen/include/asm-x86/hvm/hvm.h
+++ b/xen/include/asm-x86/hvm/hvm.h
@@ -212,6 +212,8 @@ struct hvm_function_table {
     void (*altp2m_vcpu_update_vmfunc_ve)(struct vcpu *v);
     bool_t (*altp2m_vcpu_emulate_ve)(struct vcpu *v);
     int (*altp2m_vcpu_emulate_vmfunc)(struct cpu_user_regs *regs);
+
+    uint64_t (*scale_tsc)(struct vcpu *v, uint64_t tsc);
 };
 
 extern struct hvm_function_table hvm_funcs;
-- 
2.6.3

  parent reply	other threads:[~2015-12-06 20:58 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 20:58 [PATCH v2 00/14] Add VMX TSC scaling support Haozhong Zhang
2015-12-06 20:58 ` [PATCH v2 01/14] svm: Fix incorrect TSC scaling Haozhong Zhang
2015-12-07 16:49   ` Boris Ostrovsky
2015-12-06 20:58 ` [PATCH v2 02/14] x86/time.c: Fix domain type check in tsc_set_info() Haozhong Zhang
2015-12-07 16:49   ` Boris Ostrovsky
2015-12-06 20:58 ` [PATCH v2 03/14] x86/time.c: Use correct guest TSC frequency " Haozhong Zhang
2015-12-07 16:57   ` Boris Ostrovsky
2015-12-08  0:30     ` Haozhong Zhang
2015-12-06 20:58 ` [PATCH v2 04/14] x86/time.c: Use correct guest TSC frequency in tsc_get_info() Haozhong Zhang
2015-12-07 17:53   ` Boris Ostrovsky
2015-12-08  1:08     ` Haozhong Zhang
2015-12-08 18:26       ` Boris Ostrovsky
2015-12-10  0:14         ` Haozhong Zhang
2015-12-06 20:58 ` Haozhong Zhang [this message]
2015-12-07 17:54   ` [PATCH v2 05/14] x86/hvm: Scale host TSC when setting/getting guest TSC Boris Ostrovsky
2015-12-06 20:58 ` [PATCH v2 06/14] x86/time.c: Scale host TSC in pvclock properly Haozhong Zhang
2015-12-07 18:14   ` Boris Ostrovsky
2015-12-08  1:52     ` Haozhong Zhang
2015-12-08 19:21       ` Boris Ostrovsky
2015-12-10  0:23         ` Haozhong Zhang
2015-12-10 11:56           ` Joao Martins
2015-12-29 18:22             ` Joao Martins
2015-12-30  1:07               ` Haozhong Zhang
2015-12-06 20:58 ` [PATCH v2 07/14] svm: Remove redundant TSC scaling in svm_set_tsc_offset() Haozhong Zhang
2015-12-07 18:25   ` Boris Ostrovsky
2015-12-08  1:54     ` Haozhong Zhang
2015-12-06 20:58 ` [PATCH v2 08/14] x86/hvm: Collect information of TSC scaling ratio Haozhong Zhang
2015-12-07 18:31   ` Boris Ostrovsky
2015-12-10 10:19   ` Tian, Kevin
2015-12-10 10:27     ` Zhang, Haozhong
2015-12-06 20:58 ` [PATCH v2 09/14] x86/hvm: Setup " Haozhong Zhang
2015-12-07 18:42   ` Boris Ostrovsky
2015-12-08  1:58     ` Haozhong Zhang
2015-12-10 10:27   ` Tian, Kevin
2015-12-10 10:37     ` Zhang, Haozhong
2015-12-06 20:58 ` [PATCH v2 10/14] x86/hvm: Replace architecture TSC scaling by a common function Haozhong Zhang
2015-12-07 18:55   ` Boris Ostrovsky
2015-12-08  2:06     ` Haozhong Zhang
2015-12-10 10:29   ` Tian, Kevin
2015-12-06 20:58 ` [PATCH v2 11/14] x86/hvm: Move saving/loading vcpu's TSC to common code Haozhong Zhang
2015-12-07 18:56   ` Boris Ostrovsky
2015-12-10 10:30   ` Tian, Kevin
2015-12-06 20:58 ` [PATCH v2 12/14] x86/hvm: Detect TSC scaling through hvm_funcs Haozhong Zhang
2015-12-07 18:58   ` Boris Ostrovsky
2015-12-10 10:31   ` Tian, Kevin
2015-12-06 20:58 ` [PATCH v2 13/14] vmx: Add VMX RDTSC(P) scaling support Haozhong Zhang
2015-12-10 10:33   ` Tian, Kevin
2015-12-06 20:58 ` [PATCH v2 14/14] docs: Add descriptions of TSC scaling in xl.cfg and tscmode.txt Haozhong Zhang
2015-12-10 10:40   ` Tian, Kevin
2015-12-10 10:56     ` Zhang, Haozhong
2015-12-06 21:14 ` [PATCH v2 00/14] Add VMX TSC scaling support Haozhong Zhang
2015-12-07  9:03   ` Egger, Christoph
2015-12-07 10:16     ` Haozhong Zhang
2015-12-07 17:04       ` Andrew Cooper
2015-12-08  2:13         ` Haozhong Zhang
2015-12-10 10:43         ` Tian, Kevin
2015-12-10 11:13           ` Haozhong Zhang
2015-12-11  7:35             ` Tian, Kevin
2015-12-11 10:09               ` Andrew Cooper
2015-12-07 10:37   ` Jan Beulich
2015-12-07 10:56     ` Haozhong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449435529-12989-6-git-send-email-haozhong.zhang@intel.com \
    --to=haozhong.zhang@intel.com \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.