From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a65Iv-0000Gt-4W for qemu-devel@nongnu.org; Mon, 07 Dec 2015 18:34:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a65Iu-0006S1-9U for qemu-devel@nongnu.org; Mon, 07 Dec 2015 18:34:49 -0500 From: John Snow Date: Mon, 7 Dec 2015 18:34:35 -0500 Message-Id: <1449531275-30362-11-git-send-email-jsnow@redhat.com> In-Reply-To: <1449531275-30362-1-git-send-email-jsnow@redhat.com> References: <1449531275-30362-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH for-2.6 v2 10/10] fdc: change auto fallback drive to 288 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, John Snow , armbru@redhat.com, qemu-devel@nongnu.org The 2.88 drive is more suitable as a default because it can still read 1.44 images correctly, but the reverse is not true. Since there exist virtio-win drivers that are shipped on 2.88 floppy images, this patch will allow VMs booted without a floppy disk inserted to later insert a 2.88MB floppy and have that work. This patch has been tested with msdos, freedos, fedora, windows 8 and windows 10 without issue: if problems do arise for certain guests being unable to cope with 2.88MB drives as the default, they are in the minority and can use type=144 as needed (or insert a proper boot medium and omit type=144/288 or use type=auto) to obtain different drive types. Signed-off-by: John Snow --- hw/block/fdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 246bd83..a82ddd0 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -79,7 +79,7 @@ typedef struct FDFormat { * no media is inserted. */ #define FDRIVE_DEFAULT FLOPPY_DRIVE_TYPE_AUTO -#define FDRIVE_AUTO_FALLBACK FLOPPY_DRIVE_TYPE_144 +#define FDRIVE_AUTO_FALLBACK FLOPPY_DRIVE_TYPE_288 /* In many cases, the total sector size of a format is enough to uniquely * identify it. However, there are some total sector collisions between -- 2.4.3