From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] mmc: mmc: Don't use sprintf when using tiny-printf
Date: Tue, 08 Dec 2015 08:34:17 +0100 [thread overview]
Message-ID: <1449560057.2948.9.camel@collabora.co.uk> (raw)
In-Reply-To: <CAPnjgZ21cw2eXFJ7Rr1Rjf27muEP7RaLZG3aYa8c1ppts7jamg@mail.gmail.com>
On Mon, 2015-12-07 at 17:40 -0700, Simon Glass wrote:
> On 4 December 2015 at 15:27, Sjoerd Simons
> <sjoerd.simons@collabora.co.uk> wrote:
> > There is no sprintf implementation in tiny-printf, so don't try to
> > use
> > it when tiny-printf if used.
> >
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > ---
> >
> > ?drivers/mmc/mmc.c | 4 +++-
> > ?1 file changed, 3 insertions(+), 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>
> Tested on firefly:
> Tested-by: Simon Glass <sjg@chromium.org>
>
> I can't help thinking that sprintf() would not add a lot more code...
Probably not (it's write to buffer rather then write to output, so
maybe just passing a function pointer for an out function in would just
do the job). More work then I had time for though :/
Though i'm not sure it's worth it though (at least on firefly the spl
won't output those fields) :)
--
Sjoerd Simons
Collabora Ltd.
next prev parent reply other threads:[~2015-12-08 7:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 22:27 [U-Boot] [PATCH 0/7] Switch rockchip firefly to using tiny-printf Sjoerd Simons
2015-12-04 22:27 ` [U-Boot] [PATCH 1/7] spl: use panic_str instead of panic Sjoerd Simons
2015-12-06 16:45 ` Simon Glass
2015-12-08 0:39 ` Simon Glass
2015-12-14 3:44 ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 2/7] spl: mmc: Explicitly init mmc struct Sjoerd Simons
2015-12-06 16:45 ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 3/7] lib/tiny-printf.c: Implement vprintf Sjoerd Simons
2015-12-08 0:39 ` Simon Glass
2015-12-14 3:44 ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 4/7] lib: Split panic functions out of vsprintf.c Sjoerd Simons
2015-12-08 0:39 ` Simon Glass
2015-12-08 7:27 ` Sjoerd Simons
2015-12-08 19:34 ` Simon Glass
2015-12-08 19:36 ` Scott Wood
2015-12-08 19:38 ` Simon Glass
2015-12-14 3:45 ` Simon Glass
2015-12-14 7:38 ` Sjoerd Simons
2015-12-04 22:27 ` [U-Boot] [PATCH 5/7] lib: split out strtoxxxx " Sjoerd Simons
2015-12-08 0:39 ` Simon Glass
2015-12-08 7:30 ` Sjoerd Simons
2015-12-14 3:45 ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 6/7] mmc: mmc: Don't use sprintf when using tiny-printf Sjoerd Simons
2015-12-08 0:40 ` Simon Glass
2015-12-08 7:34 ` Sjoerd Simons [this message]
2015-12-14 3:45 ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 7/7] rockchip: firefly: Use tiny-printf Sjoerd Simons
2015-12-08 0:40 ` Simon Glass
2015-12-14 3:45 ` Simon Glass
2015-12-05 10:00 ` [U-Boot] [PATCH 0/7] Switch rockchip firefly to using tiny-printf Stefan Roese
2015-12-07 21:43 ` Simon Glass
2015-12-07 21:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449560057.2948.9.camel@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.