From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44395 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbbLIDaF (ORCPT ); Tue, 8 Dec 2015 22:30:05 -0500 Subject: Patch "netlink: Add missing goto statement to netlink_insert" has been added to the 4.1-stable tree To: herbert@gondor.apana.org.au, davem@davemloft.net, fweimer@redhat.com, gregkh@linuxfoundation.org, hannes@stressinduktion.org, j.winkel@profihost.ag, m.schinkel@profihost.ag, pmhahn@pmhahn.de, s.priebe@profihost.ag, tglx@linutronix.de Cc: , From: Date: Tue, 08 Dec 2015 22:30:01 -0500 In-Reply-To: <20151208061319.GA16209@gondor.apana.org.au> Message-ID: <14496318017374@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled netlink: Add missing goto statement to netlink_insert to the 4.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: netlink-add-missing-goto-statement-to-netlink_insert.patch and it can be found in the queue-4.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From herbert@gondor.apana.org.au Tue Dec 8 22:28:59 2015 From: Herbert Xu Date: Tue, 8 Dec 2015 14:13:19 +0800 Subject: netlink: Add missing goto statement to netlink_insert To: Stefan Priebe - Profihost AG Cc: Hannes Frederic Sowa , Florian Weimer , Thomas Gleixner , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jannik Winkel , Marco Schinkel , "David S. Miller" , stable@vger.kernel.org Message-ID: <20151208061319.GA16209@gondor.apana.org.au> Content-Disposition: inline From: Herbert Xu The backport of 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink: Fix autobind race condition that leads to zero port ID") missed a goto statement, which causes netlink to break subtly. This was discovered by Stefan Priebe . Fixes: 4e2776241766 ("netlink: Fix autobind race condition that...") Reported-by: Stefan Priebe Reported-by: Philipp Hahn Signed-off-by: Herbert Xu Acked-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/netlink/af_netlink.c | 1 + 1 file changed, 1 insertion(+) --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1118,6 +1118,7 @@ static int netlink_insert(struct sock *s if (err == -EEXIST) err = -EADDRINUSE; sock_put(sk); + goto err; } /* We need to ensure that the socket is hashed and visible. */ Patches currently in stable-queue which might be from herbert@gondor.apana.org.au are queue-4.1/netlink-add-missing-goto-statement-to-netlink_insert.patch