From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753694AbbLIEKL (ORCPT ); Tue, 8 Dec 2015 23:10:11 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:36773 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbbLIEIV (ORCPT ); Tue, 8 Dec 2015 23:08:21 -0500 X-AuditID: cbfee690-f79646d000001316-d2-5667a9306fb4 From: Chanwoo Choi To: myungjoo.ham@samsung.com, k.kozlowski@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 05/19] PM / devfreq: Add new passive governor Date: Wed, 09 Dec 2015 13:07:57 +0900 Message-id: <1449634091-1842-6-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsWyRsSkWNdgZXqYwdE+AYvrX56zWsw/co7V ov/NQlaLc69WMlq8fmFo0f/4NbPF2aY37BaXd81hs/jce4TRYsb5fUwW6zbeYre4fZnXYun1 i0wWtxtXsFlMmL6WxaJ17xF2i7bVH1gdBD3WzFvD6NHS3MPmcbmvl8lj56y77B4rl39h89i0 qpPN498xdo++LasYPT5vkgvgjOKySUnNySxLLdK3S+DKODzvB2PBMd+KHzPnszcwdjt0MXJy SAiYSKy8s5AVwhaTuHBvPVsXIxeHkMAKRomri/4zwxQtuX6DCSIxi1Hie8ddZgjnC6PE52ut bCBVbAJaEvtf3ACzRQTcJb7e2w02ilngC5NE6+TvYKOEBRwk1i9cwQ5iswioSjyd+4cRxOYV cJHY9/4dI8Q6OYkPex6B1XAKuEpc2Q4RFwKqOfa0CewMCYG/7BLHHx9lhBgkIPFt8iGWLkYO oISsxKYDUGdLShxccYNlAqPwAkaGVYyiqQXJBcVJ6UUmesWJucWleel6yfm5mxiBEXf637MJ OxjvHbA+xCjAwajEw3vBJT1MiDWxrLgy9xCjKdCGicxSosn5wLjOK4k3NDYzsjA1MTU2Mrc0 UxLnfS31M1hIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDI+ein7aVR+o3ffjmk9VZ9EJ85cuE zmlGGypZT5ZlPzhnZb5FqYGxVbz5zpPzn3tWxT6cLDZpXmjlp1UfwmwjF+rzzyhx3mnDrBtU wnmq3pLz/rm/cs2Fz6/4ntOvzXm0vcUv9ErjqQbd+sdXQh9Ks1eHfbt07CNnq6ONcs0USdn7 1vOyJnGeVGIpzkg01GIuKk4EAJA+/qGzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jQV2DlelhBueec1hc//Kc1WL+kXOs Fv1vFrJanHu1ktHi9QtDi/7Hr5ktzja9Ybe4vGsOm8Xn3iOMFjPO72OyWLfxFrvF7cu8Fkuv X2SyuN24gs1iwvS1LBate4+wW7St/sDqIOixZt4aRo+W5h42j8t9vUweO2fdZfdYufwLm8em VZ1sHv+OsXv0bVnF6PF5k1wAZ1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5 kkJeYm6qrZKLT4CuW2YO0CtKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIa xozD834wFhzzrfgxcz57A2O3QxcjJ4eEgInEkus3mCBsMYkL99azdTFycQgJzGKU+N5xlxnC +cIo8flaKxtIFZuAlsT+FzfAbBEBd4mv93aDdTALfGGSaJ38nRkkISzgILF+4Qp2EJtFQFXi 6dw/jCA2r4CLxL737xgh1slJfNjzCKyGU8BV4sp2iLgQUM2xp01MExh5FzAyrGKUSC1ILihO Ss81zEst1ytOzC0uzUvXS87P3cQIjupnUjsYD+5yP8QowMGoxMN7wSU9TIg1say4MvcQowQH s5IIr1YtUIg3JbGyKrUoP76oNCe1+BCjKdBhE5mlRJPzgQknryTe0NjEzMjSyNzQwsjYXEmc t/ZSZJiQQHpiSWp2ampBahFMHxMHp1QDY7Xjs4nrCzftbqsqiVz0gcH8atqBuJ4dcu+SC2Oe +J46tD77+Yn1/G7GX9hKAhbz5i/Y0zkrctZ8Q76LZS+mPzs/r6IhSFovL/CayGXWmzNfr1q3 IPXVnjmL1j0Wed+61z3reZ9aldKnLF7OX307nBhWXT3c+yjH3qO/SpnfdWnY6ZAJ1ZtKQpVY ijMSDbWYi4oTAWVY3ngAAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds the new passive governor for DEVFREQ framework. The following governors are already present and used for DVFS (Dynamic Voltage and Frequency Scaling) drivers. The following governors are independently used for one device driver which don't give the influence to other device drviers and also don't receive the effect from other device drivers. - ondemand / performance / powersave / userspace The passive governor depends on operation of parent driver with specific governos extremely and is not able to decide the new frequency by oneself. According to the decided new frequency of parent driver with governor, the passive governor uses it to decide the appropriate frequency for own device driver. The passive governor must need the following information from device tree: - the source clock and OPP tables - the instance of parent device For exameple, there are one more devfreq device drivers which need to change their source clock according to their utilization on runtime. But, they share the same power line (e.g., regulator). So, specific device driver is operated as parent with ondemand governor and then the rest device driver with passive governor is influenced by parent device. Suggested-by: Myungjoo Ham Signed-off-by: Chanwoo Choi --- drivers/devfreq/Kconfig | 9 ++++ drivers/devfreq/Makefile | 1 + drivers/devfreq/devfreq.c | 47 ++++++++++++++++ drivers/devfreq/governor_passive.c | 108 +++++++++++++++++++++++++++++++++++++ include/linux/devfreq.h | 17 ++++++ 5 files changed, 182 insertions(+) create mode 100644 drivers/devfreq/governor_passive.c diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 55ec774f794c..d03f635a93e1 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -64,6 +64,15 @@ config DEVFREQ_GOV_USERSPACE Otherwise, the governor does not change the frequnecy given at the initialization. +config DEVFREQ_GOV_PASSIVE + tristate "Passive" + help + Sets the frequency by other governors (simple_ondemand, performance, + powersave, usersapce) of a parent devfreq device. This governor + always has the dependency on the chosen frequency from paired + governor. This governor does not change the frequency by oneself + through sysfs entry. + comment "DEVFREQ Drivers" config ARM_EXYNOS_BUS_DEVFREQ diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile index 375ebbb4fcfb..f81c313b4b79 100644 --- a/drivers/devfreq/Makefile +++ b/drivers/devfreq/Makefile @@ -4,6 +4,7 @@ obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) += governor_simpleondemand.o obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o +obj-$(CONFIG_DEVFREQ_GOV_PASSIVE) += governor_passive.o # DEVFREQ Drivers obj-$(CONFIG_ARCH_EXYNOS) += exynos/ diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 984c5e9e7bdd..15e58779e4c0 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -190,6 +190,31 @@ static struct devfreq_governor *find_devfreq_governor(const char *name) /* Load monitoring helper functions for governors use */ +static int update_devfreq_passive(struct devfreq *devfreq, unsigned long freq) +{ + struct devfreq *passive; + unsigned long rate; + int ret; + + list_for_each_entry(passive, &devfreq->passive_dev_list, passive_node) { + if (!passive->governor) + continue; + rate = freq; + + ret = passive->governor->get_target_freq(passive, &rate); + if (ret) + return ret; + + ret = passive->profile->target(passive->dev.parent, &rate, 0); + if (ret) + return ret; + + passive->previous_freq = rate; + } + + return 0; +} + /** * update_devfreq() - Reevaluate the device and configure frequency. * @devfreq: the devfreq instance. @@ -233,10 +258,18 @@ int update_devfreq(struct devfreq *devfreq) flags |= DEVFREQ_FLAG_LEAST_UPPER_BOUND; /* Use LUB */ } + if (!list_empty(&devfreq->passive_dev_list) + && devfreq->previous_freq > freq) + update_devfreq_passive(devfreq, freq); + err = devfreq->profile->target(devfreq->dev.parent, &freq, flags); if (err) return err; + if (!list_empty(&devfreq->passive_dev_list) + && devfreq->previous_freq < freq) + update_devfreq_passive(devfreq, freq); + if (devfreq->profile->freq_table) if (devfreq_update_status(devfreq, freq)) dev_err(&devfreq->dev, @@ -442,6 +475,10 @@ static void _remove_devfreq(struct devfreq *devfreq) return; } list_del(&devfreq->node); + list_del(&devfreq->passive_node); + if (!list_empty(&devfreq->passive_dev_list)) + list_del_init(&devfreq->passive_dev_list); + mutex_unlock(&devfreq_list_lock); if (devfreq->governor) @@ -559,6 +596,16 @@ struct devfreq *devfreq_add_device(struct device *dev, goto err_init; } + if (!strncmp(devfreq->governor_name, "passive", 7)) { + struct devfreq *parent_devfreq = + ((struct devfreq_passive_data *)data)->parent; + + list_add(&devfreq->passive_node, + &parent_devfreq->passive_dev_list); + } else { + INIT_LIST_HEAD(&devfreq->passive_dev_list); + } + return devfreq; err_init: diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c new file mode 100644 index 000000000000..7443ae4b92f9 --- /dev/null +++ b/drivers/devfreq/governor_passive.c @@ -0,0 +1,108 @@ +/* + * linux/drivers/devfreq/governor_passive.c + * + * Copyright (C) 2015 Samsung Electronics + * Author: Chanwoo Choi + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include +#include +#include +#include +#include "governor.h" + +static int devfreq_passive_get_target_freq(struct devfreq *passive, + unsigned long *freq) +{ + struct devfreq_passive_data *passive_data = passive->data; + struct devfreq *parent_devfreq = passive_data->parent; + unsigned long child_freq = ULONG_MAX; + int i, count; + + /* + * Each devfreq has the OPP table. After deciding the new frequency + * from the governor of parent devfreq device, the passive governor + * need to get the index of new frequency on OPP table of parent + * device. And then the index is used for getting the suitable + * new frequency for passive devfreq device. + */ + + if (!passive->profile || !passive->profile->freq_table + || passive->profile->max_state <= 0) + return -EINVAL; + + /* + * When new frequency is lower than previous frequency of parent + * devfreq device, passive governor get the correct frequency from OPP + * list of parent device. Because in this case, *freq is temporary + * value which is decided by ondemand governor. + */ + if (parent_devfreq->previous_freq > *freq) { + struct dev_pm_opp *opp; + opp = devfreq_recommended_opp(parent_devfreq->dev.parent, + freq, 0); + if (IS_ERR_OR_NULL(opp)) + return PTR_ERR(opp); + } + + /* + * Get the OPP table's index of decided freqeuncy by governor + * of parent device. + */ + for (i = 0; i < parent_devfreq->profile->max_state; i++) + if (parent_devfreq->profile->freq_table[i] == *freq) + break; + + if (i == parent_devfreq->profile->max_state) + return -EINVAL; + count = passive->profile->max_state; + + /* Get the suitable frequency by using index of parent device. */ + if (i < passive->profile->max_state) + child_freq = passive->profile->freq_table[i]; + else + child_freq = passive->profile->freq_table[count - 1]; + + /* Return the suitable frequency for passive device. */ + *freq = child_freq; + + return 0; +} + +static int devfreq_passive_event_handler(struct devfreq *devfreq, + unsigned int event, void *data) +{ + return 0; +} + +static struct devfreq_governor devfreq_passive = { + .name = "passive", + .get_target_freq = devfreq_passive_get_target_freq, + .event_handler = devfreq_passive_event_handler, +}; + +static int __init devfreq_passive_init(void) +{ + return devfreq_add_governor(&devfreq_passive); +} +subsys_initcall(devfreq_passive_init); + +static void __exit devfreq_passive_exit(void) +{ + int ret; + + ret = devfreq_remove_governor(&devfreq_passive); + if (ret) + pr_err("%s: failed remove governor %d\n", __func__, ret); + + return; +} +module_exit(devfreq_passive_exit); + +MODULE_AUTHOR("Chanwoo Choi "); +MODULE_DESCRIPTION("DEVFREQ Passive governor"); +MODULE_LICENSE("GPL v2"); diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index 6fa02a20eb63..f7a6e6bd716e 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -177,6 +177,9 @@ struct devfreq { unsigned int *trans_table; unsigned long *time_in_state; unsigned long last_stat_updated; + + struct list_head passive_dev_list; + struct list_head passive_node; }; #if defined(CONFIG_PM_DEVFREQ) @@ -241,6 +244,20 @@ struct devfreq_simple_ondemand_data { }; #endif +#if IS_ENABLED(CONFIG_DEVFREQ_GOV_PASSIVE) +/** + * struct devfreq_passive_data - void *data fed to struct devfreq + * and devfreq_add_device + * @parent: The parent devfreq device. + * + * If the fed devfreq_passive_data pointer is NULL to the governor, + * the governor return ERROR. + */ +struct devfreq_passive_data { + struct devfreq *parent; +}; +#endif + #else /* !CONFIG_PM_DEVFREQ */ static inline struct devfreq *devfreq_add_device(struct device *dev, struct devfreq_dev_profile *profile, -- 1.9.1