All of lore.kernel.org
 help / color / mirror / Atom feed
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)
Date: Thu, 10 Dec 2015 01:53:30 +0100	[thread overview]
Message-ID: <1449708810-17891-1-git-send-email-marcandre.lureau@redhat.com> (raw)

From: Marc-André Lureau <marcandre.lureau@redhat.com>

"type" is not POSIX shell, but a bashism. (found thanks to shellcheck)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index ba57b3f..90eff82 100755
--- a/configure
+++ b/configure
@@ -158,7 +158,7 @@ symlink() {
 # check whether a command is available to this shell (may be either an
 # executable or a builtin)
 has() {
-    type "$1" >/dev/null 2>&1
+    which "$1" >/dev/null 2>&1
 }
 
 # search for an executable in PATH
-- 
2.5.0

             reply	other threads:[~2015-12-10  0:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10  0:53 marcandre.lureau [this message]
2015-12-10  0:57 ` [Qemu-devel] [PATCH] configure: remove bashism (since 2010) Marc-André Lureau
2015-12-10  2:52   ` Eric Blake
2015-12-10  2:51 ` Eric Blake
2015-12-10  9:46   ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449708810-17891-1-git-send-email-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.