From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: [PATCH v1 2/2] examples/l2fwd-keepalive: Fix integer overflow Date: Thu, 10 Dec 2015 09:50:07 +0000 Message-ID: <1449741007-1022-3-git-send-email-remy.horton@intel.com> References: <1449741007-1022-1-git-send-email-remy.horton@intel.com> To: dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BAFB45A6C for ; Thu, 10 Dec 2015 10:50:11 +0100 (CET) In-Reply-To: <1449741007-1022-1-git-send-email-remy.horton@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix Coverity warning with potential 32-bit integer multiplication overflow where final result is expected to be 64-bit. >>> CID 120144 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application") Signed-off-by: Remy Horton --- examples/l2fwd-keepalive/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index 8d7b09e..f4d52f2 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -471,7 +471,7 @@ l2fwd_parse_args(int argc, char **argv) /* timer period */ case 'T': timer_period = l2fwd_parse_timer_period(optarg) - * 1000 * TIMER_MILLISECOND; + * (int64_t)(1000 * TIMER_MILLISECOND); if (timer_period < 0) { printf("invalid timer period\n"); l2fwd_usage(prgname); -- 1.9.3