From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbbLJQ0o (ORCPT ); Thu, 10 Dec 2015 11:26:44 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:33571 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751876AbbLJQ0m (ORCPT ); Thu, 10 Dec 2015 11:26:42 -0500 Message-ID: <1449764796.8217.1.camel@fourier> Subject: Re: [PATCH 3.19.y-ckt 084/164] thermal: exynos: Fix unbalanced regulator disable on probe failure From: Kamal Mostafa To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, k.kozlowski.k@gmail.com, Eduardo Valentin Date: Thu, 10 Dec 2015 08:26:36 -0800 In-Reply-To: <5668CC21.1070103@samsung.com> References: <1449075615-20754-1-git-send-email-kamal@canonical.com> <1449075615-20754-85-git-send-email-kamal@canonical.com> <56682B8F.20006@samsung.com> <5668CC21.1070103@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-12-10 at 09:49 +0900, Krzysztof Kozlowski wrote: > On 09.12.2015 22:24, Krzysztof Kozlowski wrote: > > W dniu 03.12.2015 o 01:58, Kamal Mostafa pisze: > >> 3.19.8-ckt11 -stable review patch. If anyone has any objections, please let me know. > >> > >> ------------------ > >> > >> From: Krzysztof Kozlowski > >> > >> commit 824ead03b78403a21449cb7eb153a4344cd3b4c8 upstream. > >> > >> During probe if the regulator could not be enabled, the error exit path > >> would still disable it. This could lead to unbalanced counter of > >> regulator enable/disable. > >> > >> The patch moves code for getting and enabling the regulator from > >> exynos_map_dt_data() to probe function because it is really not a part > >> of getting Device Tree properties. > >> > >> Acked-by: Lukasz Majewski > >> Tested-by: Lukasz Majewski > >> Reviewed-by: Alim Akhtar > >> Signed-off-by: Krzysztof Kozlowski > >> Fixes: 5f09a5cbd14a ("thermal: exynos: Disable the regulator on probe failure") > >> Signed-off-by: Eduardo Valentin > >> Signed-off-by: Kamal Mostafa > >> --- > >> drivers/thermal/samsung/exynos_tmu.c | 33 ++++++++++++++++----------------- > >> 1 file changed, 16 insertions(+), 17 deletions(-) > > > > This patch shouldn't be backported before 4.2. It fixes a bug introduced > > in 4.2: 5f09a5cbd14a. > > > > For kernels <4.2 this bug does not exist but fortunately the patch looks > > harmless. Anyway I think that still it shouldn't be ported for <4.2. > > > > Best regards, > > Krzysztof > > > > Sorry for the noise, I was wrong. Luis pointed out that the 5f09a5cbd14a > was itself backported to 3.19 so this applies to backporting as well. No worries. Thanks for reviewing this, Krzysztof. -Kamal > No objections from my side. > > Best regards, > Krzysztof >