From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:64888 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932226AbbLNKHz (ORCPT ); Mon, 14 Dec 2015 05:07:55 -0500 From: Andrzej Hajda To: QCA ath9k Development Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Kalle Valo , linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Date: Mon, 14 Dec 2015 11:06:01 +0100 Message-id: <1450087564-28441-4-git-send-email-a.hajda@samsung.com> (sfid-20151214_110847_526594_0F198972) In-reply-to: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: The function can return negative values in case of error. Its result should be then tested for such case. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c index a680a97..fe1fd1a 100644 --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c @@ -834,7 +834,7 @@ void ath9k_htc_ani_work(struct work_struct *work) if (longcal || shortcal) common->ani.caldone = ath9k_hw_calibrate(ah, ah->curchan, - ah->rxchainmask, longcal); + ah->rxchainmask, longcal) > 0; ath9k_htc_ps_restore(priv); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932337AbbLNKH5 (ORCPT ); Mon, 14 Dec 2015 05:07:57 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:64888 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932226AbbLNKHz (ORCPT ); Mon, 14 Dec 2015 05:07:55 -0500 X-AuditID: cbfec7f5-f79b16d000005389-1a-566e94f80d36 From: Andrzej Hajda To: QCA ath9k Development Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Kalle Valo , linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Date: Mon, 14 Dec 2015 11:06:01 +0100 Message-id: <1450087564-28441-4-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFLMWRmVeSWpSXmKPExsVy+t/xy7o/puSFGRzq4bC4te4cq8WmJfeZ LH539zJabJyxntVi0cqFbBaXd81hs3iz4g67xdojd9ktji0Qc+D0uNzXy+TRML2L3ePQhyOs Hn1bVjF6fN4kF8AaxWWTkpqTWZZapG+XwJXRe/8yU8Fb9orHE2azNDBeZOti5OCQEDCR2Lba rouRE8gUk7hwbz1QmItDSGApo8S2iXOZIJwmJolba+8xglSxCWhK/N18E6xZRMBC4vRCdpAa ZoFVTBKNnxeD1QgLeEucadzLDmKzCKhKNLcdBrN5BZwlph/fzgaxTU7i5LHJrCBzOAVcJGZu LAYxhYBKbv2NmsDIu4CRYRWjaGppckFxUnqukV5xYm5xaV66XnJ+7iZGSIh93cG49JjVIUYB DkYlHt6MZblhQqyJZcWVuYcYJTiYlUR4E6zywoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1 PkRIID2xJDU7NbUgtQgmy8TBKdXAmK/GyPJNc8YEwwL/1QXfD6tMVvxd01o0J+zwxc1G2x+X dQcoLxURbK2+JBRoM2Xyg7LefT9+nqo9U5V7zpY1//wbdRMZyexAceYT1t+ylrpvWGR85pGz tc7t8xcEY+Xd10d7HpijJBszOfpOvX9jQ2a0bIrV8VpN+cMbJLPi1ndF9Xot/J+ixFKckWio xVxUnAgAs5A+5C0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative values in case of error. Its result should be then tested for such case. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c index a680a97..fe1fd1a 100644 --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c @@ -834,7 +834,7 @@ void ath9k_htc_ani_work(struct work_struct *work) if (longcal || shortcal) common->ani.caldone = ath9k_hw_calibrate(ah, ah->curchan, - ah->rxchainmask, longcal); + ah->rxchainmask, longcal) > 0; ath9k_htc_ps_restore(priv); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Date: Mon, 14 Dec 2015 11:06:01 +0100 Subject: [ath9k-devel] [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate In-Reply-To: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> Message-ID: <1450087564-28441-4-git-send-email-a.hajda@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org The function can return negative values in case of error. Its result should be then tested for such case. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c index a680a97..fe1fd1a 100644 --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c @@ -834,7 +834,7 @@ void ath9k_htc_ani_work(struct work_struct *work) if (longcal || shortcal) common->ani.caldone = ath9k_hw_calibrate(ah, ah->curchan, - ah->rxchainmask, longcal); + ah->rxchainmask, longcal) > 0; ath9k_htc_ps_restore(priv); } -- 1.9.1