All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org,
	Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PATCH 0/1] Fixup for DASD geometry detection
Date: Mon, 14 Dec 2015 16:41:18 +0100	[thread overview]
Message-ID: <1450107679-34555-1-git-send-email-borntraeger@de.ibm.com> (raw)

Kevin,

here is a fixup for the geometry detection. We tried to be overly
clever and calculate the cyclinder size for devices > 64k cyls. Now
this is wrong for the cyls parameter as the interface only has
16bit. Large DASD devices have a special token (0xfffe) that 
indicate to the DASD related code, that you have to calculate
the cyls size yourself.

Without this patch QEMU cannot pass through bigger DASD disks
and complains "cyls must be between 1 and 65535"


Christian Borntraeger (1):
  block/raw-posix: avoid bogus fixup for cylinders on DASD disks

 block/raw-posix.c | 7 -------
 1 file changed, 7 deletions(-)

-- 
2.3.0

             reply	other threads:[~2015-12-14 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 15:41 Christian Borntraeger [this message]
2015-12-14 15:41 ` [Qemu-devel] [PATCH 1/1] block/raw-posix: avoid bogus fixup for cylinders on DASD disks Christian Borntraeger
2015-12-14 17:42   ` Markus Armbruster
2015-12-14 17:49   ` Cornelia Huck
2016-01-07  9:23     ` Christian Borntraeger
2016-01-12 14:25 ` [Qemu-devel] [PATCH 0/1] Fixup for DASD geometry detection Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450107679-34555-1-git-send-email-borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tumanova@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.