From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932891AbbLNWee (ORCPT ); Mon, 14 Dec 2015 17:34:34 -0500 Received: from mail-bl2on0101.outbound.protection.outlook.com ([65.55.169.101]:43093 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932603AbbLNWeb (ORCPT ); Mon, 14 Dec 2015 17:34:31 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1450131605.15946.396.camel@freescale.com> Subject: Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection From: Scott Wood To: SF Markus Elfring , "Benjamin Herrenschmidt" , Michael Ellerman , Paul Mackerras , CC: LKML , , Julia Lawall Date: Mon, 14 Dec 2015 16:20:05 -0600 In-Reply-To: <566F3E49.2010506@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <566F3E49.2010506@users.sourceforge.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:80ce:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR13CA0064.namprd13.prod.outlook.com (25.160.82.35) To BY1PR03MB1483.namprd03.prod.outlook.com (25.162.210.141) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;2:8vau+w/+DE1PCG/t9JwuJfgvFhqKigjZtRVdp0LN3IQJgZwbCgQtoBOEmAvqY1Rmndx6ihnPTv0tcEywt/aau1f8AyhgYkAjyrXMQvzJ999abmZvYjSDrqpSkqcBNYuf/0t8RF9XVN/r+Kff5JNdzg==;3:/Fl1P0wIihHeaenuAeDc/E2lyQOT16p9n+acC1gP4kPxJdbSZhisNLSYFVLeraDK686efvVa8oKNS5bzio1rhXSckY2FnC/s7qDDIJPf/kc6VS4gtYJ9EMWfjyOu53kY;25:iHLejfb+ypoz+jotDaJgxwvuqJigGk4mbQO8O2SjfO7YD0bfXd7ptYD9hWA68DgLtXVr/xFcrBkGw++BLihPe2nDPvSvz7cR4G6G3QKAdmqQDHihhLPSvZQrGOveOzfFoEmDAnHI7QPJnZ5bKGAORqJJRr0nOVNZ1Nmt4YamEOUt1aEdBBdfH7OumzwXVrlB8J0OGYRWrRrM8Lz9I5IR4BFFGygNB6FK/wdqt2c6StpH7ImD68r3/BIrmyxI7v7vuMqXwuYM+gdMv6rhTUzCEQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1483; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;20:hwLhpodo1fEureoBtQvM/QTBHsiRz+8bIy8Cd8OzwCF30QSgPtAWHAM0NqUyh3lP+Q4LkESPm4Ykf+z9aeHV35mawL1rU+3GVX76iL3WCuS3aCB4DitUNZWZzjc7pJWZnj+px+dPhywJq6IJuiLzSq7mW/yvNtoliNV36DDYbUY/SeJcRvnaib6aJvOm+wbIC0Cc133TJQyXkrZG27L5qUXXEPvqZCb9m5eT+d0IKr+o9JhcVfU4BaYOStdF0Mg5Tuha4PiLkG5jaOlD++z7Ahmqw64k+4MN4rAMy0zAKJig5AZixng7B50LP96+gv7LChl/m1CepEyD3Iz9hJMNvOnYSYs8NpfOz41X/xKmkbs/qnbdCocXx3BcOSGfQKuaz529GCjSsMT85ejcgLae8PH3r0PK8ebC5rDQ7Nrby0mHkq36f6pF/XgjQnryuHlXvndGqNRUai8b9h3/SF/jKdueMRrck6S3zj/SB9y4n6RiTQPFIrevYCS2r1JMv39m;4:xT8tD4dsgALSBnqntdMUGDdV06lqFNByxlHQTHV/B+Wgbr3Em8Ew2oep0m9aoGLemgVvQcSrp+pqbvUigDvtFuEcMpancPrc+TVGRXzrY64iTuv+1LhP6NOtsrTwm6NEOrTrVCn1fMj6rLgUC4NYcob1KtRdXDxPRQ30hjrBeWle73U3xtvjCpxUxhPCZoyXA+XDKto1FdXwTtIo4dkQzTlpU5eTKAKA4Kz+yDZi6p4GWFfnJmJxKE1vQVJ1y5zfQ4VVgL93v9reZm1HAPIdQMr4Izipu8QsEthg9sZK4cpI+7MnD84Lkbk0zoHe58NztcA+K5HE64R2yF1caXD5XiqzDSS8J29vaT+x6sHFjoF4gGU0N4Cc3E+Ow9wUxAph X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046);SRVR:BY1PR03MB1483;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1483; X-Forefront-PRVS: 0790FB1F33 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(377424004)(24454002)(189002)(86362001)(103116003)(5008740100001)(6116002)(2950100001)(92566002)(40100003)(5820100001)(33646002)(5001960100002)(47776003)(586003)(230700001)(50986999)(77096005)(87976001)(23676002)(76176999)(101416001)(122386002)(36756003)(50466002)(4001150100001)(19580395003)(5001770100001)(19580405001)(106356001)(1096002)(1706002)(97736004)(81156007)(189998001)(105586002)(42186005)(50226001)(5004730100002)(99106002)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1483;H:[IPv6:2601:448:8100:80ce:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgzOzIzOmtuT1hlL2dURng2WXpCRWhFSi9LQXV1N1ZE?= =?utf-8?B?d2M1TGVCVTZMeDVGTTk2V1M4aUNEUC9uSVZybGZqZjN2TVppemJLNGJJV0p5?= =?utf-8?B?WkFIdG1EOFZjbENjZHdOSnhkUElwSm1uQkhKeTdhNDNtYld4dnY3RTJ0R040?= =?utf-8?B?NEZCY1IwK21QT3ZZcEhPcXhpQjZ6MVJOVVNhblFvNkpKMTRQTFhyY3JjcTF6?= =?utf-8?B?eFV0VytqaStGNXdIUEFGUEJmajJLQkttOEcreXQyU0xpOHhGRlRJV2JBOExn?= =?utf-8?B?bk5rYVgyTEoyaXFpbFpyTVZkMCtMc1B4dmpVSCtNOTBqNGpPRFEzaDZtREhP?= =?utf-8?B?Qm14M2p4NzZjdjVERHRWN21UUXZ6UFc2dkk0akhISU8xVVhUS1hSNi9RRlh0?= =?utf-8?B?V1QwRHUxVFVBeVNxQ2MrTFQ4T3hQdmY5MVZBVzBUdkllKytuMkdUakE1VnBr?= =?utf-8?B?THhuakdaZW83TDdWUDVQV1o3OENPVEtrRi9JdEgvZnJZM1RCVDF6c2N5V0hn?= =?utf-8?B?RGdjS1BqZUNSazBNbUR4RFNNbndrNCtyM0tjS0JWelRWQ0pua3Y1N2p5S21y?= =?utf-8?B?WXZHY0NOZUFzekd0dUpsY21LN3lmUXpyMjZUOGlmVzB4SVNNazc5ZllHMDFB?= =?utf-8?B?LzN5VjlnSUNlTCtmeWk3WkpGQ2FpUG9HU09JaEJvLytaODdLTmhldDRYUkJ5?= =?utf-8?B?SjhyU1UvN254MFhhckh4bmdFekJ6cnFoTFZXYmJWeXJoeWJmUU93STNXV2Rr?= =?utf-8?B?NUt4aUpMeWFJRUlzY0lQcTJBMDlsa2hrZ2dWeDQzWjlxVVlFckdVNXJHc25K?= =?utf-8?B?ay9pSVdSMWtxd01DLzhQU3JxMEhxVXJUSE1KcHE2M3c0UUJkWHptQlQwRnFn?= =?utf-8?B?ZXgxVUgxRXdJcis2NTVmaDRmY3ZIbW1VMjdhWXdFcWM5NjRLb1BOVGoxN1By?= =?utf-8?B?UEhUQmNETXcvcFJtSW01blNqWml5amU2UGphd1J5U3hQbkJpdi9WMG9BbU9J?= =?utf-8?B?MWpKVzlhMjFsOWpSczdTTGxYUnZNckJRazd6MHVvdWU5YjhSdW4xdjc1M0RT?= =?utf-8?B?S0FuZVFQdGw1RjBMcVgwQitWY29JV0dXYXVienBZR2lNUXFpdVBSdHNxRzJa?= =?utf-8?B?WC9DT2ZhZnpWRlppWkN5OFMySkhoRWJjMTlUNURPOGYwTVpKZUs2TmRqQUlI?= =?utf-8?B?SjZhSDcyVG9PcGErSGI0bXJPSk1EMWdFenE0eWp0cGZ4U2RSTmgwWkZXdk9D?= =?utf-8?B?SWJNT0ZtNWxZTXpnUkdjSjQ1OEt2bDFRZ0ppaHRuU01vRld6RzNmdmFtUHQ1?= =?utf-8?B?dXVNbVh2VFYzd1VoNFE4akxjc0F1ZkxIUitqYWk0ZXNlbFpjK2dzcWg4TzMr?= =?utf-8?B?U1E4anFKV3IvK2lhd0xqMWNabTM3S0RvUG1CVTFCeVZ5aWErTHdPOXFQaCs1?= =?utf-8?B?dkhaUjRmV2ZVMHkxMkxRaGNKUVZ0dkFnWGM4MkhMMXZXcjd6Y3pHN1ZianNL?= =?utf-8?Q?DYHeplHkLfSieyMV5NUrm0/EiQGxA2OuUvy+vWXfA9ejIg?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;5:5uXT8fun0LdTPcQTukfO81aXG3HW5jELq+PRWdqu0daCk/2Zkwqpew3jf5cjSP7n+e4OKaKHHZm2xL6ykfTQdHh7NYSyF+V+S+qXQ7BicEmWYKfik2gKRIyOrYdXsl/ZElYePzu1/QqtkqckQ/nKFg==;24:Xh31TadvjB5KuSCuernoVuwJ+vxSEQuxw0jD/Cxq29qWKQrIJ1TqLSxdryLeJEQm6mbOj5h96XO3SJosOxFg8FYzUKKrw+M2ryxWw+6lcz4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2015 22:20:23.5926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1483 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-12-14 at 23:10 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 14 Dec 2015 23:01:32 +0100 > > A status check was performed by the fsl_get_immr() function even if it > was known already that a system setting did not fit to the expectations. > > This implementation detail could be improved by an adjustment for > a jump label according to the Linux coding style convention. What is the actual problem you're trying to solve? Cluttering the code to micro-optimize an error path is not an improvement. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 14 Dec 2015 22:20:05 +0000 Subject: Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection Message-Id: <1450131605.15946.396.camel@freescale.com> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <566F3E49.2010506@users.sourceforge.net> In-Reply-To: <566F3E49.2010506@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Mon, 2015-12-14 at 23:10 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 14 Dec 2015 23:01:32 +0100 > > A status check was performed by the fsl_get_immr() function even if it > was known already that a system setting did not fit to the expectations. > > This implementation detail could be improved by an adjustment for > a jump label according to the Linux coding style convention. What is the actual problem you're trying to solve? Cluttering the code to micro-optimize an error path is not an improvement. -Scott