From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8kuu-0003wf-Ed for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:25:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8kut-00013y-75 for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:25:04 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:30306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8kus-00012C-AZ for qemu-devel@nongnu.org; Tue, 15 Dec 2015 03:25:03 -0500 From: zhanghailiang Date: Tue, 15 Dec 2015 16:22:55 +0800 Message-ID: <1450167779-9960-35-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1450167779-9960-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1450167779-9960-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH COLO-Frame v12 34/38] filter-buffer: Accept zero interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Jason Wang , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, zhanghailiang , arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, hongyang.yang@easystack.cn For default buffer filter, its 'interval' value is zero, so here we should accept zero interval. Signed-off-by: zhanghailiang Reviewed-by: Yang Hongyang Cc: Jason Wang --- v12: - Add Reviewed-by tag v11: - Add comment v10: - new patch Signed-off-by: zhanghailiang --- net/filter-buffer.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/net/filter-buffer.c b/net/filter-buffer.c index 9cf3544..8abac94 100644 --- a/net/filter-buffer.c +++ b/net/filter-buffer.c @@ -111,16 +111,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error **errp) FilterBufferState *s = FILTER_BUFFER(nf); char *path = object_get_canonical_path_component(OBJECT(nf)); - /* - * We may want to accept zero interval when VM FT solutions like MC - * or COLO use this filter to release packets on demand. - */ - if (!s->interval) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval", - "a non-zero interval"); - return; - } - s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf); nf->is_default = !strcmp(path, "nop"); /* -- 1.8.3.1