All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/11] tty: serial: 8250: Fix checkpatch warnings
@ 2015-12-16 15:36 ` Anton Wuerfel
  0 siblings, 0 replies; 60+ messages in thread
From: Anton Wuerfel @ 2015-12-16 15:36 UTC (permalink / raw)
  To: linux-serial
  Cc: Greg Kroah-Hartman, Jiri Slaby, James E.J. Bottomley,
	Helge Deller, Peter Hurley, Heikki Krogerus, Andy Shevchenko,
	Qipeng Zha, Desmond Liu, Wang Long, Matt Redfearn, Paul Burton,
	Ralf Baechle, Krzysztof Kozlowski, Peter Hung, Soeren Grunewald,
	Adam Lee, Maciej S. Szmigiero, Mans Rullgard, linux-kernel,
	linux-parisc, linux-kernel, Anton Wuerfel

This patch set fixes several checkpatch warnings in tty/serial/8250.

Patch 1/11:  Adds missing spaces (mainly to function/macro headers)
Patch 2/11:  Fixes code indentation
Patch 3/11:  Slight patch which moves an opening curly brace
Patch 4/11:  Fixes multiline comment style
Patch 5/11:  Removes else blocks after return statements
Patch 6/11:  Slight patch which moves EXPORT_SYMBOL macro to correct position
Patch 7/11:  Slight patch which removes an unneccessary line continuation
Patch 8/11:  Slight patch which adds parentheses to a macro definition
Patch 9/11:  Merges user-visible multiline strings to a single line
Patch 10/11: Replaces printk by corresponding variant of pr_*
Patch 11/11: Removes code which has been commented out

Remaining checkpatch warnings after applying this patch series:

-line over 80 characters
	This error mostly occurs in serial_cs.c, which contains long-lined
	macro calls. However, splitting these calls into multiple lines would
	not increase readability.

-externs should be avoided in .c files
	This occurs in 8250_hp300.c. There is no corresponding header file
	the extern statement could be moved to. It could be moved to 8250.h
	but this would affect other .c files.

-Use #include <linux/*.h> instead of <asm/*.h>
	This warning has been left open for more experienced kernel hackers.
	This patch series is about style issues. We do not intend to alter
	the code behavior.

-struct uart_ops should normally be const
	This warning only occurs in 8250_core.c. The corresponding struct
	cannot be declared as const because it is altered in
	serial8250_isa_init_ports(). Maybe a checkpatch exception should
	be added for this particular warning.

-quoted string split across lines
	These strings were ignored because they otherwise would exceed
	80 characters in a single line. These particular strings use
	format specifiers, which break the ability to grep for them anyway.

Anton Wuerfel (11):
Phillip Raffeck (11):
  tty: serial: 8250: Fix whitespace errors
  tty: serial: 8250: Fix indentation warnings
  tty: serial: 8250: Fix braces after struct
  tty: serial: 8250: Fix multiline comment style
  tty: serial: 8250: Remove else after return
  tty: serial: 8250: Move EXPORT_SYMBOL to function
  tty: serial: 8250: Fix line continuation warning
  tty: serial: 8250: Add parentheses to macro
  tty: serial: 8250: Fix multi-line strings
  tty: serial: 8250: Replace printk by pr_*
  tty: serial: 8250: Delete commented code

 drivers/tty/serial/8250/8250_accent.c        |   2 +-
 drivers/tty/serial/8250/8250_acorn.c         |   2 +-
 drivers/tty/serial/8250/8250_boca.c          |   2 +-
 drivers/tty/serial/8250/8250_core.c          |  16 ++-
 drivers/tty/serial/8250/8250_dw.c            |   6 ++
 drivers/tty/serial/8250/8250_exar_st16c554.c |   2 +-
 drivers/tty/serial/8250/8250_fourport.c      |   2 +-
 drivers/tty/serial/8250/8250_gsc.c           |   6 +-
 drivers/tty/serial/8250/8250_hp300.c         |  22 ++--
 drivers/tty/serial/8250/8250_hub6.c          |   2 +-
 drivers/tty/serial/8250/8250_ingenic.c       |   6 +-
 drivers/tty/serial/8250/8250_pci.c           |  60 +++++------
 drivers/tty/serial/8250/8250_pnp.c           |  16 +--
 drivers/tty/serial/8250/8250_port.c          |  49 +++++----
 drivers/tty/serial/8250/serial_cs.c          | 153 ++++++++++++++-------------
 15 files changed, 181 insertions(+), 165 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 60+ messages in thread

end of thread, other threads:[~2015-12-18 12:37 UTC | newest]

Thread overview: 60+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-16 15:36 [PATCH 00/11] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 01/11] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:43   ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 02/11] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:49   ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 03/11] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 04/11] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:52   ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 05/11] tty: serial: 8250: Remove else after return Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:06   ` Peter Hurley
2015-12-16 17:06     ` Peter Hurley
2015-12-16 17:06     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 07/11] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-17 15:16   ` Andy Shevchenko
2015-12-17 15:16     ` Andy Shevchenko
2015-12-18 11:36     ` anton.wuerfel
2015-12-18 11:36       ` anton.wuerfel
2015-12-18 12:35       ` Andy Shevchenko
2015-12-18 12:35         ` Andy Shevchenko
2015-12-16 15:36 ` [PATCH 09/11] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 10/11] tty: serial: 8250: Replace printk by pr_* Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:00   ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 11/11] tty: serial: 8250: Delete commented code Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:05   ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.