From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Date: Thu, 17 Dec 2015 17:16:41 +0200 Message-ID: <1450365401.30729.142.camel@linux.intel.com> References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de> <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Peter Hurley , Heikki Krogerus , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck To: Anton Wuerfel , linux-serial@vger.kernel.org Return-path: In-Reply-To: <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de> List-ID: List-Id: linux-parisc.vger.kernel.org On Wed, 2015-12-16 at 16:36 +0100, Anton Wuerfel wrote: > This patch fixes a checkpatch warning caused by missing parentheses > in the definition of a macro. >=20 > Signed-off-by: Anton W=C3=BCrfel > Signed-off-by: Phillip Raffeck > CC: linux-kernel@i4.cs.fau.de > --- > =C2=A0drivers/tty/serial/8250/8250_core.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 67147b2..3c29530 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void) > =C2=A0} > =C2=A0console_initcall(univ8250_console_init); > =C2=A0 > -#define SERIAL8250_CONSOLE &univ8250_console > +#define SERIAL8250_CONSOLE (&univ8250_console) What about the rest of the drivers under drivers/tty/serial? What do you propose to do with, for example, the following drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define CPM_UART_CONSOLE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&cpm_scc_uart= _console drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define CPM_UART_CONSOLE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0NULL > =C2=A0#else > =C2=A0#define SERIAL8250_CONSOLE NULL > =C2=A0#endif --=20 Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967025AbbLQPTG (ORCPT ); Thu, 17 Dec 2015 10:19:06 -0500 Received: from mga02.intel.com ([134.134.136.20]:30249 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbbLQPTD (ORCPT ); Thu, 17 Dec 2015 10:19:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,441,1444719600"; d="scan'208";a="873562381" Message-ID: <1450365401.30729.142.camel@linux.intel.com> Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro From: Andy Shevchenko To: Anton Wuerfel , linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Peter Hurley , Heikki Krogerus , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck Date: Thu, 17 Dec 2015 17:16:41 +0200 In-Reply-To: <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de> References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de> <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-12-16 at 16:36 +0100, Anton Wuerfel wrote: > This patch fixes a checkpatch warning caused by missing parentheses > in the definition of a macro. > > Signed-off-by: Anton Würfel > Signed-off-by: Phillip Raffeck > CC: linux-kernel@i4.cs.fau.de > --- >  drivers/tty/serial/8250/8250_core.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 67147b2..3c29530 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void) >  } >  console_initcall(univ8250_console_init); >   > -#define SERIAL8250_CONSOLE &univ8250_console > +#define SERIAL8250_CONSOLE (&univ8250_console) What about the rest of the drivers under drivers/tty/serial? What do you propose to do with, for example, the following drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define CPM_UART_CONSOLE       &cpm_scc_uart_console drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define CPM_UART_CONSOLE       NULL >  #else >  #define SERIAL8250_CONSOLE NULL >  #endif -- Andy Shevchenko Intel Finland Oy