All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Hurley <peter@hurleysoftware.com>,
	Josh Triplett <josh@joshtriplett.org>,
	David Howells <dhowells@redhat.com>
Subject: [PATCH 7/8] fs: make devpts/inode.c explicitly non-modular
Date: Thu, 17 Dec 2015 14:11:05 -0500	[thread overview]
Message-ID: <1450379466-23115-8-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1450379466-23115-1-git-send-email-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

config UNIX98_PTYS
    bool "Unix98 PTY support" if EXPERT

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading the
driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering gets bumped to one level earlier when we
use the more appropriate fs_initcall here.  However we've made similar
changes before without any fallout and none is expected here either.

Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Hurley <peter@hurleysoftware.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 fs/devpts/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index c35ffdc12bba..3c89b1f0804f 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -12,7 +12,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/fs.h>
 #include <linux/sched.h>
@@ -703,4 +702,4 @@ static int __init init_devpts_fs(void)
 	}
 	return err;
 }
-module_init(init_devpts_fs)
+fs_initcall(init_devpts_fs)
-- 
2.6.1


  parent reply	other threads:[~2015-12-17 19:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 19:10 [PATCH v2 0/8] fs: don't use module helpers in non-modular code Paul Gortmaker
2015-12-17 19:10 ` Paul Gortmaker
2015-12-17 19:10 ` Paul Gortmaker
2015-12-17 19:10 ` [PATCH 1/8] hugetlb: make mm and fs code explicitly non-modular Paul Gortmaker
2015-12-17 19:10   ` Paul Gortmaker
2015-12-17 19:10   ` Paul Gortmaker
2015-12-17 22:45   ` Mike Kravetz
2015-12-17 22:45     ` Mike Kravetz
2015-12-18  2:46   ` Davidlohr Bueso
2015-12-18  2:46     ` Davidlohr Bueso
2015-12-17 19:11 ` [PATCH 2/8] fs: make notify dnotify.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 3/8] fs: make fcntl.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 4/8] fs: make filesystems.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 5/8] fs: make locks.c " Paul Gortmaker
2015-12-18 12:07   ` Jeff Layton
2015-12-17 19:11 ` [PATCH 6/8] fs: make direct-io.c " Paul Gortmaker
2015-12-17 19:11 ` Paul Gortmaker [this message]
2015-12-17 19:46   ` [PATCH 7/8] fs: make devpts/inode.c " Peter Hurley
2015-12-20  2:52     ` Paul Gortmaker
2015-12-17 19:11 ` [PATCH 8/8] fs: make binfmt_elf.c " Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450379466-23115-8-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.