From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shevchenko, Andriy" Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* Date: Fri, 18 Dec 2015 12:42:08 +0000 Message-ID: <1450442546.30729.217.camel@intel.com> References: <1450437723-2978-1-git-send-email-anton.wuerfel@fau.de> <1450437723-2978-11-git-send-email-anton.wuerfel@fau.de> <1450441926.30729.208.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Cc: "linux-kernel@vger.kernel.org" , "mail@maciej.szmigiero.name" , "desmondl@broadcom.com" , "Zha, Qipeng" , "heikki.krogerus@linux.intel.com" , "long.wanglong@huawei.com" , "soeren.grunewald@desy.de" , "deller@gmx.de" , "jslaby@suse.com" , "phillip.raffeck@fau.de" , "paul.burton@imgtec.com" , "hpeter@gmail.com" , "ralf@linux-mips.org" , "linux-kernel@i4.cs.fau.de" , "mans@mansr.com" , "adam.lee@canonical.com" , "gregkh@linuxfoundation.org" , "jejb@parisc-linux.org" , "anton.wuerfel@fau.de" Return-path: In-Reply-To: <1450441926.30729.208.camel@linux.intel.com> List-ID: List-Id: linux-parisc.vger.kernel.org T24gRnJpLCAyMDE1LTEyLTE4IGF0IDE0OjMyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 DQo+IE9uIEZyaSwgMjAxNS0xMi0xOCBhdCAxMjoyMiArMDEwMCwgQW50b24gV3VlcmZlbCB3cm90 ZToNCj4gDQo+IA0KPiA+IMKgVGhpcyBjb21lcyB3aXRoIGEgc2xpZ2h0IGNoYW5nZSBpbiBiZWhh dmlvdXIgYXMNCj4gPiBwcl9kZWJ1ZyBpcyBjb25maWd1cmFibGUgdmlhIENPTkZJR19EWU5BTUlD X0RFQlVHLCB3aGVyZWFzDQo+ID4gcHJpbnRrKEtFUk5fREVCVUcgLi4uKSBpcyBub3QuDQo+IA0K PiAtLS0gYS9kcml2ZXJzL3R0eS9zZXJpYWwvODI1MC84MjUwX3BucC5jDQo+ID4gKysrIGIvZHJp dmVycy90dHkvc2VyaWFsLzgyNTAvODI1MF9wbnAuYw0KPiA+IEBAIC00NjUsOSArNDY1LDkgQEAg c2VyaWFsX3BucF9wcm9iZShzdHJ1Y3QgcG5wX2RldiAqZGV2LCBjb25zdA0KPiA+IHN0cnVjdCBw bnBfZGV2aWNlX2lkICpkZXZfaWQpDQoNCk9uZSBtb3JlIHRoaW5nIGp1c3Qgbm90aWNlZCB0aGF0 IGlzIC0+cHJvYmUoKSBmdW5jdGlvbiB3aGVyZSB5b3UgaGF2ZQ0Kc3RydWN0IGRldmljZSBkZWZp bmVkLCBpdCBtaWdodCBiZSB3b3J0aCB0byBjaGFuZ2UgdG8gZGV2XyogbWFjcm9zDQppbnN0ZWFk IG9mIHByXyBhdCB0aGUgc2FtZSB0aW1lIGZvciBzb21lIGZ1bmN0aW9ucy4NCg0KU28sIGhlcmUg aXQgd291bGQgYmUgZGV2X2RiZygmZGV2LT5kZXYsIOKApikgSSBzdXBwb3NlLg0KDQoNCi0tIA0K QW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+DQpJbnRlbCBGaW5s YW5kIE95DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KSW50ZWwgRmlubGFuZCBPeQpSZWdpc3RlcmVkIEFkZHJlc3M6 IFBMIDI4MSwgMDAxODEgSGVsc2lua2kgCkJ1c2luZXNzIElkZW50aXR5IENvZGU6IDAzNTc2MDYg LSA0IApEb21pY2lsZWQgaW4gSGVsc2lua2kgCgpUaGlzIGUtbWFpbCBhbmQgYW55IGF0dGFjaG1l bnRzIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBtYXRlcmlhbCBmb3IKdGhlIHNvbGUgdXNlIG9m IHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSByZXZpZXcgb3IgZGlzdHJpYnV0aW9uCmJ5 IG90aGVycyBpcyBzdHJpY3RseSBwcm9oaWJpdGVkLiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5k ZWQKcmVjaXBpZW50LCBwbGVhc2UgY29udGFjdCB0aGUgc2VuZGVyIGFuZCBkZWxldGUgYWxsIGNv cGllcy4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753603AbbLRMnL (ORCPT ); Fri, 18 Dec 2015 07:43:11 -0500 Received: from mga01.intel.com ([192.55.52.88]:39305 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbLRMmR (ORCPT ); Fri, 18 Dec 2015 07:42:17 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,446,1444719600"; d="scan'208";a="874242301" From: "Shevchenko, Andriy" To: "linux-serial@vger.kernel.org" , "anton.wuerfel@fau.de" CC: "linux-kernel@vger.kernel.org" , "mail@maciej.szmigiero.name" , "desmondl@broadcom.com" , "Zha, Qipeng" , "heikki.krogerus@linux.intel.com" , "long.wanglong@huawei.com" , "soeren.grunewald@desy.de" , "deller@gmx.de" , "jslaby@suse.com" , "phillip.raffeck@fau.de" , "paul.burton@imgtec.com" , "hpeter@gmail.com" , "ralf@linux-mips.org" , "linux-kernel@i4.cs.fau.de" , "mans@mansr.com" , "adam.lee@canonical.com" , "gregkh@linuxfoundation.org" , "jejb@parisc-linux.org" , "linux-parisc@vger.kernel.org" , "peter@hurleysoftware.com" , "matt.redfearn@imgtec.com" , "k.kozlowski@samsung.com" Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* Thread-Topic: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* Thread-Index: AQHROZGB7tPg0Lhq+Eyrt5YMBeNBsg== Date: Fri, 18 Dec 2015 12:42:08 +0000 Message-ID: <1450442546.30729.217.camel@intel.com> References: <1450437723-2978-1-git-send-email-anton.wuerfel@fau.de> <1450437723-2978-11-git-send-email-anton.wuerfel@fau.de> <1450441926.30729.208.camel@linux.intel.com> In-Reply-To: <1450441926.30729.208.camel@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.86] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tBIChF5D024018 On Fri, 2015-12-18 at 14:32 +0200, Andy Shevchenko wrote: > On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: > > > >  This comes with a slight change in behaviour as > > pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas > > printk(KERN_DEBUG ...) is not. > > --- a/drivers/tty/serial/8250/8250_pnp.c > > +++ b/drivers/tty/serial/8250/8250_pnp.c > > @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const > > struct pnp_device_id *dev_id) One more thing just noticed that is ->probe() function where you have struct device defined, it might be worth to change to dev_* macros instead of pr_ at the same time for some functions. So, here it would be dev_dbg(&dev->dev, …) I suppose. -- Andy Shevchenko Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shevchenko, Andriy" Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* Date: Fri, 18 Dec 2015 12:42:08 +0000 Message-ID: <1450442546.30729.217.camel@intel.com> References: <1450437723-2978-1-git-send-email-anton.wuerfel@fau.de> <1450437723-2978-11-git-send-email-anton.wuerfel@fau.de> <1450441926.30729.208.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1450441926.30729.208.camel@linux.intel.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: "linux-serial@vger.kernel.org" , "anton.wuerfel@fau.de" Cc: "linux-kernel@vger.kernel.org" , "mail@maciej.szmigiero.name" , "desmondl@broadcom.com" , "Zha, Qipeng" , "heikki.krogerus@linux.intel.com" , "long.wanglong@huawei.com" , "soeren.grunewald@desy.de" , "deller@gmx.de" , "jslaby@suse.com" , "phillip.raffeck@fau.de" , "paul.burton@imgtec.com" , "hpeter@gmail.com" , "ralf@linux-mips.org" , "linux-kernel@i4.cs.fau.de" , "mans@mansr.com" , "adam.lee@canonical.com" , "gregkh@linuxfoundation.org" , "jejb@parisc-linux.org" List-Id: linux-serial@vger.kernel.org T24gRnJpLCAyMDE1LTEyLTE4IGF0IDE0OjMyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 DQo+IE9uIEZyaSwgMjAxNS0xMi0xOCBhdCAxMjoyMiArMDEwMCwgQW50b24gV3VlcmZlbCB3cm90 ZToNCj4gDQo+IA0KPiA+IMKgVGhpcyBjb21lcyB3aXRoIGEgc2xpZ2h0IGNoYW5nZSBpbiBiZWhh dmlvdXIgYXMNCj4gPiBwcl9kZWJ1ZyBpcyBjb25maWd1cmFibGUgdmlhIENPTkZJR19EWU5BTUlD X0RFQlVHLCB3aGVyZWFzDQo+ID4gcHJpbnRrKEtFUk5fREVCVUcgLi4uKSBpcyBub3QuDQo+IA0K PiAtLS0gYS9kcml2ZXJzL3R0eS9zZXJpYWwvODI1MC84MjUwX3BucC5jDQo+ID4gKysrIGIvZHJp dmVycy90dHkvc2VyaWFsLzgyNTAvODI1MF9wbnAuYw0KPiA+IEBAIC00NjUsOSArNDY1LDkgQEAg c2VyaWFsX3BucF9wcm9iZShzdHJ1Y3QgcG5wX2RldiAqZGV2LCBjb25zdA0KPiA+IHN0cnVjdCBw bnBfZGV2aWNlX2lkICpkZXZfaWQpDQoNCk9uZSBtb3JlIHRoaW5nIGp1c3Qgbm90aWNlZCB0aGF0 IGlzIC0+cHJvYmUoKSBmdW5jdGlvbiB3aGVyZSB5b3UgaGF2ZQ0Kc3RydWN0IGRldmljZSBkZWZp bmVkLCBpdCBtaWdodCBiZSB3b3J0aCB0byBjaGFuZ2UgdG8gZGV2XyogbWFjcm9zDQppbnN0ZWFk IG9mIHByXyBhdCB0aGUgc2FtZSB0aW1lIGZvciBzb21lIGZ1bmN0aW9ucy4NCg0KU28sIGhlcmUg aXQgd291bGQgYmUgZGV2X2RiZygmZGV2LT5kZXYsIOKApikgSSBzdXBwb3NlLg0KDQoNCi0tIA0K QW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+DQpJbnRlbCBGaW5s YW5kIE95DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KSW50ZWwgRmlubGFuZCBPeQpSZWdpc3RlcmVkIEFkZHJlc3M6 IFBMIDI4MSwgMDAxODEgSGVsc2lua2kgCkJ1c2luZXNzIElkZW50aXR5IENvZGU6IDAzNTc2MDYg LSA0IApEb21pY2lsZWQgaW4gSGVsc2lua2kgCgpUaGlzIGUtbWFpbCBhbmQgYW55IGF0dGFjaG1l bnRzIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBtYXRlcmlhbCBmb3IKdGhlIHNvbGUgdXNlIG9m IHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSByZXZpZXcgb3IgZGlzdHJpYnV0aW9uCmJ5 IG90aGVycyBpcyBzdHJpY3RseSBwcm9oaWJpdGVkLiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5k ZWQKcmVjaXBpZW50LCBwbGVhc2UgY29udGFjdCB0aGUgc2VuZGVyIGFuZCBkZWxldGUgYWxsIGNv cGllcy4K