From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9wdi-0000Nl-Oj for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:08:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9wdc-0004IC-KG for qemu-devel@nongnu.org; Fri, 18 Dec 2015 10:08:14 -0500 From: Kevin Wolf Date: Fri, 18 Dec 2015 16:07:09 +0100 Message-Id: <1450451274-7472-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1450451274-7472-1-git-send-email-kwolf@redhat.com> References: <1450451274-7472-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 03/48] iotests: 124: don't reopen qcow2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: John Snow Don't create two interfaces to the same drive in the recently moved failure test. Signed-off-by: John Snow Signed-off-by: Kevin Wolf --- tests/qemu-iotests/124 | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124 index 2a0119d..7d33422 100644 --- a/tests/qemu-iotests/124 +++ b/tests/qemu-iotests/124 @@ -494,6 +494,12 @@ class TestIncrementalBackup(TestIncrementalBackupBase): class TestIncrementalBackupBlkdebug(TestIncrementalBackupBase): '''Incremental backup tests that utilize a BlkDebug filter on drive0.''' + def setUp(self): + drive0 = self.add_node('drive0') + self.img_create(drive0['file'], drive0['fmt']) + self.write_default_pattern(drive0['file']) + self.vm.launch() + def test_incremental_failure(self): '''Test: Verify backups made after a failure are correct. @@ -502,19 +508,15 @@ class TestIncrementalBackupBlkdebug(TestIncrementalBackupBase): afterwards and verify that the backup created is correct. ''' - # Create a blkdebug interface to this img as 'drive1', - # but don't actually create a new image. - drive1 = self.add_node('drive1', self.drives[0]['fmt'], - path=self.drives[0]['file'], - backup=self.drives[0]['backup']) + drive0 = self.drives[0] result = self.vm.qmp('blockdev-add', options={ - 'id': drive1['id'], - 'driver': drive1['fmt'], + 'id': drive0['id'], + 'driver': drive0['fmt'], 'file': { 'driver': 'blkdebug', 'image': { 'driver': 'file', - 'filename': drive1['file'] + 'filename': drive0['file'] }, 'set-state': [{ 'event': 'flush_to_disk', @@ -532,18 +534,18 @@ class TestIncrementalBackupBlkdebug(TestIncrementalBackupBase): }) self.assert_qmp(result, 'return', {}) - self.create_anchor_backup(self.drives[0]) - self.add_bitmap('bitmap0', drive1) + self.create_anchor_backup(drive0) + self.add_bitmap('bitmap0', drive0) # Note: at this point, during a normal execution, # Assume that the VM resumes and begins issuing IO requests here. - self.hmp_io_writes(drive1['id'], (('0xab', 0, 512), + self.hmp_io_writes(drive0['id'], (('0xab', 0, 512), ('0xfe', '16M', '256k'), ('0x64', '32736k', '64k'))) result = self.create_incremental(validate=False) self.assertFalse(result) - self.hmp_io_writes(drive1['id'], (('0x9a', 0, 512), + self.hmp_io_writes(drive0['id'], (('0x9a', 0, 512), ('0x55', '8M', '352k'), ('0x78', '15872k', '1M'))) self.create_incremental() -- 1.8.3.1