From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932274AbbLTFkO (ORCPT <rfc822;w@1wt.eu>);
	Sun, 20 Dec 2015 00:40:14 -0500
Received: from mail-wm0-f42.google.com ([74.125.82.42]:32810 "EHLO
	mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751233AbbLTFkM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 20 Dec 2015 00:40:12 -0500
Message-ID: <1450590007.3296.6.camel@gmail.com>
Subject: Re: [patch 5/5] futex: Cleanup the goto confusion in requeue_pi()
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Darren Hart <dvhart@infradead.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Darren Hart <darren@dvhart.com>,
        Davidlohr Bueso <dave@stgolabs.net>, Bhuvanesh_Surachari@mentor.com,
        Andy Lowe <Andy_Lowe@mentor.com>
Date: Sun, 20 Dec 2015 06:40:07 +0100
In-Reply-To: <20151220051524.GH7244@malice.jf.intel.com>
References: <20151219200501.563704646@linutronix.de>
	 <20151219200607.526665141@linutronix.de>
	 <20151220051524.GH7244@malice.jf.intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-12-19 at 21:15 -0800, Darren Hart wrote:

> As a follow-on, I think it might be worthwhile to create a symmetrical
> get_pi_state() to the put_pi_state(), rather than handling the atomic_inc
> directly.

Ditto, immediate thought was future auditors will look for it.

	-Mike