From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 04/12] net: add ESP header to generic flow
	steering
Date: Fri, 20 Oct 2017 12:15:48 +0200
Message-ID: <14506788.2xBXIGZ2lq@xps>
References: <20171006181151.4758-1-akhil.goyal@nxp.com>
 <20171014221734.15511-1-akhil.goyal@nxp.com>
 <20171014221734.15511-5-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com,
 hemant.agrawal@nxp.com, radu.nicolau@intel.com, borisp@mellanox.com,
 aviadye@mellanox.com, sandeep.malik@nxp.com, jerin.jacob@caviumnetworks.com,
 john.mcnamara@intel.com, konstantin.ananyev@intel.com, shahafs@mellanox.com,
 olivier.matz@6wind.com
To: Akhil Goyal <akhil.goyal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6D71A1B209
 for <dev@dpdk.org>; Fri, 20 Oct 2017 12:15:50 +0200 (CEST)
In-Reply-To: <20171014221734.15511-5-akhil.goyal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/10/2017 00:17, Akhil Goyal:
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -111,7 +111,8 @@ The public API headers are grouped by topics:
>    [LPM IPv6 route]     (@ref rte_lpm6.h),
>    [ACL]                (@ref rte_acl.h),
>    [EFD]                (@ref rte_efd.h),
> -  [member]             (@ref rte_member.h)
> +  [member]             (@ref rte_member.h),
> +  [ESP]                (@ref rte_esp.h)

rte_member should not be in "layers" section.
I will probably move it to "basic".

Please move ESP near IP, maybe between IP and ICMP.