From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aGRid-0000pl-TM
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 08:32:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aGRiZ-0001YE-Sc
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 08:32:11 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60422)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aGRiZ-0001Xz-NX
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 08:32:07 -0500
Message-ID: <1452000725.6030.7.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 05 Jan 2016 14:32:05 +0100
In-Reply-To: <20160105151711-mutt-send-email-mst@redhat.com>
References: <1451995191-20572-1-git-send-email-kraxel@redhat.com>
	<20160105151711-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] pc: allow raising low memory via
	max-ram-below-4g option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>, Richard Henderson <rth@twiddle.net>

On Di, 2016-01-05 at 15:17 +0200, Michael S. Tsirkin wrote:
> On Tue, Jan 05, 2016 at 12:59:51PM +0100, Gerd Hoffmann wrote:
> > This patch extends the functionality of the max-ram-below-4g option
> > to also allow increasing lowmem.  While being at it also rework the
> > lowmem calculation logic and add a longish comment describing how it
> > works and what the compatibility constrains are.
> >=20
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>=20
> Could you please add info about the motivation for this
> in the commit log?

> > +     *  - Finally max-ram-below-4g got updated to also allow raising l=
owmem,
> > +     *    so legacy non-PAE guests can get as much memory as possible =
in
> > +     *    the 32bit address space below 4G.

It's right here (where it imho is more useful for people looking at the
code).

Want me copy this into the commit message?

cheers,
  Gerd