From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH RFC 03/31] xen/x86: Store antifeatures
 inverted in a featureset
Date: Tue, 5 Jan 2016 14:19:17 +0000
Message-ID: <1452003557.13361.280.camel@citrix.com>
References: <1450301073-28191-1-git-send-email-andrew.cooper3@citrix.com>
	<1450301073-28191-4-git-send-email-andrew.cooper3@citrix.com>
	<5679893002000078000C25CE@prv-mh.provo.novell.com>
	<56798246.5050804@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56798246.5050804@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-12-22 at 17:03 +0000, Andrew Cooper wrote:
> On 22/12/15 16:32, Jan Beulich wrote:
> > > > > On 16.12.15 at 22:24, <andrew.cooper3@citrix.com> wrote:
> > > --- /dev/null
> > > +++ b/xen/arch/x86/cpuid/cpuid-private.h
> > > @@ -0,0 +1,27 @@
> > > +#ifdef __XEN__
> > > +
> > > +#include <asm/cpufeature.h>
> > > +
> > > +#include <xen/lib.h>
> > > +
> > > +#else
> > > +
> > > +# error TODO for userspace
> > I suppose your intentions with this will become apparent in later
> > patches?
> 
> Everything in xen/arch/x86/cpuid/ is shared code between Xen and libxc,
> to avoid having different algorithms/structures between the hypervisor
> and toolstack.

I took the question to be "does a later patch in this series remove the
#error?".

Ian.