From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752256AbcAEPXd (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 10:23:33 -0500
Received: from smtprelay0092.hostedemail.com ([216.40.44.92]:40994 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751601AbcAEPXb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 10:23:31 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4823:5007:6261:7903:10004:10400:10848:11232:11658:11783:11914:12043:12296:12517:12519:12740:13069:13311:13357:13894:14659:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: veil45_3b94e3fb1fc28
X-Filterd-Recvd-Size: 1970
Message-ID: <1452007408.4334.136.camel@perches.com>
Subject: Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions
From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
        "Geyslan G. Bem" <geyslan@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Date: Tue, 05 Jan 2016 07:23:28 -0800
In-Reply-To: <Pine.LNX.4.44L0.1601051010170.1666-100000@iolanthe.rowland.org>
References: <Pine.LNX.4.44L0.1601051010170.1666-100000@iolanthe.rowland.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.3-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> 
> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token)
> > >>       return '/';
> > >>  }
> > >>
> > >> -static void qh_lines(
> > >> -     struct ehci_hcd *ehci,
> > >> -     struct ehci_qh *qh,
> > >> -     char **nextp,
> > >> -     unsigned *sizep
> > >> -)
> > >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh,
> > >> +                     char **nextp, unsigned *sizep)
> > >>  {
> > >>       u32                     scratch;
> > >>       u32                     hw_curr;
> > >>
> > >
> > And about that style? Should be done?
> 
> You mean squeezing the function parameters into two lines?  That's 
> okay.
> 
> However, the style in this file is to indent continuation lines by two
> extra tab stops, not to line things up with an open paren on the first
> line.

It's not consistent.
It's a bit of a mix of 1 and 2 tabs, and some others.