From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"alex.feinman@daqri.com" <alex.feinman@daqri.com>
Subject: Re: [PATCH] drm/i915: Update Skylake DDI translation table for HDMI.
Date: Tue, 5 Jan 2016 18:47:04 +0000 [thread overview]
Message-ID: <1452019626.2858.0.camel@intel.com> (raw)
In-Reply-To: <20160105183906.GP4437@intel.com>
On Tue, 2016-01-05 at 20:39 +0200, Ville Syrjälä wrote:
> On Tue, Jan 05, 2016 at 07:32:59AM -0800, Rodrigo Vivi wrote:
> > When debuging an intermittent corrupted screen I suspected on DDI
> > translation table and checked we are out of date with the spec.
> >
> > I'm not sure this will fix my bug yet, but it is always good to
> > follow
> > the spec.
> >
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index e6408e5..c7e3114 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -225,27 +225,27 @@ static const struct ddi_buf_trans
> > skl_ddi_translations_hdmi[] = {
> > { 0x00007011, 0x00000088, 0x0 },
> > { 0x00000018, 0x000000A1, 0x0 },
> > { 0x00000018, 0x00000098, 0x0 },
> > - { 0x00004013, 0x00000088, 0x0 },
> > - { 0x00006012, 0x00000087, 0x0 },
> > + { 0x00004013, 0x00000088, 0x1 },
> ^^^
>
> 0x0
>
> > + { 0x80006012, 0x000000CD, 0x0 },
> ^^^
> 0x1
Thanks
>
> The rest looks fine.
>
> > { 0x00000018, 0x000000DF, 0x0 },
> > - { 0x00003015, 0x00000087, 0x0 }, /* Default */
> > - { 0x00003015, 0x000000C7, 0x0 },
> > - { 0x00000018, 0x000000C7, 0x0 },
> > + { 0x80003015, 0x000000CD, 0x1 }, /* Default */
> > + { 0x80003015, 0x000000C0, 0x1 },
> > + { 0x80000018, 0x000000C0, 0x1 },
> > };
> >
> > /* Skylake Y */
> > static const struct ddi_buf_trans skl_y_ddi_translations_hdmi[] =
> > {
> > { 0x00000018, 0x000000A1, 0x0 },
> > { 0x00005012, 0x000000DF, 0x0 },
> > - { 0x00007011, 0x00000084, 0x0 },
> > + { 0x80007011, 0x000000CB, 0x3 },
> > { 0x00000018, 0x000000A4, 0x0 },
> > { 0x00000018, 0x0000009D, 0x0 },
> > { 0x00004013, 0x00000080, 0x0 },
> > - { 0x00006013, 0x000000C7, 0x0 },
> > + { 0x80006013, 0x000000C0, 0x3 },
> > { 0x00000018, 0x0000008A, 0x0 },
> > - { 0x00003015, 0x000000C7, 0x0 }, /* Default */
> > - { 0x80003015, 0x000000C7, 0x7 }, /* Uses I_boost
> > level 0x7 */
>
> Since you're removing this pointless "Uses I_boost..." comment,
> maybe remove all such comments as a followup?
good idea. I will...
>
> > - { 0x00000018, 0x000000C7, 0x0 },
> > + { 0x80003015, 0x000000C0, 0x3 }, /* Default */
> > + { 0x80003015, 0x000000C0, 0x3 },
> > + { 0x80000018, 0x000000C0, 0x3 },
> > };
> >
> > struct bxt_ddi_buf_trans {
> > --
> > 2.4.3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-05 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 15:32 [PATCH] drm/i915: Update Skylake DDI translation table for HDMI Rodrigo Vivi
2016-01-05 17:49 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-05 18:39 ` [PATCH] drm/i915: Update Skylake DDI translation table for HDMI Ville Syrjälä
2016-01-05 18:47 ` Vivi, Rodrigo [this message]
2016-01-05 19:11 ` Rodrigo Vivi
2016-01-07 16:53 ` Ville Syrjälä
2016-01-06 9:49 ` ✓ success: Fi.CI.BAT Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452019626.2858.0.camel@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=alex.feinman@daqri.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.