All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 10/10] t/t7006-pager.sh: use the $( ... ) construct for command substitution
Date: Thu,  7 Jan 2016 14:51:50 +0100	[thread overview]
Message-ID: <1452174710-28188-11-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1452174710-28188-1-git-send-email-gitter.spiros@gmail.com>

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t7006-pager.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh
index 6ea7ac4..e4fc5c8 100755
--- a/t/t7006-pager.sh
+++ b/t/t7006-pager.sh
@@ -424,7 +424,7 @@ test_expect_success TTY 'command-specific pager works for external commands' '
 	echo "foo:initial" >expect &&
 	>actual &&
 	test_config pager.external "sed s/^/foo:/ >actual" &&
-	test_terminal git --exec-path="`pwd`" external log --format=%s -1 &&
+	test_terminal git --exec-path="$(pwd)" external log --format=%s -1 &&
 	test_cmp expect actual
 '
 
-- 
2.3.3.GIT

  parent reply	other threads:[~2016-01-07 13:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 13:51 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2016-01-07 13:51 ` [PATCH 01/10] t/t5900-repo-selection.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 02/10] t/t6001-rev-list-graft.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 03/10] t/t6002-rev-list-bisect.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 04/10] t/t6015-rev-list-show-all-parents.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 05/10] t/t6032-merge-large-rename.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 06/10] t/t6132-pathspec-exclude.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 07/10] t/t7001-mv.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 08/10] t/t7003-filter-branch.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 09/10] t/t7004-tag.sh: " Elia Pinto
2016-01-07 13:51 ` Elia Pinto [this message]
2016-01-07 22:00 ` [PATCH 00/10] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452174710-28188-11-git-send-email-gitter.spiros@gmail.com \
    --to=gitter.spiros@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.