From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752666AbcAGOdy (ORCPT ); Thu, 7 Jan 2016 09:33:54 -0500 Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:37609 "EHLO e06smtp09.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbcAGOdw (ORCPT ); Thu, 7 Jan 2016 09:33:52 -0500 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: ubraun@linux.vnet.ibm.com X-IBM-RcptTo: kernel-janitors@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Message-ID: <1452177226.1081.6.camel@BR9GV9YG.de.ibm.com> Subject: Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online() From: Ursula Braun To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Heiko Carstens , Martin Schwidefsky , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Date: Thu, 07 Jan 2016 15:33:46 +0100 In-Reply-To: <5688F198.4040109@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F198.4040109@users.sourceforge.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010714-0037-0000-0000-0000052FD65D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-01-03 at 11:02 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:48:05 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus Elfring > --- > drivers/s390/net/qeth_core_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > index 7871537..54fde2e 100644 > --- a/drivers/s390/net/qeth_core_main.c > +++ b/drivers/s390/net/qeth_core_main.c > @@ -5637,7 +5637,7 @@ static void qeth_core_remove_device(struct ccwgroup_device *gdev) > static int qeth_core_set_online(struct ccwgroup_device *gdev) > { > struct qeth_card *card = dev_get_drvdata(&gdev->dev); > - int rc = 0; > + int rc; > int def_discipline; > > if (!card->discipline) { As Heiko already answered, you could propose a lot of this kind of changes with just minor benefit. I do not want to push them in single patches. Either there is a cleanup patch for explicit initialisation of local variables in the whole qeth driver, or we take care about such minor changes, once we touch the code anyway due to other reasons. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ursula Braun Date: Thu, 07 Jan 2016 14:33:46 +0000 Subject: Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online() Message-Id: <1452177226.1081.6.camel@BR9GV9YG.de.ibm.com> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F198.4040109@users.sourceforge.net> In-Reply-To: <5688F198.4040109@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Heiko Carstens , Martin Schwidefsky , LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sun, 2016-01-03 at 11:02 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:48:05 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus Elfring > --- > drivers/s390/net/qeth_core_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > index 7871537..54fde2e 100644 > --- a/drivers/s390/net/qeth_core_main.c > +++ b/drivers/s390/net/qeth_core_main.c > @@ -5637,7 +5637,7 @@ static void qeth_core_remove_device(struct ccwgroup_device *gdev) > static int qeth_core_set_online(struct ccwgroup_device *gdev) > { > struct qeth_card *card = dev_get_drvdata(&gdev->dev); > - int rc = 0; > + int rc; > int def_discipline; > > if (!card->discipline) { As Heiko already answered, you could propose a lot of this kind of changes with just minor benefit. I do not want to push them in single patches. Either there is a cleanup patch for explicit initialisation of local variables in the whole qeth driver, or we take care about such minor changes, once we touch the code anyway due to other reasons.