From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753290AbcAGToM (ORCPT ); Thu, 7 Jan 2016 14:44:12 -0500 Received: from smtprelay0211.hostedemail.com ([216.40.44.211]:57295 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752302AbcAGToK (ORCPT ); Thu, 7 Jan 2016 14:44:10 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2892:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:4321:5007:6261:7808:7903:8527:10004:10400:10848:11232:11658:11914:12114:12517:12519:12740:13069:13255:13311:13357:14096:14097:14659:21080:30006:30012:30054:30070:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:21,LUA_SUMMARY:none X-HE-Tag: taste40_7b5b08880ea36 X-Filterd-Recvd-Size: 2030 Message-ID: <1452195846.4028.24.camel@perches.com> Subject: Re: [PATCH] net-thunder: One check less in nicvf_register_interrupts() after error detection From: Joe Perches To: SF Markus Elfring , Robert Richter Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sunil Goutham , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Date: Thu, 07 Jan 2016 11:44:06 -0800 In-Reply-To: <568EBCE7.4060502@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <5685A273.6070607@users.sourceforge.net> <20160107110701.GE25086@rric.localdomain> <568EBCE7.4060502@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-01-07 at 20:30 +0100, SF Markus Elfring wrote: > > > Adjust a jump target to eliminate a check before error logging. > > > Use the identifier "report_failure" instead of "err". > > I don't see much value in those changes > Thanks for your feedback. > > Using the 'err' label is ok as it is not misleading and common use. > Is such a short jump label enough explanation for the information > "what" and "why"? When there is only one type of error possible, yes. > > And, there is no need to optimize the check since this is not the > > fast path > Really? - Is it a bit more efficient to avoid a double check for the > variable "ret" at the end of the current implementation for the > discussed function? Before asking questions you could answer yourself, please look at object code produced by the compiler before and after your proposed changes. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Thu, 07 Jan 2016 19:44:06 +0000 Subject: Re: [PATCH] net-thunder: One check less in nicvf_register_interrupts() after error detection Message-Id: <1452195846.4028.24.camel@perches.com> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5685A273.6070607@users.sourceforge.net> <20160107110701.GE25086@rric.localdomain> <568EBCE7.4060502@users.sourceforge.net> In-Reply-To: <568EBCE7.4060502@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, 2016-01-07 at 20:30 +0100, SF Markus Elfring wrote: > > > Adjust a jump target to eliminate a check before error logging. > > > Use the identifier "report_failure" instead of "err". > > I don't see much value in those changes > Thanks for your feedback. > > Using the 'err' label is ok as it is not misleading and common use. > Is such a short jump label enough explanation for the information > "what" and "why"? When there is only one type of error possible, yes. > > And, there is no need to optimize the check since this is not the > > fast path > Really? - Is it a bit more efficient to avoid a double check for the > variable "ret" at the end of the current implementation for the > discussed function? Before asking questions you could answer yourself, please look at object code produced by the compiler before and after your proposed changes. From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Thu, 07 Jan 2016 11:44:06 -0800 Subject: [PATCH] net-thunder: One check less in nicvf_register_interrupts() after error detection In-Reply-To: <568EBCE7.4060502@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <5685A273.6070607@users.sourceforge.net> <20160107110701.GE25086@rric.localdomain> <568EBCE7.4060502@users.sourceforge.net> Message-ID: <1452195846.4028.24.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2016-01-07 at 20:30 +0100, SF Markus Elfring wrote: > > > Adjust a jump target to eliminate a check before error logging. > > > Use the identifier "report_failure" instead of "err". > > I don't see much value in those changes > Thanks for your feedback. > > Using the 'err' label is ok as it is not misleading and common use. > Is such a short jump label enough explanation for the information > "what" and "why"? When there is only one type of error possible, yes. > > And, there is no need to optimize the check since this is not the > > fast path > Really? - Is it a bit more efficient to avoid a double check for the > variable "ret" at the end of the current implementation for the > discussed function? Before asking questions you could answer yourself, please look at object code produced by the compiler before and after your proposed changes.