All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Simon Wood <simon@mungewell.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>, Edwin <Edwin@velds.nl>,
	elias vanderstuyft <elias.vds@gmail.com>
Subject: Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel
Date: Thu, 07 Jan 2016 23:50:16 +0100	[thread overview]
Message-ID: <1452207016.7572.7.camel@devoid-pointer.net> (raw)
In-Reply-To: <20160107014721.GA35823@dtor-ws>

On Wed, 2016-01-06 at 17:47 -0800, Dmitry Torokhov wrote:
> On Wed, Jan 06, 2016 at 03:36:57PM +0100, Jiri Kosina wrote:
> > On Mon, 4 Jan 2016, Benjamin Tissoires wrote:
> > 
> > > Jiri, I *think* this commit still is in your next pull request
> > > for
> > > Linus. We might want to drop it before it hits Linus' tree.
> > 
> > What exactly would be the reasoning for dropping it?
> 
> It is wrong. Aside form the fact that IMO xpad.c is the wrong place
> for
> this code to be in, why are we waiting for the input device to be
> opened by userspace before we do the switch instead of doing it
> immediately?
> 

Hi all,

I have to disagree with the xpad driver being the wrong place to handle
this. The xpad driver matches devices it should handle by interface
class, subclass and protocol. When G920 first appears on the USB bus,
it for all intents and purposes looks like a Xbox One controller so the
xpad driver picks it up even if there is no G920-specific code in the
driver. Unless there is a way how to blacklist certain idProduct
values, the switch from XBone mode to HID mode will have to be done in
the xpad driver.

I'm pretty much done with the simple switching module but it will be of
no use if we cannot make the xpad module ignore G920 first.

Michal

  parent reply	other threads:[~2016-01-07 22:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 16:25 [Patch-V2 0/6] HID: Support for the " Simon Wood
2015-11-12 16:25 ` [Patch-V2 1/6] INPUT: xpad: Add minimal support for " Simon Wood
2015-11-19 13:50   ` Jiri Kosina
2015-11-19 18:31     ` Dmitry Torokhov
2015-11-19 18:35       ` Simon Wood
2015-11-19 23:19         ` Edwin
2015-12-10  1:23       ` Dmitry Torokhov
2015-12-10  1:39         ` Dmitry Torokhov
2015-12-10 17:08           ` Benjamin Tissoires
2015-12-10 18:40             ` Dmitry Torokhov
2016-01-04  9:55               ` Benjamin Tissoires
2016-01-04 12:43                 ` madcatxster
2016-01-04 12:43                   ` madcatxster
     [not found]                 ` <568ad0ae.ea3d320a.6acab.2b84SMTPIN_ADDED_MISSING@mx.google.com>
2016-01-05  1:01                   ` Dmitry Torokhov
2016-01-06 14:36                 ` Jiri Kosina
2016-01-07  1:47                   ` Dmitry Torokhov
2016-01-07  4:25                     ` Simon Wood
2016-01-07 22:50                     ` Michal Malý [this message]
2016-01-07 22:53                       ` Dmitry Torokhov
2016-01-07 22:53                         ` Dmitry Torokhov
2016-01-07 23:05                         ` Michal Malý
2016-01-07 23:05                           ` Michal Malý
2016-01-08  9:11                     ` Jiri Kosina
2015-12-13 12:50             ` Elias Vanderstuyft
2015-11-12 16:25 ` [Patch-V2 2/6] HID: hid-logitech-hidpp: Add support for very long packets Simon Wood
2015-11-12 16:25 ` [Patch-V2 3/6] HID: hid-logitech-hidpp: Add basic support for Logitech G920 Simon Wood
2015-11-19 11:18   ` Benjamin Tissoires
2015-11-12 16:25 ` [Patch-V2 4/6] HID: hid-logitech-hidpp: Add range sysfs " Simon Wood
2015-11-12 16:25 ` [Patch-V2 5/6] HID: Add vendor specific usage pages " Simon Wood
2015-11-12 16:25 ` [Patch-V2 6/6] HID: hid-logitech-hidpp: G920 remove deadzones Simon Wood
2015-11-12 16:32 ` [Patch-V2 0/6] HID: Support for the Logitech G920 Wheel Simon Wood
2015-11-19 10:04 ` Jiri Kosina
2015-11-19 11:23   ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452207016.7572.7.camel@devoid-pointer.net \
    --to=madcatxster@devoid-pointer.net \
    --cc=Edwin@velds.nl \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=elias.vds@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@mungewell.org \
    --subject='Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.