From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbcAGWuX (ORCPT ); Thu, 7 Jan 2016 17:50:23 -0500 Received: from devoid-pointer.net ([31.31.77.140]:34319 "EHLO smtp.devoid-pointer.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbcAGWuU (ORCPT ); Thu, 7 Jan 2016 17:50:20 -0500 Message-ID: <1452207016.7572.7.camel@devoid-pointer.net> Subject: Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel From: Michal =?ISO-8859-1?Q?Mal=FD?= To: Dmitry Torokhov , Jiri Kosina Cc: Benjamin Tissoires , Simon Wood , "linux-input@vger.kernel.org" , lkml , Edwin , elias vanderstuyft Date: Thu, 07 Jan 2016 23:50:16 +0100 In-Reply-To: <20160107014721.GA35823@dtor-ws> References: <1447345535-2912-1-git-send-email-simon@mungewell.org> <1447345535-2912-2-git-send-email-simon@mungewell.org> <20151119183106.GC24773@dtor-ws> <20151210170853.GC16026@mail.corp.redhat.com> <20160104095524.GB20222@mail.corp.redhat.com> <20160107014721.GA35823@dtor-ws> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-01-06 at 17:47 -0800, Dmitry Torokhov wrote: > On Wed, Jan 06, 2016 at 03:36:57PM +0100, Jiri Kosina wrote: > > On Mon, 4 Jan 2016, Benjamin Tissoires wrote: > > > > > Jiri, I *think* this commit still is in your next pull request > > > for > > > Linus. We might want to drop it before it hits Linus' tree. > > > > What exactly would be the reasoning for dropping it? > > It is wrong. Aside form the fact that IMO xpad.c is the wrong place > for > this code to be in, why are we waiting for the input device to be > opened by userspace before we do the switch instead of doing it > immediately? > Hi all, I have to disagree with the xpad driver being the wrong place to handle this. The xpad driver matches devices it should handle by interface class, subclass and protocol. When G920 first appears on the USB bus, it for all intents and purposes looks like a Xbox One controller so the xpad driver picks it up even if there is no G920-specific code in the driver. Unless there is a way how to blacklist certain idProduct values, the switch from XBone mode to HID mode will have to be done in the xpad driver. I'm pretty much done with the simple switching module but it will be of no use if we cannot make the xpad module ignore G920 first. Michal