From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754177AbcAHIZr (ORCPT ); Fri, 8 Jan 2016 03:25:47 -0500 Received: from mga02.intel.com ([134.134.136.20]:38438 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbcAHIZq (ORCPT ); Fri, 8 Jan 2016 03:25:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,537,1444719600"; d="asc'?scan'208";a="877155556" Message-ID: <1452241542.19358.30.camel@intel.com> Subject: Re: [PATCH] ixgbe: constify ixgbe_mbx_operations structure From: Jeff Kirsher To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Jesse Brandeburg , Shannon Nelson , Carolyn Wyborny , Don Skidmore , Bruce Allan , John Ronciak , Mitch Williams , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 08 Jan 2016 00:25:42 -0800 In-Reply-To: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr> References: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-HujZiObMIwXNRgw4Hj1C" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-HujZiObMIwXNRgw4Hj1C Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2016-01-03 at 07:55 +0100, Julia Lawall wrote: > This ixgbe_mbx_operations structure is never modified, so declare it > as > const.=C2=A0 The other structure of this type is already const. >=20 > Done with the help of Coccinelle. >=20 > Signed-off-by: Julia Lawall >=20 > --- > =C2=A0drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c=C2=A0 |=C2=A0=C2=A0=C2= =A0 2 +- > =C2=A0drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h=C2=A0 |=C2=A0=C2=A0=C2= =A0 2 +- > =C2=A0drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |=C2=A0=C2=A0=C2=A0 2= +- > =C2=A03 files changed, 3 insertions(+), 3 deletions(-) Dropping this patch since Mark has provided a more in-depth patch to fix the entire driver. --=-HujZiObMIwXNRgw4Hj1C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABCgAGBQJWj3KGAAoJEOVv75VaS+3Ou5gP/0cUBuVDqfV+A1OaFgvwslBs 81Ybi2GBd2FydLRgQBDYNsExVAZfBzPkUwy4EDJebSeOSjqsi+PEpRkGkZ9gFd6r xIf7JJQtd5cNScKbozfcX7ptnwT7NDAm+Tsx1rruws+RVEnFcrTpqUy/t4hyKA79 pYbh8NASmO3Apuzpv4rJ2vQgoZT3XOW7ZxTfRU8w74wvWX7QVhbThGMjJQOBKeAq 9mVaXvoyC62jtMFJ1c//sEzyh92SVhRtH4lSSbeIIsLPtCtKZvq3vQUtjse24XeY TYQxbTiGd1w5aJOoueYvqCWOJKgQu2SEDf0tKhl4YnnPg3RR582vaFTH6hkEewDP oHhaUrEtkTAUeWHezSJpUqcSEvzswhaoumeydB+FHMHfyer8IUTkedgFwTcyV3VT odKZvGKSUq3qPRsQwV/2GQd0Wb5fS6IeajMc0KdXvWX/vloD8nthxTliw0iVHam5 45GhhbRoVP+oargbXfEBX3UVLUXcoX4s6d560L/h6HFHpin8KRX6YYuF4cd1SMFF 3QAkwtQN9GPwINJX7ngGPQKXSRGc7XylnXID2dSYz48tEiu+c8c5+FgbKMUdNGx1 ooFSPBTTvsAUZWoc6HOxKb7Kwo7UCfhOAqrzeghGYQmXKhItITr7gyaUnbB1CHSo XX4U3h+dhpdXxV4rEOci =KOlC -----END PGP SIGNATURE----- --=-HujZiObMIwXNRgw4Hj1C-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Fri, 08 Jan 2016 08:25:42 +0000 Subject: Re: [PATCH] ixgbe: constify ixgbe_mbx_operations structure Message-Id: <1452241542.19358.30.camel@intel.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-HujZiObMIwXNRgw4Hj1C" List-Id: References: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr> To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Jesse Brandeburg , Shannon Nelson , Carolyn Wyborny , Don Skidmore , Bruce Allan , John Ronciak , Mitch Williams , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org --=-HujZiObMIwXNRgw4Hj1C Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2016-01-03 at 07:55 +0100, Julia Lawall wrote: > This ixgbe_mbx_operations structure is never modified, so declare it > as > const.=C2=A0 The other structure of this type is already const. >=20 > Done with the help of Coccinelle. >=20 > Signed-off-by: Julia Lawall >=20 > --- > =C2=A0drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c=C2=A0 |=C2=A0=C2=A0=C2= =A0 2 +- > =C2=A0drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h=C2=A0 |=C2=A0=C2=A0=C2= =A0 2 +- > =C2=A0drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |=C2=A0=C2=A0=C2=A0 2= +- > =C2=A03 files changed, 3 insertions(+), 3 deletions(-) Dropping this patch since Mark has provided a more in-depth patch to fix the entire driver. --=-HujZiObMIwXNRgw4Hj1C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABCgAGBQJWj3KGAAoJEOVv75VaS+3Ou5gP/0cUBuVDqfV+A1OaFgvwslBs 81Ybi2GBd2FydLRgQBDYNsExVAZfBzPkUwy4EDJebSeOSjqsi+PEpRkGkZ9gFd6r xIf7JJQtd5cNScKbozfcX7ptnwT7NDAm+Tsx1rruws+RVEnFcrTpqUy/t4hyKA79 pYbh8NASmO3Apuzpv4rJ2vQgoZT3XOW7ZxTfRU8w74wvWX7QVhbThGMjJQOBKeAq 9mVaXvoyC62jtMFJ1c//sEzyh92SVhRtH4lSSbeIIsLPtCtKZvq3vQUtjse24XeY TYQxbTiGd1w5aJOoueYvqCWOJKgQu2SEDf0tKhl4YnnPg3RR582vaFTH6hkEewDP oHhaUrEtkTAUeWHezSJpUqcSEvzswhaoumeydB+FHMHfyer8IUTkedgFwTcyV3VT odKZvGKSUq3qPRsQwV/2GQd0Wb5fS6IeajMc0KdXvWX/vloD8nthxTliw0iVHam5 45GhhbRoVP+oargbXfEBX3UVLUXcoX4s6d560L/h6HFHpin8KRX6YYuF4cd1SMFF 3QAkwtQN9GPwINJX7ngGPQKXSRGc7XylnXID2dSYz48tEiu+c8c5+FgbKMUdNGx1 ooFSPBTTvsAUZWoc6HOxKb7Kwo7UCfhOAqrzeghGYQmXKhItITr7gyaUnbB1CHSo XX4U3h+dhpdXxV4rEOci =KOlC -----END PGP SIGNATURE----- --=-HujZiObMIwXNRgw4Hj1C-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Fri, 08 Jan 2016 00:25:42 -0800 Subject: [Intel-wired-lan] [PATCH] ixgbe: constify ixgbe_mbx_operations structure In-Reply-To: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr> References: <1451804129-32213-1-git-send-email-Julia.Lawall@lip6.fr> Message-ID: <1452241542.19358.30.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Sun, 2016-01-03 at 07:55 +0100, Julia Lawall wrote: > This ixgbe_mbx_operations structure is never modified, so declare it > as > const.? The other structure of this type is already const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > ?drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c? |??? 2 +- > ?drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h? |??? 2 +- > ?drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |??? 2 +- > ?3 files changed, 3 insertions(+), 3 deletions(-) Dropping this patch since Mark has provided a more in-depth patch to fix the entire driver. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: