From: Philipp Zabel <p.zabel@pengutronix.de>
To: Thierry Reding <treding@nvidia.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: [PATCH 2/4] drm: bridge/dw-hdmi: remove unused code
Date: Fri, 8 Jan 2016 10:02:05 +0100 [thread overview]
Message-ID: <1452243727-7242-2-git-send-email-p.zabel@pengutronix.de> (raw)
In-Reply-To: <1452243727-7242-1-git-send-email-p.zabel@pengutronix.de>
From: Sascha Hauer <s.hauer@pengutronix.de>
The cable_plugin field in struct dw_hdmi is never set. Remove it and with
it all code that is only executed when the variable is true.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/bridge/dw-hdmi.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
index b0ebf92..e41ff4b 100644
--- a/drivers/gpu/drm/bridge/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/dw-hdmi.c
@@ -118,7 +118,6 @@ struct dw_hdmi {
int vic;
struct edid *edid;
- bool cable_plugin;
bool phy_enabled;
struct drm_display_mode previous_mode;
@@ -1158,24 +1157,10 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF);
}
-static void hdmi_enable_overflow_interrupts(struct dw_hdmi *hdmi)
-{
- hdmi_writeb(hdmi, 0, HDMI_FC_MASK2);
- hdmi_writeb(hdmi, 0, HDMI_IH_MUTE_FC_STAT2);
-}
-
-static void hdmi_disable_overflow_interrupts(struct dw_hdmi *hdmi)
-{
- hdmi_writeb(hdmi, HDMI_IH_MUTE_FC_STAT2_OVERFLOW_MASK,
- HDMI_IH_MUTE_FC_STAT2);
-}
-
static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
{
int ret;
- hdmi_disable_overflow_interrupts(hdmi);
-
hdmi->vic = drm_match_cea_mode(mode);
if (!hdmi->vic) {
@@ -1240,8 +1225,6 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
hdmi_tx_hdcp_config(hdmi);
dw_hdmi_clear_overflow(hdmi);
- if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
- hdmi_enable_overflow_interrupts(hdmi);
return 0;
}
--
2.6.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-08 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 9:02 [PATCH 1/4] drm: bridge/dw-hdmi: cache edid data Philipp Zabel
2016-01-08 9:02 ` Philipp Zabel [this message]
2016-01-08 9:02 ` [PATCH 3/4] drm: bridge/dw-hdmi: detect initial connector state Philipp Zabel
2016-01-08 11:24 ` Russell King - ARM Linux
2016-01-08 11:40 ` Philipp Zabel
2016-03-02 16:35 ` Thierry Reding
2016-01-08 9:02 ` [PATCH 4/4] drm: bridge/dw-hdmi: use rx sense for plug detection if hpd is unreliable Philipp Zabel
2016-01-08 11:34 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452243727-7242-2-git-send-email-p.zabel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.