All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org
Subject: [PATCH v2 8/8] [media] omap3isp: Check v4l2_of_parse_endpoint() return value
Date: Mon, 11 Jan 2016 13:47:16 -0300	[thread overview]
Message-ID: <1452530844-30609-9-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1452530844-30609-1-git-send-email-javier@osg.samsung.com>

The v4l2_of_parse_endpoint() function can fail so check the return value.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---

Changes in v2: None

 drivers/media/platform/omap3isp/isp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 79a0b953bba3..891e54394a1c 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2235,8 +2235,11 @@ static int isp_of_parse_node(struct device *dev, struct device_node *node,
 	struct isp_bus_cfg *buscfg = &isd->bus;
 	struct v4l2_of_endpoint vep;
 	unsigned int i;
+	int ret;
 
-	v4l2_of_parse_endpoint(node, &vep);
+	ret = v4l2_of_parse_endpoint(node, &vep);
+	if (ret)
+		return ret;
 
 	dev_dbg(dev, "parsing endpoint %s, interface %u\n", node->full_name,
 		vep.base.port);
-- 
2.4.3

      parent reply	other threads:[~2016-01-11 16:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 16:47 [PATCH v2 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Javier Martinez Canillas
2016-01-11 16:47 ` Javier Martinez Canillas
2016-01-11 16:47 ` [PATCH v2 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Javier Martinez Canillas
2016-01-11 16:47 ` [PATCH v2 2/8] [media] adv7604: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas
2016-01-11 16:47 ` [PATCH v2 3/8] [media] s5c73m3: " Javier Martinez Canillas
2016-01-11 16:47 ` [PATCH v2 4/8] [media] s5k5baf: " Javier Martinez Canillas
2016-01-11 16:47 ` [PATCH v2 5/8] [media] tvp514x: " Javier Martinez Canillas
2016-01-13 10:39   ` Lad, Prabhakar
2016-01-11 16:47 ` [PATCH v2 6/8] [media] tvp7002: " Javier Martinez Canillas
2016-01-13 10:40   ` Lad, Prabhakar
2016-01-11 16:47 ` [PATCH v2 7/8] [media] exynos4-is: " Javier Martinez Canillas
2016-01-11 16:47   ` Javier Martinez Canillas
2016-01-11 16:47 ` Javier Martinez Canillas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452530844-30609-9-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.