From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 2/6] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Wed, 13 Jan 2016 16:05:33 +0200 Message-ID: <1452693933.2628.23.camel@gmail.com> References: <1451998226-21433-1-git-send-email-shubhangi.shrivastava@intel.com> <1451998226-21433-3-git-send-email-shubhangi.shrivastava@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f65.google.com (mail-pa0-f65.google.com [209.85.220.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 650FF6E796 for ; Wed, 13 Jan 2016 06:05:39 -0800 (PST) Received: by mail-pa0-f65.google.com with SMTP id a20so21982153pag.3 for ; Wed, 13 Jan 2016 06:05:39 -0800 (PST) In-Reply-To: <1451998226-21433-3-git-send-email-shubhangi.shrivastava@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shubhangi Shrivastava , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE2LTAxLTA1IGF0IDE4OjIwICswNTMwLCBTaHViaGFuZ2kgU2hyaXZhc3RhdmEg d3JvdGU6Cj4gQ3VycmVudCBEUCBkZXRlY3Rpb24gaGFzIERQQ0Qgb3BlcmF0aW9ucyBzcGxpdCBh Y3Jvc3MKPiBpbnRlbF9kcF9ocGRfcHVsc2UgYW5kIGludGVsX2RwX2RldGVjdCB3aGljaCBjb250 YWlucwo+IGR1cGxpY2F0ZXMgYXMgd2VsbC4gQWxzbyBpbnRlbF9kcF9kZXRlY3QgaXMgY2FsbGVk Cj4gZHVyaW5nIG1vZGVzIGVudW1lcmF0aW9uIGFzIHdlbGwgd2hpY2ggd2lsbCByZXN1bHQKPiBp biBtdWx0aXBsZSBkcGNkIG9wZXJhdGlvbnMuIFNvIHRoaXMgcGF0Y2ggdHJpZXMKPiB0byBzb2x2 ZSBib3RoIHRoZXNlIGJ5IGJyaW5naW5nIGFsbCBEUENEIG9wZXJhdGlvbnMKPiBpbiBvbmUgc2lu Z2xlIGZ1bmN0aW9uIGFuZCBtYWtlIGludGVsX2RwX2RldGVjdAo+IHVzZSBleGlzdGluZyB2YWx1 ZXMgaW5zdGVhZCBvZiByZXBlYXRpbmcgc2FtZSBzdGVwcy4KPiAKPiB2MjogUHVsbGVkIGluIGEg aHVuayBmcm9tIGxhc3QgcGF0Y2ggb2YgdGhlIHNlcmllcyB0bwo+ICAgICB0aGlzIHBhdGNoLiAo QW5kZXIpCj4gdjM6IEFkZGVkIE1TVCBob3RwbHVnIGhhbmRsaW5nLiAoQW5kZXIpCgpSZXZpZXdl ZC1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxjb25zZWx2YW4yQGdtYWlsLmNvbT4K Cj4gCj4gVGVzdGVkLWJ5OiBOYXRoYW4gRCBDaW9iYW51IDxuYXRoYW4uZC5jaW9iYW51QGludGVs LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBTaXZha3VtYXIgVGh1bGFzaW1hbmkgPHNpdmFrdW1hci50 aHVsYXNpbWFuaUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU2h1YmhhbmdpIFNocml2YXN0 YXZhIDxzaHViaGFuZ2kuc2hyaXZhc3RhdmFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNzEgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLQo+IC0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDI3IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IGUzYjQyMDguLjEz Nzc1N2IgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtNDY0NSw4ICs0NjQ1LDE5 IEBAIGludGVsX2RwX2xvbmdfcHVsc2Uoc3RydWN0IGludGVsX2Nvbm5lY3Rvcgo+ICppbnRlbF9j b25uZWN0b3IpCj4gIAlpbnRlbF9kcF9wcm9iZV9vdWkoaW50ZWxfZHApOwo+ICAKPiAgCXJldCA9 IGludGVsX2RwX3Byb2JlX21zdChpbnRlbF9kcCk7Cj4gLQlpZiAocmV0KQo+ICsJaWYgKHJldCkg ewo+ICsJCWdvdG8gb3V0Owo+ICsJfSBlbHNlIGlmIChjb25uZWN0b3ItPnN0YXR1cyA9PSBjb25u ZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZCkgewo+ICsJCS8qCj4gKwkJICogSWYgZGlzcGxheSB3YXMg Y29ubmVjdGVkIGFscmVhZHkgYW5kIGlzIHN0aWxsIGNvbm5lY3RlZAo+ICsJCSAqIGNoZWNrIGxp bmtzIHN0YXR1cywgdGhlcmUgaGFzIGJlZW4ga25vd24gaXNzdWVzIG9mCj4gKwkJICogbGluayBs b3NzIHRyaWdnZXJyaW5nIGxvbmcgcHVsc2UhISEhCj4gKwkJICovCj4gKwkJZHJtX21vZGVzZXRf bG9jaygmZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4LCBOVUxMKTsKPiArCQlpbnRl bF9kcF9jaGVja19saW5rX3N0YXR1cyhpbnRlbF9kcCk7Cj4gKwkJZHJtX21vZGVzZXRfdW5sb2Nr KCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpOwo+ICAJCWdvdG8gb3V0Owo+ICsJ fQo+ICAKPiAgCS8qCj4gIAkgKiBDbGVhcmluZyBOQUNLIGFuZCBkZWZlciBjb3VudHMgdG8gZ2V0 IHRoZWlyIGV4YWN0IHZhbHVlcwo+IEBAIC00Njc3LDggKzQ2ODgsMjEgQEAgaW50ZWxfZHBfbG9u Z19wdWxzZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yCj4gKmludGVsX2Nvbm5lY3RvcikKPiAgCX0K PiAgCj4gIG91dDoKPiAtCWlmIChzdGF0dXMgIT0gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQp Cj4gKwlpZiAoc3RhdHVzICE9IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkKSB7Cj4gIAkJaW50 ZWxfZHBfdW5zZXRfZWRpZChpbnRlbF9kcCk7Cj4gKwkJLyoKPiArCQkgKiBJZiB3ZSB3ZXJlIGlu IE1TVCBtb2RlLCBhbmQgZGV2aWNlIGlzIG5vdCB0aGVyZSwKPiArCQkgKiBnZXQgb3V0IG9mIE1T VCBtb2RlCj4gKwkJICovCj4gKwkJaWYgKGludGVsX2RwLT5pc19tc3QpIHsKPiArCQkJRFJNX0RF QlVHX0tNUygiTVNUIGRldmljZSBtYXkgaGF2ZSBkaXNhcHBlYXJlZCAlZCB2cwo+ICVkXG4iLAo+ ICsJCQkJaW50ZWxfZHAtPmlzX21zdCwgaW50ZWxfZHAKPiAtPm1zdF9tZ3IubXN0X3N0YXRlKTsK PiArCQkJaW50ZWxfZHAtPmlzX21zdCA9IGZhbHNlOwo+ICsJCQlkcm1fZHBfbXN0X3RvcG9sb2d5 X21ncl9zZXRfbXN0KCZpbnRlbF9kcC0+bXN0X21nciwKPiArCQkJCQkJCWludGVsX2RwLT5pc19t c3QpOwo+ICsJCX0KPiArCX0KPiArCj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dCh0b19pOTE1 KGRldiksIHBvd2VyX2RvbWFpbik7Cj4gIAlyZXR1cm47Cj4gIH0KPiBAQCAtNDcwMSw3ICs0NzI1 LDggQEAgaW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIGJv b2wKPiBmb3JjZSkKPiAgCQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4g IAl9Cj4gIAo+IC0JaW50ZWxfZHBfbG9uZ19wdWxzZShpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVj dG9yKTsKPiArCWlmIChmb3JjZSkKPiArCQlpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5h dHRhY2hlZF9jb25uZWN0b3IpOwo+ICAKPiAgCWlmIChpbnRlbF9jb25uZWN0b3ItPmRldGVjdF9l ZGlkKQo+ICAJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZDsKPiBAQCAtNTAzNCwy NSArNTA1OSwyNSBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9y dAo+ICppbnRlbF9kaWdfcG9ydCwgYm9vbCBsb25nX2hwZCkKPiAgCQkvKiBpbmRpY2F0ZSB0aGF0 IHdlIG5lZWQgdG8gcmVzdGFydCBsaW5rIHRyYWluaW5nICovCj4gIAkJaW50ZWxfZHAtPnRyYWlu X3NldF92YWxpZCA9IGZhbHNlOwo+ICAKPiAtCQlpZiAoIWludGVsX2RpZ2l0YWxfcG9ydF9jb25u ZWN0ZWQoZGV2X3ByaXYsIGludGVsX2RpZ19wb3J0KSkKPiAtCQkJZ290byBtc3RfZmFpbDsKPiAt Cj4gLQkJaWYgKCFpbnRlbF9kcF9nZXRfZHBjZChpbnRlbF9kcCkpIHsKPiAtCQkJZ290byBtc3Rf ZmFpbDsKPiAtCQl9Cj4gLQo+IC0JCWludGVsX2RwX3Byb2JlX291aShpbnRlbF9kcCk7Cj4gKwkJ aW50ZWxfZHBfbG9uZ19wdWxzZShpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yKTsKPiArCQlp ZiAoaW50ZWxfZHAtPmlzX21zdCkKPiArCQkJcmV0ID0gSVJRX0hBTkRMRUQ7Cj4gKwkJZ290byBw dXRfcG93ZXI7Cj4gIAo+IC0JCWlmICghaW50ZWxfZHBfcHJvYmVfbXN0KGludGVsX2RwKSkgewo+ IC0JCQlkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgs Cj4gTlVMTCk7Cj4gLQkJCWludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKGludGVsX2RwKTsKPiAt CQkJZHJtX21vZGVzZXRfdW5sb2NrKCZkZXYKPiAtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0 ZXgpOwo+IC0JCQlnb3RvIG1zdF9mYWlsOwo+IC0JCX0KPiAgCX0gZWxzZSB7Cj4gIAkJaWYgKGlu dGVsX2RwLT5pc19tc3QpIHsKPiAtCQkJaWYgKGludGVsX2RwX2NoZWNrX21zdF9zdGF0dXMoaW50 ZWxfZHApID09IC1FSU5WQUwpCj4gLQkJCQlnb3RvIG1zdF9mYWlsOwo+ICsJCQlpZiAoaW50ZWxf ZHBfY2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkgPT0gLUVJTlZBTCkgewo+ICsJCQkJLyoKPiAr CQkJCSAqIElmIHdlIHdlcmUgaW4gTVNUIG1vZGUsIGFuZCBkZXZpY2UgaXMgbm90Cj4gKwkJCQkg KiB0aGVyZSwgZ2V0IG91dCBvZiBNU1QgbW9kZQo+ICsJCQkJICovCj4gKwkJCQlEUk1fREVCVUdf S01TKCJNU1QgZGV2aWNlIG1heSBoYXZlCj4gZGlzYXBwZWFyZWQgJWQgdnMgJWRcbiIsCj4gKwkJ CQkJaW50ZWxfZHAtPmlzX21zdCwgaW50ZWxfZHAKPiAtPm1zdF9tZ3IubXN0X3N0YXRlKTsKPiAr CQkJCWludGVsX2RwLT5pc19tc3QgPSBmYWxzZTsKPiArCQkJCWRybV9kcF9tc3RfdG9wb2xvZ3lf bWdyX3NldF9tc3QoJmludGVsX2RwCj4gLT5tc3RfbWdyLAo+ICsJCQkJCQkJCWludGVsX2RwCj4g LT5pc19tc3QpOwo+ICsJCQkJZ290byBwdXRfcG93ZXI7Cj4gKwkJCX0KPiAgCQl9Cj4gIAo+ICAJ CWlmICghaW50ZWxfZHAtPmlzX21zdCkgewo+IEBAIC01MDY0LDE0ICs1MDg5LDYgQEAgaW50ZWxf ZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQKPiAqaW50ZWxfZGlnX3BvcnQs IGJvb2wgbG9uZ19ocGQpCj4gIAo+ICAJcmV0ID0gSVJRX0hBTkRMRUQ7Cj4gIAo+IC0JZ290byBw dXRfcG93ZXI7Cj4gLW1zdF9mYWlsOgo+IC0JLyogaWYgd2Ugd2VyZSBpbiBNU1QgbW9kZSwgYW5k IGRldmljZSBpcyBub3QgdGhlcmUgZ2V0IG91dCBvZiBNU1QKPiBtb2RlICovCj4gLQlpZiAoaW50 ZWxfZHAtPmlzX21zdCkgewo+IC0JCURSTV9ERUJVR19LTVMoIk1TVCBkZXZpY2UgbWF5IGhhdmUg ZGlzYXBwZWFyZWQgJWQgdnMgJWRcbiIsCj4gaW50ZWxfZHAtPmlzX21zdCwgaW50ZWxfZHAtPm1z dF9tZ3IubXN0X3N0YXRlKTsKPiAtCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7Cj4gLQkJZHJt X2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAtPm1zdF9tZ3IsIGludGVsX2Rw Cj4gLT5pc19tc3QpOwo+IC0JfQo+ICBwdXRfcG93ZXI6Cj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2Vy X3B1dChkZXZfcHJpdiwgcG93ZXJfZG9tYWluKTsKPiAgCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==