From: Stephen Hurd <shurd@broadcom.com>
To: <dev@dpdk.org>
Subject: [PATCH v2] app/testpmd Fix max_socket detection
Date: Wed, 13 Jan 2016 14:23:36 -0800 [thread overview]
Message-ID: <1452723816-73141-1-git-send-email-shurd@broadcom.com> (raw)
In-Reply-To: <24888901-A45C-4E23-871E-3485AF2423D2@intel.com>
Previously, max_socket was set to the highest numbered socket with
an enabled lcore. The intent is to set it to the highest socket
regardless of it being enabled.
Change-Id: I6306af0f90aa3c1fc5ffed75d1eed8297d29e132
Signed-off-by: Stephen Hurd <shurd@broadcom.com>
v2: Forgot to commit before sending email... sorry for the nouse.
---
app/test-pmd/testpmd.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 6129c26..a4088f9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -359,17 +359,17 @@ set_default_fwd_lcores_config(void)
nb_lc = 0;
for (i = 0; i < RTE_MAX_LCORE; i++) {
- if (! rte_lcore_is_enabled(i))
- continue;
- if (i == rte_get_master_lcore())
- continue;
- fwd_lcores_cpuids[nb_lc++] = i;
sock_num = rte_lcore_to_socket_id(i) + 1;
if (sock_num > max_socket) {
if (sock_num > RTE_MAX_NUMA_NODES)
rte_exit(EXIT_FAILURE, "Total sockets greater than %u\n", RTE_MAX_NUMA_NODES);
max_socket = sock_num;
}
+ if (! rte_lcore_is_enabled(i))
+ continue;
+ if (i == rte_get_master_lcore())
+ continue;
+ fwd_lcores_cpuids[nb_lc++] = i;
}
nb_lcores = (lcoreid_t) nb_lc;
nb_cfg_lcores = nb_lcores;
--
1.9.1
next prev parent reply other threads:[~2016-01-13 22:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <533710CFB86FA344BFBF2D6802E6028621BAF050@SHSMSX101.ccr.corp.intel.com>
[not found] ` <156984479488CD49A184F5CAB4AF93460719DEC4@IRVEXCHMB14.corp.ad.broadcom.com>
[not found] ` <533710CFB86FA344BFBF2D6802E6028621BAF45F@SHSMSX101.ccr.corp.intel.com>
[not found] ` <156984479488CD49A184F5CAB4AF93460719E1D1@IRVEXCHMB14.corp.ad.broadcom.com>
2015-12-19 1:33 ` Issue with patch "app/testpmd: detect numa socket count" Qiu, Michael
2016-01-13 22:20 ` [PATCH] app/testpmd Fix max_socket detection Stephen Hurd
2016-01-13 22:23 ` Stephen Hurd [this message]
2016-01-14 13:44 ` [PATCH v2] " Bruce Richardson
2016-01-15 0:59 ` Stephen Hurd
2016-01-15 1:01 ` Stephen Hurd
2016-01-15 10:42 ` Bruce Richardson
2016-03-02 11:04 ` De Lara Guarch, Pablo
2016-03-05 19:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452723816-73141-1-git-send-email-shurd@broadcom.com \
--to=shurd@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.