From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755288AbcAOO53 (ORCPT ); Fri, 15 Jan 2016 09:57:29 -0500 Received: from mail-yk0-f171.google.com ([209.85.160.171]:33474 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755141AbcAOO5Y (ORCPT ); Fri, 15 Jan 2016 09:57:24 -0500 From: Gustavo Padovan To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan Subject: [RFC 26/29] dma-buf/fence: remove pointless fence_timeline_signal at destroy phase Date: Fri, 15 Jan 2016 12:55:36 -0200 Message-Id: <1452869739-3304-27-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1452869739-3304-1-git-send-email-gustavo@padovan.org> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo Padovan All changes to timeline value come through the user via fence_timeline_signal() calls. When fence_timeline_destroy() is called no changes on timeline->value happens hence call fence_timeline_signal() with no increment is pointless. Signed-off-by: Gustavo Padovan --- drivers/dma-buf/fence.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dma-buf/fence.c b/drivers/dma-buf/fence.c index 7a5fc9b..26f5f0f 100644 --- a/drivers/dma-buf/fence.c +++ b/drivers/dma-buf/fence.c @@ -136,7 +136,7 @@ EXPORT_SYMBOL(fence_timeline_put); * fence_timeline_destroy - destroy a fence_timeline * @timeline [in] the fence_timeline to destroy * - * This function destroys a timeline. It signals any active fence first. + * This function destroys a timeline. */ void fence_timeline_destroy(struct fence_timeline *timeline) { @@ -147,10 +147,6 @@ void fence_timeline_destroy(struct fence_timeline *timeline) */ smp_wmb(); - /* - * signal any children that their parent is going away. - */ - fence_timeline_signal(timeline, 0); fence_timeline_put(timeline); } EXPORT_SYMBOL(fence_timeline_destroy); -- 2.5.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: [RFC 26/29] dma-buf/fence: remove pointless fence_timeline_signal at destroy phase Date: Fri, 15 Jan 2016 12:55:36 -0200 Message-ID: <1452869739-3304-27-git-send-email-gustavo@padovan.org> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com [209.85.160.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCAB07A0FF for ; Fri, 15 Jan 2016 06:57:24 -0800 (PST) Received: by mail-yk0-f176.google.com with SMTP id x67so546638134ykd.2 for ; Fri, 15 Jan 2016 06:57:24 -0800 (PST) In-Reply-To: <1452869739-3304-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, daniels@collabora.com, Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Maarten Lankhorst , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org RnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgoK QWxsIGNoYW5nZXMgdG8gdGltZWxpbmUgdmFsdWUgY29tZSB0aHJvdWdoIHRoZSB1c2VyIHZpYQpm ZW5jZV90aW1lbGluZV9zaWduYWwoKSBjYWxscy4gV2hlbiBmZW5jZV90aW1lbGluZV9kZXN0cm95 KCkgaXMgY2FsbGVkIG5vCmNoYW5nZXMgb24gdGltZWxpbmUtPnZhbHVlIGhhcHBlbnMgaGVuY2Ug Y2FsbCBmZW5jZV90aW1lbGluZV9zaWduYWwoKSB3aXRoCm5vIGluY3JlbWVudCBpcyBwb2ludGxl c3MuCgpTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xs YWJvcmEuY28udWs+Ci0tLQogZHJpdmVycy9kbWEtYnVmL2ZlbmNlLmMgfCA2ICstLS0tLQogMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2RyaXZlcnMvZG1hLWJ1Zi9mZW5jZS5jIGIvZHJpdmVycy9kbWEtYnVmL2ZlbmNlLmMKaW5kZXgg N2E1ZmM5Yi4uMjZmNWYwZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9kbWEtYnVmL2ZlbmNlLmMKKysr IGIvZHJpdmVycy9kbWEtYnVmL2ZlbmNlLmMKQEAgLTEzNiw3ICsxMzYsNyBAQCBFWFBPUlRfU1lN Qk9MKGZlbmNlX3RpbWVsaW5lX3B1dCk7CiAgKiBmZW5jZV90aW1lbGluZV9kZXN0cm95IC0gZGVz dHJveSBhIGZlbmNlX3RpbWVsaW5lCiAgKiBAdGltZWxpbmUJW2luXQl0aGUgZmVuY2VfdGltZWxp bmUgdG8gZGVzdHJveQogICoKLSAqIFRoaXMgZnVuY3Rpb24gZGVzdHJveXMgYSB0aW1lbGluZS4g SXQgc2lnbmFscyBhbnkgYWN0aXZlIGZlbmNlIGZpcnN0LgorICogVGhpcyBmdW5jdGlvbiBkZXN0 cm95cyBhIHRpbWVsaW5lLgogICovCiB2b2lkIGZlbmNlX3RpbWVsaW5lX2Rlc3Ryb3koc3RydWN0 IGZlbmNlX3RpbWVsaW5lICp0aW1lbGluZSkKIHsKQEAgLTE0NywxMCArMTQ3LDYgQEAgdm9pZCBm ZW5jZV90aW1lbGluZV9kZXN0cm95KHN0cnVjdCBmZW5jZV90aW1lbGluZSAqdGltZWxpbmUpCiAJ ICovCiAJc21wX3dtYigpOwogCi0JLyoKLQkgKiBzaWduYWwgYW55IGNoaWxkcmVuIHRoYXQgdGhl aXIgcGFyZW50IGlzIGdvaW5nIGF3YXkuCi0JICovCi0JZmVuY2VfdGltZWxpbmVfc2lnbmFsKHRp bWVsaW5lLCAwKTsKIAlmZW5jZV90aW1lbGluZV9wdXQodGltZWxpbmUpOwogfQogRVhQT1JUX1NZ TUJPTChmZW5jZV90aW1lbGluZV9kZXN0cm95KTsKLS0gCjIuNS4wCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=