From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755490AbcAOPCQ (ORCPT ); Fri, 15 Jan 2016 10:02:16 -0500 Received: from mail-yk0-f171.google.com ([209.85.160.171]:35765 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754177AbcAOO4O (ORCPT ); Fri, 15 Jan 2016 09:56:14 -0500 From: Gustavo Padovan To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan Subject: [RFC 08/29] staging/android: Remove WARN_ON_ONCE when releasing sync_fence Date: Fri, 15 Jan 2016 12:55:18 -0200 Message-Id: <1452869739-3304-9-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1452869739-3304-1-git-send-email-gustavo@padovan.org> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo Padovan There isn't any problem on removing the sync_pts from the active_list when the fence is released. If the user decides to close the fence before it is signaled we should do it and not warn about anything. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index 5028847..273aa4b 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sync.c @@ -432,8 +432,9 @@ static void sync_fence_release(struct fence *fence) spin_lock_irqsave(fence->lock, flags); list_del(&pt->child_list); - if (WARN_ON_ONCE(!list_empty(&pt->active_list))) + if (!list_empty(&pt->active_list)) list_del(&pt->active_list); + spin_unlock_irqrestore(fence->lock, flags); sync_timeline_put(parent); -- 2.5.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: [RFC 08/29] staging/android: Remove WARN_ON_ONCE when releasing sync_fence Date: Fri, 15 Jan 2016 12:55:18 -0200 Message-ID: <1452869739-3304-9-git-send-email-gustavo@padovan.org> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f177.google.com (mail-yk0-f177.google.com [209.85.160.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C9DE7A0E4 for ; Fri, 15 Jan 2016 06:56:14 -0800 (PST) Received: by mail-yk0-f177.google.com with SMTP id k129so522504865yke.0 for ; Fri, 15 Jan 2016 06:56:14 -0800 (PST) In-Reply-To: <1452869739-3304-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, daniels@collabora.com, Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Maarten Lankhorst , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org RnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgoK VGhlcmUgaXNuJ3QgYW55IHByb2JsZW0gb24gcmVtb3ZpbmcgdGhlIHN5bmNfcHRzIGZyb20gdGhl IGFjdGl2ZV9saXN0CndoZW4gdGhlIGZlbmNlIGlzIHJlbGVhc2VkLiBJZiB0aGUgdXNlciBkZWNp ZGVzIHRvIGNsb3NlIHRoZSBmZW5jZSBiZWZvcmUKaXQgaXMgc2lnbmFsZWQgd2Ugc2hvdWxkIGRv IGl0IGFuZCBub3Qgd2FybiBhYm91dCBhbnl0aGluZy4KClNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8g UGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KLS0tCiBkcml2ZXJzL3N0 YWdpbmcvYW5kcm9pZC9zeW5jLmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9hbmRyb2lk L3N5bmMuYyBiL2RyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL3N5bmMuYwppbmRleCA1MDI4ODQ3Li4y NzNhYTRiIDEwMDY0NAotLS0gYS9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9zeW5jLmMKKysrIGIv ZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvc3luYy5jCkBAIC00MzIsOCArNDMyLDkgQEAgc3RhdGlj IHZvaWQgc3luY19mZW5jZV9yZWxlYXNlKHN0cnVjdCBmZW5jZSAqZmVuY2UpCiAKIAlzcGluX2xv Y2tfaXJxc2F2ZShmZW5jZS0+bG9jaywgZmxhZ3MpOwogCWxpc3RfZGVsKCZwdC0+Y2hpbGRfbGlz dCk7Ci0JaWYgKFdBUk5fT05fT05DRSghbGlzdF9lbXB0eSgmcHQtPmFjdGl2ZV9saXN0KSkpCisJ aWYgKCFsaXN0X2VtcHR5KCZwdC0+YWN0aXZlX2xpc3QpKQogCQlsaXN0X2RlbCgmcHQtPmFjdGl2 ZV9saXN0KTsKKwogCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoZmVuY2UtPmxvY2ssIGZsYWdzKTsK IAogCXN5bmNfdGltZWxpbmVfcHV0KHBhcmVudCk7Ci0tIAoyLjUuMAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK