From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7O6-0007ne-PD for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK7O0-0004O0-DS for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:38:10 -0500 Received: from roura.ac.upc.es ([147.83.33.10]:58095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7O0-0004Nr-0V for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:38:04 -0500 From: =?utf-8?b?TGx1w61z?= Vilanova Date: Fri, 15 Jan 2016 17:38:03 +0100 Message-Id: <145287588263.11400.18229633914747740629.stgit@localhost> In-Reply-To: <145287587081.11400.4178335509020334684.stgit@localhost> References: <145287587081.11400.4178335509020334684.stgit@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v4 2/9] trace: Add 'vcpu' event property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Eduardo Habkost , Stefan Hajnoczi This property identifies events that trace vCPU-specific information. It adds a "CPUState*" argument to events with the property, identifying the vCPU raising the event. TCG translation events also have a "TCGv_cpu" implicit argument that is later used as the "CPUState*" argument at execution time. Signed-off-by: Llu=C3=ADs Vilanova --- docs/tracing.txt | 40 ++++++++++++++++++++++++= ++++++ scripts/tracetool/__init__.py | 24 +++++++++++++++++- scripts/tracetool/format/h.py | 3 ++ scripts/tracetool/format/tcg_h.py | 13 ++++++++-- scripts/tracetool/format/ust_events_c.py | 1 + 5 files changed, 75 insertions(+), 6 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 3853a6a..ade39e0 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -347,3 +347,43 @@ This will immediately call: and will generate the TCG code to call: =20 void trace_foo(uint8_t a1, uint32_t a2); + +=3D=3D=3D "vcpu" =3D=3D=3D + +Identifies events that trace vCPU-specific information. The property add= s a +"CPUState*" argument that identifies the vCPU raising the event. If used +together with the "tcg" property, it adds a second "TCGv_cpu" argument t= hat +identifies the vCPU when guest code is executed. + +The following example events: + + foo(uint32_t a) "a=3D%x" + vcpu bar(uint32_t a) "cpu=3D%p a=3D%x" + tcg vcpu baz(uint32_t a) "cpu=3D%p a=3D%x", "cpu=3D%p a=3D%x" + +Can be used as: + + #include "trace-tcg.h" + =20 + CPUArchState *env; + TCGv_ptr cpu_env; + =20 + void some_disassembly_func(...) + { + /* trace emitted at this point */ + trace_foo(0xd1); + /* trace emitted at this point */ + trace_bar(ENV_GET_CPU(env), 0xd2); + /* trace emitted at this point (env) and when guest code is exec= uted (cpu_env) */ + trace_baz_tcg(ENV_GET_CPU(env), cpu_env, 0xd3); + } + +If we assume code is translated by the vCPU with address 0xc1 and execut= ed by +the vCPU with address 0xc2, this would be an example output: + + // at guest code translation + foo a=3D0xd1 + bar cpu=3D0xc1 a=3D0xd2 + baz_trans cpu=3D0xc1 a=3D0xd3 + // at guest code execution + baz_exec cpu=3D0xc2 a=3D0xd3 diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.p= y index 181675f..41feb23 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -6,7 +6,7 @@ Machinery for generating tracing-related intermediate fil= es. """ =20 __author__ =3D "Llu=C3=ADs Vilanova " -__copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilanova " +__copyright__ =3D "Copyright 2012-2016, Llu=C3=ADs Vilanova " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" @@ -146,7 +146,7 @@ class Event(object): "(?:(?:(?P\".+),)?\s*(?P\".+))?" "\s*") =20 - _VALID_PROPS =3D set(["disable", "tcg", "tcg-trans", "tcg-exec"]) + _VALID_PROPS =3D set(["disable", "tcg", "tcg-trans", "tcg-exec", "vc= pu"]) =20 def __init__(self, name, props, fmt, args, orig=3DNone): """ @@ -215,6 +215,19 @@ class Event(object): if "tcg" in props and isinstance(fmt, str): raise ValueError("Events with 'tcg' property must have two f= ormats") =20 + # add implicit arguments when using the 'vcpu' property + if "vcpu" in props: + assert "tcg-trans" not in props and "tcg-exec" not in props + # events with 'tcg-trans' and 'tcg-exec' are auto-generated,= they + # have already been transformed + if "tcg" in props: + types =3D ["TCGv_cpu"] + args.types() + names =3D ["_tcg_cpu"] + args.names() + else: + types =3D ["CPUState *"] + args.types() + names =3D ["_cpu"] + args.names() + args =3D Arguments(zip(types, names)) + return Event(name, props, fmt, args) =20 def __repr__(self): @@ -270,6 +283,7 @@ def _read_events(fobj): event_trans.name +=3D "_trans" event_trans.properties +=3D ["tcg-trans"] event_trans.fmt =3D event.fmt[0] + # ignore TCG arguments args_trans =3D [] for atrans, aorig in zip( event_trans.transform(tracetool.transform.TCG_2_HOST= ).args, @@ -279,6 +293,12 @@ def _read_events(fobj): event_trans.args =3D Arguments(args_trans) event_trans =3D event_trans.copy() =20 + # trace the vCPU performing the translation + if "vcpu" in event_trans.properties: + event_trans.args =3D Arguments(zip( + ["CPUState *"] + list(event_trans.args.types()), + ["_cpu"] + list(event_trans.args.names()))) + event_exec =3D event.copy() event_exec.name +=3D "_exec" event_exec.properties +=3D ["tcg-exec"] diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.p= y index 9b39430..2bd68a2 100644 --- a/scripts/tracetool/format/h.py +++ b/scripts/tracetool/format/h.py @@ -6,7 +6,7 @@ trace/generated-tracers.h """ =20 __author__ =3D "Llu=C3=ADs Vilanova " -__copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilanova " +__copyright__ =3D "Copyright 2012-2016, Llu=C3=ADs Vilanova " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" @@ -23,6 +23,7 @@ def generate(events, backend): '#define TRACE__GENERATED_TRACERS_H', '', '#include "qemu-common.h"', + '#include "qemu/typedefs.h"', '') =20 backend.generate_begin(events) diff --git a/scripts/tracetool/format/tcg_h.py b/scripts/tracetool/format= /tcg_h.py index f676b66..acaa963 100644 --- a/scripts/tracetool/format/tcg_h.py +++ b/scripts/tracetool/format/tcg_h.py @@ -6,14 +6,14 @@ Generate .h file for TCG code generation. """ =20 __author__ =3D "Llu=C3=ADs Vilanova " -__copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilanova " +__copyright__ =3D "Copyright 2012-2016, Llu=C3=ADs Vilanova " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" __email__ =3D "stefanha@linux.vnet.ibm.com" =20 =20 -from tracetool import out +from tracetool import out, Arguments =20 =20 def generate(events, backend): @@ -38,10 +38,17 @@ def generate(events, backend): # get the original event definition e =3D e.original.original =20 + if "vcpu" in e.properties: + args_api =3D Arguments(zip( + ["CPUState *"] + e.args.types(), + ["_cpu"] + e.args.names())) + else: + args_api =3D e.args + out('static inline void %(name_tcg)s(%(args)s)', '{', name_tcg=3De.api(e.QEMU_TRACE_TCG), - args=3De.args) + args=3Dargs_api) =20 if "disable" not in e.properties: out(' %(name_trans)s(%(argnames_trans)s);', diff --git a/scripts/tracetool/format/ust_events_c.py b/scripts/tracetool= /format/ust_events_c.py index bc97093..ecb1f23 100644 --- a/scripts/tracetool/format/ust_events_c.py +++ b/scripts/tracetool/format/ust_events_c.py @@ -30,4 +30,5 @@ def generate(events, backend): ' */', '#pragma GCC diagnostic ignored "-Wredundant-decls"', '', + '#include "qemu/typedefs.h"', '#include "generated-ust-provider.h"')