* [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables
@ 2016-01-17 9:03 Álvaro Fernández Rojas
2016-01-18 19:08 ` Florian Fainelli
2016-01-25 14:49 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Álvaro Fernández Rojas @ 2016-01-17 9:03 UTC (permalink / raw)
To: linux-crypto, herbert, linux-kernel, devicetree, f.fainelli,
jogo, cernekee
Cc: Álvaro Fernández Rojas
These variables where left as unused in commit 6229c16060fe
("hwrng: bcm63xx - make use of devm_hwrng_register")
Fixes the following warning:
drivers/char/hw_random/bcm63xx-rng.c: In function 'bcm63xx_rng_probe':
drivers/char/hw_random/bcm63xx-rng.c:85:16: warning: unused variable 'rng'
[-Wunused-variable]
struct hwrng *rng;
^
drivers/char/hw_random/bcm63xx-rng.c:82:14: warning: unused variable 'clk'
[-Wunused-variable]
struct clk *clk;
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/char/hw_random/bcm63xx-rng.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
index 4b31f13..c303f30 100644
--- a/drivers/char/hw_random/bcm63xx-rng.c
+++ b/drivers/char/hw_random/bcm63xx-rng.c
@@ -79,10 +79,8 @@ static int bcm63xx_rng_data_read(struct hwrng *rng, u32 *data)
static int bcm63xx_rng_probe(struct platform_device *pdev)
{
struct resource *r;
- struct clk *clk;
int ret;
struct bcm63xx_rng_priv *priv;
- struct hwrng *rng;
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!r) {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables
2016-01-17 9:03 [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables Álvaro Fernández Rojas
@ 2016-01-18 19:08 ` Florian Fainelli
2016-01-25 14:49 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2016-01-18 19:08 UTC (permalink / raw)
To: Álvaro Fernández Rojas, linux-crypto, herbert,
linux-kernel, devicetree, jogo, cernekee
Le 17/01/2016 01:03, Álvaro Fernández Rojas a écrit :
> These variables where left as unused in commit 6229c16060fe
> ("hwrng: bcm63xx - make use of devm_hwrng_register")
>
> Fixes the following warning:
> drivers/char/hw_random/bcm63xx-rng.c: In function 'bcm63xx_rng_probe':
> drivers/char/hw_random/bcm63xx-rng.c:85:16: warning: unused variable 'rng'
> [-Wunused-variable]
> struct hwrng *rng;
> ^
> drivers/char/hw_random/bcm63xx-rng.c:82:14: warning: unused variable 'clk'
> [-Wunused-variable]
> struct clk *clk;
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables
2016-01-17 9:03 [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables Álvaro Fernández Rojas
2016-01-18 19:08 ` Florian Fainelli
@ 2016-01-25 14:49 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2016-01-25 14:49 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: linux-crypto, linux-kernel, devicetree, f.fainelli, jogo, cernekee
On Sun, Jan 17, 2016 at 10:03:54AM +0100, Álvaro Fernández Rojas wrote:
> These variables where left as unused in commit 6229c16060fe
> ("hwrng: bcm63xx - make use of devm_hwrng_register")
>
> Fixes the following warning:
> drivers/char/hw_random/bcm63xx-rng.c: In function 'bcm63xx_rng_probe':
> drivers/char/hw_random/bcm63xx-rng.c:85:16: warning: unused variable 'rng'
> [-Wunused-variable]
> struct hwrng *rng;
> ^
> drivers/char/hw_random/bcm63xx-rng.c:82:14: warning: unused variable 'clk'
> [-Wunused-variable]
> struct clk *clk;
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
All applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-25 14:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-17 9:03 [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables Álvaro Fernández Rojas
2016-01-18 19:08 ` Florian Fainelli
2016-01-25 14:49 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.