* [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue
@ 2016-01-17 9:50 Tapan Prakash T
2016-01-17 11:37 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Tapan Prakash T @ 2016-01-17 9:50 UTC (permalink / raw)
To: mdharm-usb; +Cc: linux-usb, linux-kernel, Tapan Prakash T
Fixed two coding style issue.
Signed-off-by: Tapan Prakash T <tapanprakasht@gmail.com>
---
drivers/usb/storage/onetouch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c
index acc3d03..9097bd4 100644
--- a/drivers/usb/storage/onetouch.c
+++ b/drivers/usb/storage/onetouch.c
@@ -69,7 +69,7 @@ struct usb_onetouch {
vendorName, productName, useProtocol, useTransport, \
initFunction, flags) \
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
- .driver_info = (flags) }
+.driver_info = (flags) }
static struct usb_device_id onetouch_usb_ids[] = {
# include "unusual_onetouch.h"
@@ -125,7 +125,7 @@ static void usb_onetouch_irq(struct urb *urb)
input_sync(dev);
resubmit:
- retval = usb_submit_urb (urb, GFP_ATOMIC);
+ retval = usb_submit_urb(urb, GFP_ATOMIC);
if (retval)
dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, "
"retval %d\n", onetouch->udev->bus->bus_name,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue
2016-01-17 9:50 [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue Tapan Prakash T
@ 2016-01-17 11:37 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-01-17 11:37 UTC (permalink / raw)
To: Tapan Prakash T, mdharm-usb; +Cc: linux-usb, linux-kernel
On Sun, 2016-01-17 at 15:20 +0530, Tapan Prakash T wrote:
> Fixed two coding style issue.
Your email subject is not correct.
This driver is not in staging and there's
a trivial typo in parenthesis.
> diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c
[]
> @@ -69,7 +69,7 @@ struct usb_onetouch {
> vendorName, productName, useProtocol, useTransport, \
> initFunction, flags) \
> { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
> - .driver_info = (flags) }
> +.driver_info = (flags) }
A more typical style would have been to change
the space to a tab before .driver_info
> static struct usb_device_id onetouch_usb_ids[] = {
> # include "unusual_onetouch.h"
> @@ -125,7 +125,7 @@ static void usb_onetouch_irq(struct urb *urb)
> input_sync(dev);
>
> resubmit:
> - retval = usb_submit_urb (urb, GFP_ATOMIC);
> + retval = usb_submit_urb(urb, GFP_ATOMIC);
> if (retval)
> dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, "
> "retval %d\n", onetouch->udev->bus->bus_name,
And to coalesce the format string
dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, retval %d\n",
onetouch->udev->bus->bus_name,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-17 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-17 9:50 [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue Tapan Prakash T
2016-01-17 11:37 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.