All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: kvalo@codeaurora.org, libertas-dev@lists.infradead.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	hns@goldelico.com
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH RFC] wireless:libertas: enable auto deep sleep
Date: Wed, 20 Jan 2016 08:41:49 +0100	[thread overview]
Message-ID: <1453275709-25276-1-git-send-email-andreas@kemnade.info> (raw)

Enables auto deep sleep whenever the interface is up and
power managament is enabled, so there is also power management
when there is no connection
That reduces power consumption between scanning
intervals. Deep sleep mode is entered when there is
no activity for 1s.

The code looks a bit different to how things were done
with the wext interface in earlier times.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/net/wireless/libertas/cfg.c  |  3 +++
 drivers/net/wireless/libertas/main.c | 12 +++++++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
index fd18d03..bb6d8fd 100644
--- a/drivers/net/wireless/libertas/cfg.c
+++ b/drivers/net/wireless/libertas/cfg.c
@@ -2066,6 +2066,7 @@ int lbs_set_power_mgmt(struct wiphy *wiphy, struct net_device *dev,
 			lbs_set_ps_mode(priv,
 					PS_MODE_ACTION_EXIT_PS,
 					true);
+		lbs_exit_auto_deep_sleep(priv);
 		return 0;
 	}
 	if (priv->psmode != LBS802_11POWERMODECAM)
@@ -2073,6 +2074,8 @@ int lbs_set_power_mgmt(struct wiphy *wiphy, struct net_device *dev,
 	priv->psmode = LBS802_11POWERMODEMAX_PSP;
 	if (priv->connect_status == LBS_CONNECTED)
 		lbs_set_ps_mode(priv, PS_MODE_ACTION_ENTER_PS, true);
+	priv->auto_deep_sleep_timeout = 1000; /* 1000ms */
+	lbs_enter_auto_deep_sleep(priv);
 	return 0;
 }
 
diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c
index b35b8bc..82e69ca 100644
--- a/drivers/net/wireless/libertas/main.c
+++ b/drivers/net/wireless/libertas/main.c
@@ -161,6 +161,11 @@ int lbs_start_iface(struct lbs_private *priv)
 	lbs_update_channel(priv);
 
 	priv->iface_running = true;
+	/* if deep sleep was enabled before
+	 * the interface was brought down, reenable it
+	 */
+	if (priv->is_auto_deep_sleep_enabled)
+		lbs_enter_auto_deep_sleep(priv);
 	return 0;
 
 err:
@@ -227,6 +232,10 @@ int lbs_stop_iface(struct lbs_private *priv)
 
 	cancel_work_sync(&priv->mcast_work);
 	del_timer_sync(&priv->tx_lockup_timer);
+	/* autosleep should not mess with commands
+	 * when the interface is powered down
+	 */
+	del_timer_sync(&priv->auto_deepsleep_timer);
 
 	/* Disable command processing, and wait for all commands to complete */
 	lbs_deb_main("waiting for commands to complete\n");
@@ -824,7 +833,8 @@ static void auto_deepsleep_timer_fn(unsigned long data)
 	} else {
 		if (priv->is_auto_deep_sleep_enabled &&
 		    (!priv->wakeup_dev_required) &&
-		    (priv->connect_status != LBS_CONNECTED)) {
+		    (priv->connect_status != LBS_CONNECTED) &&
+		    priv->iface_running) {
 			struct cmd_header cmd;
 
 			lbs_deb_main("Entering auto deep sleep mode...\n");
-- 
2.1.4


             reply	other threads:[~2016-01-20  7:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20  7:41 Andreas Kemnade [this message]
2016-01-20 12:42 ` [PATCH RFC] wireless:libertas: enable auto deep sleep Kalle Valo
2016-01-20 16:43   ` Andreas Kemnade
2016-01-20 17:55     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453275709-25276-1-git-send-email-andreas@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=hns@goldelico.com \
    --cc=kvalo@codeaurora.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.