* ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-20 12:35 ` Lothar Waßmann
0 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: Alexandre Belloni, Ian Campbell,
Jean-Christophe Plagniol-Villard, Kumar Gala, Mark Rutland,
Nicolas Ferre, Pawel Moll, Rob Herring, Russell King, devicetree,
linux-arm-kernel, linux-kernel
This patchset adds support for the Ka-Ro electronics TXA5 modules.
The first patch is a cleanup patch without functional changes.
The second patch adds some labels to DTS nodes which are used in the
third patch.
ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
^ permalink raw reply [flat|nested] 26+ messages in thread
* ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-20 12:35 ` Lothar Waßmann
0 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: linux-arm-kernel
This patchset adds support for the Ka-Ro electronics TXA5 modules.
The first patch is a cleanup patch without functional changes.
The second patch adds some labels to DTS nodes which are used in the
third patch.
ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
2016-01-20 12:35 ` Lothar Waßmann
@ 2016-01-20 12:35 ` Lothar Waßmann
-1 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: Alexandre Belloni, Ian Campbell,
Jean-Christophe Plagniol-Villard, Kumar Gala, Mark Rutland,
Nicolas Ferre, Pawel Moll, Rob Herring, Russell King, devicetree,
linux-arm-kernel, linux-kernel
Cc: Lothar Waßmann
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index b8032bc..6c0dc89 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi
@@ -1428,22 +1428,27 @@
atmel,pins =
<AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
};
+
pinctrl_adc0_ad0: adc0_ad0 {
atmel,pins =
<AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad1: adc0_ad1 {
atmel,pins =
<AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad2: adc0_ad2 {
atmel,pins =
<AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad3: adc0_ad3 {
atmel,pins =
<AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad4: adc0_ad4 {
atmel,pins =
<AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
@@ -1497,11 +1502,13 @@
AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
};
+
pinctrl_isi_data_8_9: isi-0-data-8-9 {
atmel,pins =
<AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
};
+
pinctrl_isi_data_10_11: isi-0-data-10-11 {
atmel,pins =
<AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
@@ -1517,9 +1524,11 @@
AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
};
+
pinctrl_lcd_pwm: lcd-pwm-0 {
atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
};
+
pinctrl_lcd_rgb444: lcd-rgb-0 {
atmel,pins =
<AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
@@ -1535,6 +1544,7 @@
AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
};
+
pinctrl_lcd_rgb565: lcd-rgb-1 {
atmel,pins =
<AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
@@ -1554,6 +1564,7 @@
AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
};
+
pinctrl_lcd_rgb666: lcd-rgb-2 {
atmel,pins =
<AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
@@ -1575,6 +1586,7 @@
AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
};
+
pinctrl_lcd_rgb777: lcd-rgb-3 {
atmel,pins =
/* LCDDAT0 conflicts with TMS */
@@ -1602,6 +1614,7 @@
AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
};
+
pinctrl_lcd_rgb888: lcd-rgb-4 {
atmel,pins =
<AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
--
2.1.4
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
@ 2016-01-20 12:35 ` Lothar Waßmann
0 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index b8032bc..6c0dc89 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi
@@ -1428,22 +1428,27 @@
atmel,pins =
<AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
};
+
pinctrl_adc0_ad0: adc0_ad0 {
atmel,pins =
<AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad1: adc0_ad1 {
atmel,pins =
<AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad2: adc0_ad2 {
atmel,pins =
<AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad3: adc0_ad3 {
atmel,pins =
<AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
};
+
pinctrl_adc0_ad4: adc0_ad4 {
atmel,pins =
<AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
@@ -1497,11 +1502,13 @@
AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
};
+
pinctrl_isi_data_8_9: isi-0-data-8-9 {
atmel,pins =
<AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
};
+
pinctrl_isi_data_10_11: isi-0-data-10-11 {
atmel,pins =
<AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
@@ -1517,9 +1524,11 @@
AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
};
+
pinctrl_lcd_pwm: lcd-pwm-0 {
atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
};
+
pinctrl_lcd_rgb444: lcd-rgb-0 {
atmel,pins =
<AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
@@ -1535,6 +1544,7 @@
AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
};
+
pinctrl_lcd_rgb565: lcd-rgb-1 {
atmel,pins =
<AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
@@ -1554,6 +1564,7 @@
AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
};
+
pinctrl_lcd_rgb666: lcd-rgb-2 {
atmel,pins =
<AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
@@ -1575,6 +1586,7 @@
AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
};
+
pinctrl_lcd_rgb777: lcd-rgb-3 {
atmel,pins =
/* LCDDAT0 conflicts with TMS */
@@ -1602,6 +1614,7 @@
AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
};
+
pinctrl_lcd_rgb888: lcd-rgb-4 {
atmel,pins =
<AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
--
2.1.4
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
2016-01-20 12:35 ` Lothar Waßmann
@ 2016-01-20 12:35 ` Lothar Waßmann
-1 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: Alexandre Belloni, Ian Campbell,
Jean-Christophe Plagniol-Villard, Kumar Gala, Mark Rutland,
Nicolas Ferre, Pawel Moll, Rob Herring, Russell King, devicetree,
linux-arm-kernel, linux-kernel
Cc: Lothar Waßmann
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index 6c0dc89..fb40014 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi
@@ -1299,7 +1299,7 @@
clocks = <&h32ck>;
};
- watchdog@fc068640 {
+ watchdog: watchdog@fc068640 {
compatible = "atmel,sama5d4-wdt";
reg = <0xfc068640 0x10>;
clocks = <&clk32k>;
@@ -1351,7 +1351,7 @@
};
- pinctrl@fc06a000 {
+ pinctrl: pinctrl@fc06a000 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
--
2.1.4
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
@ 2016-01-20 12:35 ` Lothar Waßmann
0 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index 6c0dc89..fb40014 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi
@@ -1299,7 +1299,7 @@
clocks = <&h32ck>;
};
- watchdog at fc068640 {
+ watchdog: watchdog at fc068640 {
compatible = "atmel,sama5d4-wdt";
reg = <0xfc068640 0x10>;
clocks = <&clk32k>;
@@ -1351,7 +1351,7 @@
};
- pinctrl at fc06a000 {
+ pinctrl: pinctrl at fc06a000 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
--
2.1.4
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
2016-01-20 12:35 ` Lothar Waßmann
@ 2016-01-20 12:35 ` Lothar Waßmann
-1 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: Alexandre Belloni, Ian Campbell,
Jean-Christophe Plagniol-Villard, Kumar Gala, Mark Rutland,
Nicolas Ferre, Pawel Moll, Rob Herring, Russell King, devicetree,
linux-arm-kernel, linux-kernel
Cc: Lothar Waßmann
The TXA5-5010/-5011 are Computers On Module manufactured by
Ka-Ro electronics GmbH with the following characteristics:
Processor Atmel SAMA5D42, 528 MHz
RAM 256MB 32-bit DDR2 SDRAM
ROM 128MB NAND Flash (TXA5-5010) / 4GB eMMC (TXA5-5011)
Power supply Single 3.1V to 5.5V
Size 26mm SO-DIMM
Temp. Range -40°C/-25°C to 85°C
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts | 217 +++++++++++++++++++++++++++
2 files changed, 218 insertions(+)
create mode 100644 arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a4a6d70..8fbc0cb 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -49,6 +49,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
sama5d35ek.dtb \
sama5d36ek.dtb \
at91-sama5d4_ma5d4evk.dtb \
+ at91-sama5d4-txa5-5010.dtb \
at91-sama5d4_xplained.dtb \
at91-sama5d4ek.dtb \
at91-vinco.dtb
diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
new file mode 100644
index 0000000..fb4a253
--- /dev/null
+++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
@@ -0,0 +1,217 @@
+/*
+ * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
+ *
+ * Copyright (C) 2015 Lothar Waßmann <LW@KARO-electronics.de>
+ * based on: at91-sama5d4_xplained.dts
+ * Copyright (C) 2015 Atmel,
+ * 2015 Josh Wu <josh.wu@atmel.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+#include "sama5d4.dtsi"
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pwm/pwm.h>
+
+/ {
+ model = "Ka-Ro SAMA5D4 TXA5";
+ compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
+
+ aliases {
+ display = &display;
+ ethernet0 = &macb0;
+ serial0 = &usart0;
+ serial1 = &usart1;
+ serial2 = &usart3;
+ spi0 = &spi0;
+ };
+
+ clocks {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ main_clock: clock@0 {
+ compatible = "atmel,osc", "fixed-clock";
+ clock-frequency = <12000000>;
+ };
+ };
+
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&hlcdc_pwm 0 500000 PWM_POLARITY_INVERTED>;
+ };
+
+ display: display {
+ display-timings {
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ status = "okay";
+
+ heartbeat {
+ label = "heartbeat";
+ gpios = <&pioD 29 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
+
+&adc0 {
+ atmel,adc-vref = <3300>;
+ status = "okay";
+};
+
+&hlcdc {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_lcd_rgb888>;
+ status = "okay";
+};
+
+&i2c1 {
+ status = "okay";
+};
+
+&macb0 {
+ phy-mode = "rmii";
+ status = "okay";
+
+ phy0: ethernet-phy@1 {
+ interrupt-parent = <&pioE>;
+ interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+ reg = <1>;
+ };
+};
+
+&main_xtal {
+ clock-frequency = <12000000>;
+};
+
+&mmc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_mmc1_clk_cmd_dat0 &pinctrl_mmc1_dat1_3 &pinctrl_mmc1_cd>;
+ status = "okay";
+ slot@0 {
+ reg = <0>;
+ bus-width = <4>;
+ cd-gpios = <&pioE 3 0>;
+ };
+};
+
+&nand0 {
+ nand-bus-width = <8>;
+ nand-ecc-mode = "hw";
+ nand-on-flash-bbt;
+ atmel,has-pmecc;
+ status = "okay";
+};
+
+&pinctrl {
+ sama5d4-txa5 {
+ pinctrl_mmc1_cd: mmc1-cd {
+ atmel,pins = <AT91_PIOE 6 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+ };
+
+ pinctrl_spi0_cs: spi0 {
+ atmel,pins = <
+ AT91_PIOB 21 AT91_PERIPH_GPIO 0 /* CSPI_SS0 */
+ AT91_PIOB 22 AT91_PERIPH_GPIO 0 /* CSPI_SS1 */
+ AT91_PIOB 23 AT91_PERIPH_GPIO 0 /* CSPI_RDY */
+ >;
+ };
+
+ pinctrl_usba_vbus: usba-vbus {
+ atmel,pins = <
+ AT91_PIOE 10 AT91_PERIPH_GPIO 0 /* USBOTG_VBUSEN */
+ AT91_PIOD 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBOTG_OC */
+ >;
+ };
+
+ pinctrl_usbb_vbus: usbb-vbus {
+ atmel,pins = <
+ AT91_PIOE 11 AT91_PERIPH_GPIO 0 /* USBH_VBUSEN */
+ AT91_PIOD 9 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBH_OC */
+ >;
+ };
+ };
+};
+
+&slow_xtal {
+ clock-frequency = <32768>;
+};
+
+&spi0 {
+ cs-gpios = <&pioB 21 0>, <&pioB 22 0>, <0>, <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_spi0 &pinctrl_spi0_cs>;
+ status = "okay";
+};
+
+&usart0 {
+ status = "okay";
+};
+
+&usart1 {
+ status = "okay";
+};
+
+&usart3 {
+ status = "okay";
+};
+
+&usb0 {
+ atmel,vbus-gpio = <&pioE 10 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usba_vbus>;
+ status = "okay";
+};
+
+&usb1 {
+ num-ports = <1>;
+ atmel,vbus-gpio = <&pioE 11 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbb_vbus>;
+ status = "okay";
+};
+
+&watchdog {
+ status = "okay";
+};
--
2.1.4
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-20 12:35 ` Lothar Waßmann
0 siblings, 0 replies; 26+ messages in thread
From: Lothar Waßmann @ 2016-01-20 12:35 UTC (permalink / raw)
To: linux-arm-kernel
The TXA5-5010/-5011 are Computers On Module manufactured by
Ka-Ro electronics GmbH with the following characteristics:
Processor Atmel SAMA5D42, 528 MHz
RAM 256MB 32-bit DDR2 SDRAM
ROM 128MB NAND Flash (TXA5-5010) / 4GB eMMC (TXA5-5011)
Power supply Single 3.1V to 5.5V
Size 26mm SO-DIMM
Temp. Range -40?C/-25?C to 85?C
Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts | 217 +++++++++++++++++++++++++++
2 files changed, 218 insertions(+)
create mode 100644 arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a4a6d70..8fbc0cb 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -49,6 +49,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
sama5d35ek.dtb \
sama5d36ek.dtb \
at91-sama5d4_ma5d4evk.dtb \
+ at91-sama5d4-txa5-5010.dtb \
at91-sama5d4_xplained.dtb \
at91-sama5d4ek.dtb \
at91-vinco.dtb
diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
new file mode 100644
index 0000000..fb4a253
--- /dev/null
+++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
@@ -0,0 +1,217 @@
+/*
+ * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
+ *
+ * Copyright (C) 2015 Lothar Wa?mann <LW@KARO-electronics.de>
+ * based on: at91-sama5d4_xplained.dts
+ * Copyright (C) 2015 Atmel,
+ * 2015 Josh Wu <josh.wu@atmel.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+#include "sama5d4.dtsi"
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pwm/pwm.h>
+
+/ {
+ model = "Ka-Ro SAMA5D4 TXA5";
+ compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
+
+ aliases {
+ display = &display;
+ ethernet0 = &macb0;
+ serial0 = &usart0;
+ serial1 = &usart1;
+ serial2 = &usart3;
+ spi0 = &spi0;
+ };
+
+ clocks {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ main_clock: clock at 0 {
+ compatible = "atmel,osc", "fixed-clock";
+ clock-frequency = <12000000>;
+ };
+ };
+
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&hlcdc_pwm 0 500000 PWM_POLARITY_INVERTED>;
+ };
+
+ display: display {
+ display-timings {
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ status = "okay";
+
+ heartbeat {
+ label = "heartbeat";
+ gpios = <&pioD 29 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
+
+&adc0 {
+ atmel,adc-vref = <3300>;
+ status = "okay";
+};
+
+&hlcdc {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_lcd_rgb888>;
+ status = "okay";
+};
+
+&i2c1 {
+ status = "okay";
+};
+
+&macb0 {
+ phy-mode = "rmii";
+ status = "okay";
+
+ phy0: ethernet-phy at 1 {
+ interrupt-parent = <&pioE>;
+ interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+ reg = <1>;
+ };
+};
+
+&main_xtal {
+ clock-frequency = <12000000>;
+};
+
+&mmc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_mmc1_clk_cmd_dat0 &pinctrl_mmc1_dat1_3 &pinctrl_mmc1_cd>;
+ status = "okay";
+ slot at 0 {
+ reg = <0>;
+ bus-width = <4>;
+ cd-gpios = <&pioE 3 0>;
+ };
+};
+
+&nand0 {
+ nand-bus-width = <8>;
+ nand-ecc-mode = "hw";
+ nand-on-flash-bbt;
+ atmel,has-pmecc;
+ status = "okay";
+};
+
+&pinctrl {
+ sama5d4-txa5 {
+ pinctrl_mmc1_cd: mmc1-cd {
+ atmel,pins = <AT91_PIOE 6 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+ };
+
+ pinctrl_spi0_cs: spi0 {
+ atmel,pins = <
+ AT91_PIOB 21 AT91_PERIPH_GPIO 0 /* CSPI_SS0 */
+ AT91_PIOB 22 AT91_PERIPH_GPIO 0 /* CSPI_SS1 */
+ AT91_PIOB 23 AT91_PERIPH_GPIO 0 /* CSPI_RDY */
+ >;
+ };
+
+ pinctrl_usba_vbus: usba-vbus {
+ atmel,pins = <
+ AT91_PIOE 10 AT91_PERIPH_GPIO 0 /* USBOTG_VBUSEN */
+ AT91_PIOD 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBOTG_OC */
+ >;
+ };
+
+ pinctrl_usbb_vbus: usbb-vbus {
+ atmel,pins = <
+ AT91_PIOE 11 AT91_PERIPH_GPIO 0 /* USBH_VBUSEN */
+ AT91_PIOD 9 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBH_OC */
+ >;
+ };
+ };
+};
+
+&slow_xtal {
+ clock-frequency = <32768>;
+};
+
+&spi0 {
+ cs-gpios = <&pioB 21 0>, <&pioB 22 0>, <0>, <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_spi0 &pinctrl_spi0_cs>;
+ status = "okay";
+};
+
+&usart0 {
+ status = "okay";
+};
+
+&usart1 {
+ status = "okay";
+};
+
+&usart3 {
+ status = "okay";
+};
+
+&usb0 {
+ atmel,vbus-gpio = <&pioE 10 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usba_vbus>;
+ status = "okay";
+};
+
+&usb1 {
+ num-ports = <1>;
+ atmel,vbus-gpio = <&pioE 11 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbb_vbus>;
+ status = "okay";
+};
+
+&watchdog {
+ status = "okay";
+};
--
2.1.4
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
@ 2016-01-25 11:18 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:18 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Nicolas Ferre, Pawel Moll, Rob Herring,
Russell King, devicetree, linux-arm-kernel, linux-kernel
Hi,
On 20/01/2016 at 13:35:35 +0100, Lothar Waßmann wrote :
A commit message is mandatory even when small ;)
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
I'm not sure the added blank lines add any clarity to the fille but I
won't object. Maybe Nicolas as an opinion.
> ---
> arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index b8032bc..6c0dc89 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1428,22 +1428,27 @@
> atmel,pins =
> <AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
> };
> +
> pinctrl_adc0_ad0: adc0_ad0 {
> atmel,pins =
> <AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad1: adc0_ad1 {
> atmel,pins =
> <AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad2: adc0_ad2 {
> atmel,pins =
> <AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad3: adc0_ad3 {
> atmel,pins =
> <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad4: adc0_ad4 {
> atmel,pins =
> <AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> @@ -1497,11 +1502,13 @@
> AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
> AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
> };
> +
> pinctrl_isi_data_8_9: isi-0-data-8-9 {
> atmel,pins =
> <AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
> AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
> };
> +
> pinctrl_isi_data_10_11: isi-0-data-10-11 {
> atmel,pins =
> <AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
> @@ -1517,9 +1524,11 @@
> AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
> AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
> };
> +
> pinctrl_lcd_pwm: lcd-pwm-0 {
> atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
> };
> +
> pinctrl_lcd_rgb444: lcd-rgb-0 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> @@ -1535,6 +1544,7 @@
> AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
> AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
> };
> +
> pinctrl_lcd_rgb565: lcd-rgb-1 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> @@ -1554,6 +1564,7 @@
> AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
> AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
> };
> +
> pinctrl_lcd_rgb666: lcd-rgb-2 {
> atmel,pins =
> <AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
> @@ -1575,6 +1586,7 @@
> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
> };
> +
> pinctrl_lcd_rgb777: lcd-rgb-3 {
> atmel,pins =
> /* LCDDAT0 conflicts with TMS */
> @@ -1602,6 +1614,7 @@
> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
> };
> +
> pinctrl_lcd_rgb888: lcd-rgb-4 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
@ 2016-01-25 11:18 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:18 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Nicolas Ferre, Pawel Moll, Rob Herring,
Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi,
On 20/01/2016 at 13:35:35 +0100, Lothar Waßmann wrote :
A commit message is mandatory even when small ;)
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
I'm not sure the added blank lines add any clarity to the fille but I
won't object. Maybe Nicolas as an opinion.
> ---
> arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index b8032bc..6c0dc89 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1428,22 +1428,27 @@
> atmel,pins =
> <AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
> };
> +
> pinctrl_adc0_ad0: adc0_ad0 {
> atmel,pins =
> <AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad1: adc0_ad1 {
> atmel,pins =
> <AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad2: adc0_ad2 {
> atmel,pins =
> <AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad3: adc0_ad3 {
> atmel,pins =
> <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad4: adc0_ad4 {
> atmel,pins =
> <AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> @@ -1497,11 +1502,13 @@
> AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
> AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
> };
> +
> pinctrl_isi_data_8_9: isi-0-data-8-9 {
> atmel,pins =
> <AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
> AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
> };
> +
> pinctrl_isi_data_10_11: isi-0-data-10-11 {
> atmel,pins =
> <AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
> @@ -1517,9 +1524,11 @@
> AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
> AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
> };
> +
> pinctrl_lcd_pwm: lcd-pwm-0 {
> atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
> };
> +
> pinctrl_lcd_rgb444: lcd-rgb-0 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> @@ -1535,6 +1544,7 @@
> AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
> AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
> };
> +
> pinctrl_lcd_rgb565: lcd-rgb-1 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> @@ -1554,6 +1564,7 @@
> AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
> AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
> };
> +
> pinctrl_lcd_rgb666: lcd-rgb-2 {
> atmel,pins =
> <AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
> @@ -1575,6 +1586,7 @@
> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
> };
> +
> pinctrl_lcd_rgb777: lcd-rgb-3 {
> atmel,pins =
> /* LCDDAT0 conflicts with TMS */
> @@ -1602,6 +1614,7 @@
> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
> };
> +
> pinctrl_lcd_rgb888: lcd-rgb-4 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
@ 2016-01-25 11:18 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 20/01/2016 at 13:35:35 +0100, Lothar Wa?mann wrote :
A commit message is mandatory even when small ;)
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
I'm not sure the added blank lines add any clarity to the fille but I
won't object. Maybe Nicolas as an opinion.
> ---
> arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index b8032bc..6c0dc89 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1428,22 +1428,27 @@
> atmel,pins =
> <AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
> };
> +
> pinctrl_adc0_ad0: adc0_ad0 {
> atmel,pins =
> <AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad1: adc0_ad1 {
> atmel,pins =
> <AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad2: adc0_ad2 {
> atmel,pins =
> <AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad3: adc0_ad3 {
> atmel,pins =
> <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> };
> +
> pinctrl_adc0_ad4: adc0_ad4 {
> atmel,pins =
> <AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> @@ -1497,11 +1502,13 @@
> AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
> AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
> };
> +
> pinctrl_isi_data_8_9: isi-0-data-8-9 {
> atmel,pins =
> <AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
> AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
> };
> +
> pinctrl_isi_data_10_11: isi-0-data-10-11 {
> atmel,pins =
> <AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
> @@ -1517,9 +1524,11 @@
> AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
> AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
> };
> +
> pinctrl_lcd_pwm: lcd-pwm-0 {
> atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
> };
> +
> pinctrl_lcd_rgb444: lcd-rgb-0 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> @@ -1535,6 +1544,7 @@
> AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
> AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
> };
> +
> pinctrl_lcd_rgb565: lcd-rgb-1 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> @@ -1554,6 +1564,7 @@
> AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
> AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
> };
> +
> pinctrl_lcd_rgb666: lcd-rgb-2 {
> atmel,pins =
> <AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
> @@ -1575,6 +1586,7 @@
> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
> };
> +
> pinctrl_lcd_rgb777: lcd-rgb-3 {
> atmel,pins =
> /* LCDDAT0 conflicts with TMS */
> @@ -1602,6 +1614,7 @@
> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
> };
> +
> pinctrl_lcd_rgb888: lcd-rgb-4 {
> atmel,pins =
> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
@ 2016-01-25 11:19 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:19 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Nicolas Ferre, Pawel Moll, Rob Herring,
Russell King, devicetree, linux-arm-kernel, linux-kernel
Hi,
On 20/01/2016 at 13:35:36 +0100, Lothar Waßmann wrote :
Ditto, this needs a commit message.
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Else,
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index 6c0dc89..fb40014 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1299,7 +1299,7 @@
> clocks = <&h32ck>;
> };
>
> - watchdog@fc068640 {
> + watchdog: watchdog@fc068640 {
> compatible = "atmel,sama5d4-wdt";
> reg = <0xfc068640 0x10>;
> clocks = <&clk32k>;
> @@ -1351,7 +1351,7 @@
> };
>
>
> - pinctrl@fc06a000 {
> + pinctrl: pinctrl@fc06a000 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
@ 2016-01-25 11:19 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:19 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Nicolas Ferre, Pawel Moll, Rob Herring,
Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi,
On 20/01/2016 at 13:35:36 +0100, Lothar Waßmann wrote :
Ditto, this needs a commit message.
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
Else,
Acked-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index 6c0dc89..fb40014 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1299,7 +1299,7 @@
> clocks = <&h32ck>;
> };
>
> - watchdog@fc068640 {
> + watchdog: watchdog@fc068640 {
> compatible = "atmel,sama5d4-wdt";
> reg = <0xfc068640 0x10>;
> clocks = <&clk32k>;
> @@ -1351,7 +1351,7 @@
> };
>
>
> - pinctrl@fc06a000 {
> + pinctrl: pinctrl@fc06a000 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
@ 2016-01-25 11:19 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 20/01/2016 at 13:35:36 +0100, Lothar Wa?mann wrote :
Ditto, this needs a commit message.
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
Else,
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index 6c0dc89..fb40014 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1299,7 +1299,7 @@
> clocks = <&h32ck>;
> };
>
> - watchdog at fc068640 {
> + watchdog: watchdog at fc068640 {
> compatible = "atmel,sama5d4-wdt";
> reg = <0xfc068640 0x10>;
> clocks = <&clk32k>;
> @@ -1351,7 +1351,7 @@
> };
>
>
> - pinctrl at fc06a000 {
> + pinctrl: pinctrl at fc06a000 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-25 11:34 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:34 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Nicolas Ferre, Pawel Moll, Rob Herring,
Russell King, devicetree, linux-arm-kernel, linux-kernel
Hi,
On 20/01/2016 at 13:35:37 +0100, Lothar Waßmann wrote :
> diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> new file mode 100644
> index 0000000..fb4a253
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> @@ -0,0 +1,217 @@
> +/*
> + * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
> + *
This file can also be called at91-txa5-5010.dts if you prefer unless you
plan to have multiple variants of the board with different SoCs.
> +/dts-v1/;
> +#include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Ka-Ro SAMA5D4 TXA5";
> + compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
> +
The vendor for sama5d4-txa5 is not atmel, this should be
"karo,sama5d4-txa5".
Don't forget to add that vendor prefix in
Documentation/devicetree/bindings/vendor-prefixes.txt
> + aliases {
> + display = &display;
> + ethernet0 = &macb0;
> + serial0 = &usart0;
> + serial1 = &usart1;
> + serial2 = &usart3;
> + spi0 = &spi0;
> + };
> +
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
Those properties should be removed. You probably based yourself on a dts
for an old kernel.
> + main_clock: clock@0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
This node is useless, I think you can remove the whole clocks groups as
you define slow_xtal and main_xtal later.
> + display: display {
> + display-timings {
> + };
> + };
> +
Don't you need some timings?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-25 11:34 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:34 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Nicolas Ferre, Pawel Moll, Rob Herring,
Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi,
On 20/01/2016 at 13:35:37 +0100, Lothar Waßmann wrote :
> diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> new file mode 100644
> index 0000000..fb4a253
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> @@ -0,0 +1,217 @@
> +/*
> + * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
> + *
This file can also be called at91-txa5-5010.dts if you prefer unless you
plan to have multiple variants of the board with different SoCs.
> +/dts-v1/;
> +#include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Ka-Ro SAMA5D4 TXA5";
> + compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
> +
The vendor for sama5d4-txa5 is not atmel, this should be
"karo,sama5d4-txa5".
Don't forget to add that vendor prefix in
Documentation/devicetree/bindings/vendor-prefixes.txt
> + aliases {
> + display = &display;
> + ethernet0 = &macb0;
> + serial0 = &usart0;
> + serial1 = &usart1;
> + serial2 = &usart3;
> + spi0 = &spi0;
> + };
> +
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
Those properties should be removed. You probably based yourself on a dts
for an old kernel.
> + main_clock: clock@0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
This node is useless, I think you can remove the whole clocks groups as
you define slow_xtal and main_xtal later.
> + display: display {
> + display-timings {
> + };
> + };
> +
Don't you need some timings?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-25 11:34 ` Alexandre Belloni
0 siblings, 0 replies; 26+ messages in thread
From: Alexandre Belloni @ 2016-01-25 11:34 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 20/01/2016 at 13:35:37 +0100, Lothar Wa?mann wrote :
> diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> new file mode 100644
> index 0000000..fb4a253
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> @@ -0,0 +1,217 @@
> +/*
> + * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
> + *
This file can also be called at91-txa5-5010.dts if you prefer unless you
plan to have multiple variants of the board with different SoCs.
> +/dts-v1/;
> +#include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Ka-Ro SAMA5D4 TXA5";
> + compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
> +
The vendor for sama5d4-txa5 is not atmel, this should be
"karo,sama5d4-txa5".
Don't forget to add that vendor prefix in
Documentation/devicetree/bindings/vendor-prefixes.txt
> + aliases {
> + display = &display;
> + ethernet0 = &macb0;
> + serial0 = &usart0;
> + serial1 = &usart1;
> + serial2 = &usart3;
> + spi0 = &spi0;
> + };
> +
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
Those properties should be removed. You probably based yourself on a dts
for an old kernel.
> + main_clock: clock at 0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
This node is useless, I think you can remove the whole clocks groups as
you define slow_xtal and main_xtal later.
> + display: display {
> + display-timings {
> + };
> + };
> +
Don't you need some timings?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
@ 2016-01-25 13:35 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:35 UTC (permalink / raw)
To: Alexandre Belloni, Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Pawel Moll, Rob Herring, Russell King, devicetree,
linux-arm-kernel, linux-kernel
Le 25/01/2016 12:18, Alexandre Belloni a écrit :
> Hi,
>
> On 20/01/2016 at 13:35:35 +0100, Lothar Waßmann wrote :
>
> A commit message is mandatory even when small ;)
>
>> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
>
> I'm not sure the added blank lines add any clarity to the fille but I
> won't object. Maybe Nicolas as an opinion.
Well, I don't think it brings more coherency to the .dtsi. For example
some trigger definitions nodes don't have the blank line neither. Other
products .dtsi are the same.
As it may cause merging issues without real gain, I'm sorry but it's a
NACK for me.
Bye,
>> ---
>> arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index b8032bc..6c0dc89 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -1428,22 +1428,27 @@
>> atmel,pins =
>> <AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
>> };
>> +
>> pinctrl_adc0_ad0: adc0_ad0 {
>> atmel,pins =
>> <AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad1: adc0_ad1 {
>> atmel,pins =
>> <AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad2: adc0_ad2 {
>> atmel,pins =
>> <AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad3: adc0_ad3 {
>> atmel,pins =
>> <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad4: adc0_ad4 {
>> atmel,pins =
>> <AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> @@ -1497,11 +1502,13 @@
>> AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
>> AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
>> };
>> +
>> pinctrl_isi_data_8_9: isi-0-data-8-9 {
>> atmel,pins =
>> <AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
>> AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
>> };
>> +
>> pinctrl_isi_data_10_11: isi-0-data-10-11 {
>> atmel,pins =
>> <AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
>> @@ -1517,9 +1524,11 @@
>> AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
>> AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
>> };
>> +
>> pinctrl_lcd_pwm: lcd-pwm-0 {
>> atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
>> };
>> +
>> pinctrl_lcd_rgb444: lcd-rgb-0 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> @@ -1535,6 +1544,7 @@
>> AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
>> AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
>> };
>> +
>> pinctrl_lcd_rgb565: lcd-rgb-1 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> @@ -1554,6 +1564,7 @@
>> AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
>> AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
>> };
>> +
>> pinctrl_lcd_rgb666: lcd-rgb-2 {
>> atmel,pins =
>> <AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
>> @@ -1575,6 +1586,7 @@
>> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
>> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
>> };
>> +
>> pinctrl_lcd_rgb777: lcd-rgb-3 {
>> atmel,pins =
>> /* LCDDAT0 conflicts with TMS */
>> @@ -1602,6 +1614,7 @@
>> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
>> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
>> };
>> +
>> pinctrl_lcd_rgb888: lcd-rgb-4 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> --
>> 2.1.4
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
@ 2016-01-25 13:35 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:35 UTC (permalink / raw)
To: Alexandre Belloni, Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Pawel Moll, Rob Herring, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Le 25/01/2016 12:18, Alexandre Belloni a écrit :
> Hi,
>
> On 20/01/2016 at 13:35:35 +0100, Lothar Waßmann wrote :
>
> A commit message is mandatory even when small ;)
>
>> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
>
> I'm not sure the added blank lines add any clarity to the fille but I
> won't object. Maybe Nicolas as an opinion.
Well, I don't think it brings more coherency to the .dtsi. For example
some trigger definitions nodes don't have the blank line neither. Other
products .dtsi are the same.
As it may cause merging issues without real gain, I'm sorry but it's a
NACK for me.
Bye,
>> ---
>> arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index b8032bc..6c0dc89 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -1428,22 +1428,27 @@
>> atmel,pins =
>> <AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
>> };
>> +
>> pinctrl_adc0_ad0: adc0_ad0 {
>> atmel,pins =
>> <AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad1: adc0_ad1 {
>> atmel,pins =
>> <AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad2: adc0_ad2 {
>> atmel,pins =
>> <AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad3: adc0_ad3 {
>> atmel,pins =
>> <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad4: adc0_ad4 {
>> atmel,pins =
>> <AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> @@ -1497,11 +1502,13 @@
>> AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
>> AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
>> };
>> +
>> pinctrl_isi_data_8_9: isi-0-data-8-9 {
>> atmel,pins =
>> <AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
>> AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
>> };
>> +
>> pinctrl_isi_data_10_11: isi-0-data-10-11 {
>> atmel,pins =
>> <AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
>> @@ -1517,9 +1524,11 @@
>> AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
>> AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
>> };
>> +
>> pinctrl_lcd_pwm: lcd-pwm-0 {
>> atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
>> };
>> +
>> pinctrl_lcd_rgb444: lcd-rgb-0 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> @@ -1535,6 +1544,7 @@
>> AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
>> AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
>> };
>> +
>> pinctrl_lcd_rgb565: lcd-rgb-1 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> @@ -1554,6 +1564,7 @@
>> AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
>> AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
>> };
>> +
>> pinctrl_lcd_rgb666: lcd-rgb-2 {
>> atmel,pins =
>> <AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
>> @@ -1575,6 +1586,7 @@
>> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
>> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
>> };
>> +
>> pinctrl_lcd_rgb777: lcd-rgb-3 {
>> atmel,pins =
>> /* LCDDAT0 conflicts with TMS */
>> @@ -1602,6 +1614,7 @@
>> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
>> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
>> };
>> +
>> pinctrl_lcd_rgb888: lcd-rgb-4 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> --
>> 2.1.4
>>
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes
@ 2016-01-25 13:35 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:35 UTC (permalink / raw)
To: linux-arm-kernel
Le 25/01/2016 12:18, Alexandre Belloni a ?crit :
> Hi,
>
> On 20/01/2016 at 13:35:35 +0100, Lothar Wa?mann wrote :
>
> A commit message is mandatory even when small ;)
>
>> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
>
> I'm not sure the added blank lines add any clarity to the fille but I
> won't object. Maybe Nicolas as an opinion.
Well, I don't think it brings more coherency to the .dtsi. For example
some trigger definitions nodes don't have the blank line neither. Other
products .dtsi are the same.
As it may cause merging issues without real gain, I'm sorry but it's a
NACK for me.
Bye,
>> ---
>> arch/arm/boot/dts/sama5d4.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index b8032bc..6c0dc89 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -1428,22 +1428,27 @@
>> atmel,pins =
>> <AT91_PIOE 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* conflicts with USBA_VBUS */
>> };
>> +
>> pinctrl_adc0_ad0: adc0_ad0 {
>> atmel,pins =
>> <AT91_PIOC 27 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad1: adc0_ad1 {
>> atmel,pins =
>> <AT91_PIOC 28 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad2: adc0_ad2 {
>> atmel,pins =
>> <AT91_PIOC 29 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad3: adc0_ad3 {
>> atmel,pins =
>> <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> };
>> +
>> pinctrl_adc0_ad4: adc0_ad4 {
>> atmel,pins =
>> <AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>;
>> @@ -1497,11 +1502,13 @@
>> AT91_PIOB 3 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_VSYNC */
>> AT91_PIOB 4 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_HSYNC */
>> };
>> +
>> pinctrl_isi_data_8_9: isi-0-data-8-9 {
>> atmel,pins =
>> <AT91_PIOC 0 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D8, conflicts with SPI0_MISO, PWMH2 */
>> AT91_PIOC 1 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* ISI_D9, conflicts with SPI0_MOSI, PWML2 */
>> };
>> +
>> pinctrl_isi_data_10_11: isi-0-data-10-11 {
>> atmel,pins =
>> <AT91_PIOC 2 AT91_PERIPH_C AT91_PINCTRL_NONE /* ISI_D10, conflicts with SPI0_SPCK, PWMH3 */
>> @@ -1517,9 +1524,11 @@
>> AT91_PIOA 29 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDDEN */
>> AT91_PIOA 28 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPCK */
>> };
>> +
>> pinctrl_lcd_pwm: lcd-pwm-0 {
>> atmel,pins = <AT91_PIOA 24 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDPWM */
>> };
>> +
>> pinctrl_lcd_rgb444: lcd-rgb-0 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> @@ -1535,6 +1544,7 @@
>> AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD10 pin */
>> AT91_PIOA 11 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD11 pin */
>> };
>> +
>> pinctrl_lcd_rgb565: lcd-rgb-1 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> @@ -1554,6 +1564,7 @@
>> AT91_PIOA 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD14 pin */
>> AT91_PIOA 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD15 pin */
>> };
>> +
>> pinctrl_lcd_rgb666: lcd-rgb-2 {
>> atmel,pins =
>> <AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD2 pin */
>> @@ -1575,6 +1586,7 @@
>> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
>> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
>> };
>> +
>> pinctrl_lcd_rgb777: lcd-rgb-3 {
>> atmel,pins =
>> /* LCDDAT0 conflicts with TMS */
>> @@ -1602,6 +1614,7 @@
>> AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD22 pin */
>> AT91_PIOA 23 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* LCDD23 pin */
>> };
>> +
>> pinctrl_lcd_rgb888: lcd-rgb-4 {
>> atmel,pins =
>> <AT91_PIOA 0 AT91_PERIPH_A AT91_PINCTRL_NONE /* LCDD0 pin */
>> --
>> 2.1.4
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
@ 2016-01-25 13:35 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:35 UTC (permalink / raw)
To: Alexandre Belloni, Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Pawel Moll, Rob Herring, Russell King, devicetree,
linux-arm-kernel, linux-kernel
Le 25/01/2016 12:19, Alexandre Belloni a écrit :
> Hi,
>
> On 20/01/2016 at 13:35:36 +0100, Lothar Waßmann wrote :
>
> Ditto, this needs a commit message.
>
>> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
>
> Else,
>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
I agree with this:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, bye.
>> ---
>> arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index 6c0dc89..fb40014 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -1299,7 +1299,7 @@
>> clocks = <&h32ck>;
>> };
>>
>> - watchdog@fc068640 {
>> + watchdog: watchdog@fc068640 {
>> compatible = "atmel,sama5d4-wdt";
>> reg = <0xfc068640 0x10>;
>> clocks = <&clk32k>;
>> @@ -1351,7 +1351,7 @@
>> };
>>
>>
>> - pinctrl@fc06a000 {
>> + pinctrl: pinctrl@fc06a000 {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
>> --
>> 2.1.4
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
@ 2016-01-25 13:35 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:35 UTC (permalink / raw)
To: Alexandre Belloni, Lothar Waßmann
Cc: Ian Campbell, Jean-Christophe Plagniol-Villard, Kumar Gala,
Mark Rutland, Pawel Moll, Rob Herring, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Le 25/01/2016 12:19, Alexandre Belloni a écrit :
> Hi,
>
> On 20/01/2016 at 13:35:36 +0100, Lothar Waßmann wrote :
>
> Ditto, this needs a commit message.
>
>> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
>
> Else,
>
> Acked-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
I agree with this:
Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Thanks, bye.
>> ---
>> arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index 6c0dc89..fb40014 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -1299,7 +1299,7 @@
>> clocks = <&h32ck>;
>> };
>>
>> - watchdog@fc068640 {
>> + watchdog: watchdog@fc068640 {
>> compatible = "atmel,sama5d4-wdt";
>> reg = <0xfc068640 0x10>;
>> clocks = <&clk32k>;
>> @@ -1351,7 +1351,7 @@
>> };
>>
>>
>> - pinctrl@fc06a000 {
>> + pinctrl: pinctrl@fc06a000 {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
>> --
>> 2.1.4
>>
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and pinctrl nodes
@ 2016-01-25 13:35 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:35 UTC (permalink / raw)
To: linux-arm-kernel
Le 25/01/2016 12:19, Alexandre Belloni a ?crit :
> Hi,
>
> On 20/01/2016 at 13:35:36 +0100, Lothar Wa?mann wrote :
>
> Ditto, this needs a commit message.
>
>> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
>
> Else,
>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
I agree with this:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, bye.
>> ---
>> arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index 6c0dc89..fb40014 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -1299,7 +1299,7 @@
>> clocks = <&h32ck>;
>> };
>>
>> - watchdog at fc068640 {
>> + watchdog: watchdog at fc068640 {
>> compatible = "atmel,sama5d4-wdt";
>> reg = <0xfc068640 0x10>;
>> clocks = <&clk32k>;
>> @@ -1351,7 +1351,7 @@
>> };
>>
>>
>> - pinctrl at fc06a000 {
>> + pinctrl: pinctrl at fc06a000 {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
>> --
>> 2.1.4
>>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-25 13:40 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:40 UTC (permalink / raw)
To: Lothar Waßmann, Alexandre Belloni, Ian Campbell,
Jean-Christophe Plagniol-Villard, Kumar Gala, Mark Rutland,
Pawel Moll, Rob Herring, Russell King, devicetree,
linux-arm-kernel, linux-kernel
Le 20/01/2016 13:35, Lothar Waßmann a écrit :
> The TXA5-5010/-5011 are Computers On Module manufactured by
> Ka-Ro electronics GmbH with the following characteristics:
> Processor Atmel SAMA5D42, 528 MHz
> RAM 256MB 32-bit DDR2 SDRAM
> ROM 128MB NAND Flash (TXA5-5010) / 4GB eMMC (TXA5-5011)
> Power supply Single 3.1V to 5.5V
> Size 26mm SO-DIMM
> Temp. Range -40°C/-25°C to 85°C
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Once remarks by Alexandre are addressed, you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
as well. It's good to see your board integrated in Linux Mainline:
thanks! We'll queue it in a couple of weeks for inclusion in at91-4.6-dt
branch.
Bye,
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts | 217 +++++++++++++++++++++++++++
> 2 files changed, 218 insertions(+)
> create mode 100644 arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index a4a6d70..8fbc0cb 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -49,6 +49,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
> sama5d35ek.dtb \
> sama5d36ek.dtb \
> at91-sama5d4_ma5d4evk.dtb \
> + at91-sama5d4-txa5-5010.dtb \
> at91-sama5d4_xplained.dtb \
> at91-sama5d4ek.dtb \
> at91-vinco.dtb
> diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> new file mode 100644
> index 0000000..fb4a253
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> @@ -0,0 +1,217 @@
> +/*
> + * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
> + *
> + * Copyright (C) 2015 Lothar Waßmann <LW@KARO-electronics.de>
> + * based on: at91-sama5d4_xplained.dts
> + * Copyright (C) 2015 Atmel,
> + * 2015 Josh Wu <josh.wu@atmel.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +#include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Ka-Ro SAMA5D4 TXA5";
> + compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
> +
> + aliases {
> + display = &display;
> + ethernet0 = &macb0;
> + serial0 = &usart0;
> + serial1 = &usart1;
> + serial2 = &usart3;
> + spi0 = &spi0;
> + };
> +
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + main_clock: clock@0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&hlcdc_pwm 0 500000 PWM_POLARITY_INVERTED>;
> + };
> +
> + display: display {
> + display-timings {
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + status = "okay";
> +
> + heartbeat {
> + label = "heartbeat";
> + gpios = <&pioD 29 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +};
> +
> +&adc0 {
> + atmel,adc-vref = <3300>;
> + status = "okay";
> +};
> +
> +&hlcdc {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcd_rgb888>;
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&macb0 {
> + phy-mode = "rmii";
> + status = "okay";
> +
> + phy0: ethernet-phy@1 {
> + interrupt-parent = <&pioE>;
> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> + reg = <1>;
> + };
> +};
> +
> +&main_xtal {
> + clock-frequency = <12000000>;
> +};
> +
> +&mmc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mmc1_clk_cmd_dat0 &pinctrl_mmc1_dat1_3 &pinctrl_mmc1_cd>;
> + status = "okay";
> + slot@0 {
> + reg = <0>;
> + bus-width = <4>;
> + cd-gpios = <&pioE 3 0>;
> + };
> +};
> +
> +&nand0 {
> + nand-bus-width = <8>;
> + nand-ecc-mode = "hw";
> + nand-on-flash-bbt;
> + atmel,has-pmecc;
> + status = "okay";
> +};
> +
> +&pinctrl {
> + sama5d4-txa5 {
> + pinctrl_mmc1_cd: mmc1-cd {
> + atmel,pins = <AT91_PIOE 6 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> +
> + pinctrl_spi0_cs: spi0 {
> + atmel,pins = <
> + AT91_PIOB 21 AT91_PERIPH_GPIO 0 /* CSPI_SS0 */
> + AT91_PIOB 22 AT91_PERIPH_GPIO 0 /* CSPI_SS1 */
> + AT91_PIOB 23 AT91_PERIPH_GPIO 0 /* CSPI_RDY */
> + >;
> + };
> +
> + pinctrl_usba_vbus: usba-vbus {
> + atmel,pins = <
> + AT91_PIOE 10 AT91_PERIPH_GPIO 0 /* USBOTG_VBUSEN */
> + AT91_PIOD 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBOTG_OC */
> + >;
> + };
> +
> + pinctrl_usbb_vbus: usbb-vbus {
> + atmel,pins = <
> + AT91_PIOE 11 AT91_PERIPH_GPIO 0 /* USBH_VBUSEN */
> + AT91_PIOD 9 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBH_OC */
> + >;
> + };
> + };
> +};
> +
> +&slow_xtal {
> + clock-frequency = <32768>;
> +};
> +
> +&spi0 {
> + cs-gpios = <&pioB 21 0>, <&pioB 22 0>, <0>, <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi0 &pinctrl_spi0_cs>;
> + status = "okay";
> +};
> +
> +&usart0 {
> + status = "okay";
> +};
> +
> +&usart1 {
> + status = "okay";
> +};
> +
> +&usart3 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + atmel,vbus-gpio = <&pioE 10 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usba_vbus>;
> + status = "okay";
> +};
> +
> +&usb1 {
> + num-ports = <1>;
> + atmel,vbus-gpio = <&pioE 11 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbb_vbus>;
> + status = "okay";
> +};
> +
> +&watchdog {
> + status = "okay";
> +};
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-25 13:40 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:40 UTC (permalink / raw)
To: Lothar Waßmann, Alexandre Belloni, Ian Campbell,
Jean-Christophe Plagniol-Villard, Kumar Gala, Mark Rutland,
Pawel Moll, Rob Herring, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Le 20/01/2016 13:35, Lothar Waßmann a écrit :
> The TXA5-5010/-5011 are Computers On Module manufactured by
> Ka-Ro electronics GmbH with the following characteristics:
> Processor Atmel SAMA5D42, 528 MHz
> RAM 256MB 32-bit DDR2 SDRAM
> ROM 128MB NAND Flash (TXA5-5010) / 4GB eMMC (TXA5-5011)
> Power supply Single 3.1V to 5.5V
> Size 26mm SO-DIMM
> Temp. Range -40°C/-25°C to 85°C
>
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
Once remarks by Alexandre are addressed, you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
as well. It's good to see your board integrated in Linux Mainline:
thanks! We'll queue it in a couple of weeks for inclusion in at91-4.6-dt
branch.
Bye,
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts | 217 +++++++++++++++++++++++++++
> 2 files changed, 218 insertions(+)
> create mode 100644 arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index a4a6d70..8fbc0cb 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -49,6 +49,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
> sama5d35ek.dtb \
> sama5d36ek.dtb \
> at91-sama5d4_ma5d4evk.dtb \
> + at91-sama5d4-txa5-5010.dtb \
> at91-sama5d4_xplained.dtb \
> at91-sama5d4ek.dtb \
> at91-vinco.dtb
> diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> new file mode 100644
> index 0000000..fb4a253
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> @@ -0,0 +1,217 @@
> +/*
> + * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
> + *
> + * Copyright (C) 2015 Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> + * based on: at91-sama5d4_xplained.dts
> + * Copyright (C) 2015 Atmel,
> + * 2015 Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +#include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Ka-Ro SAMA5D4 TXA5";
> + compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
> +
> + aliases {
> + display = &display;
> + ethernet0 = &macb0;
> + serial0 = &usart0;
> + serial1 = &usart1;
> + serial2 = &usart3;
> + spi0 = &spi0;
> + };
> +
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + main_clock: clock@0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&hlcdc_pwm 0 500000 PWM_POLARITY_INVERTED>;
> + };
> +
> + display: display {
> + display-timings {
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + status = "okay";
> +
> + heartbeat {
> + label = "heartbeat";
> + gpios = <&pioD 29 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +};
> +
> +&adc0 {
> + atmel,adc-vref = <3300>;
> + status = "okay";
> +};
> +
> +&hlcdc {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcd_rgb888>;
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&macb0 {
> + phy-mode = "rmii";
> + status = "okay";
> +
> + phy0: ethernet-phy@1 {
> + interrupt-parent = <&pioE>;
> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> + reg = <1>;
> + };
> +};
> +
> +&main_xtal {
> + clock-frequency = <12000000>;
> +};
> +
> +&mmc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mmc1_clk_cmd_dat0 &pinctrl_mmc1_dat1_3 &pinctrl_mmc1_cd>;
> + status = "okay";
> + slot@0 {
> + reg = <0>;
> + bus-width = <4>;
> + cd-gpios = <&pioE 3 0>;
> + };
> +};
> +
> +&nand0 {
> + nand-bus-width = <8>;
> + nand-ecc-mode = "hw";
> + nand-on-flash-bbt;
> + atmel,has-pmecc;
> + status = "okay";
> +};
> +
> +&pinctrl {
> + sama5d4-txa5 {
> + pinctrl_mmc1_cd: mmc1-cd {
> + atmel,pins = <AT91_PIOE 6 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> +
> + pinctrl_spi0_cs: spi0 {
> + atmel,pins = <
> + AT91_PIOB 21 AT91_PERIPH_GPIO 0 /* CSPI_SS0 */
> + AT91_PIOB 22 AT91_PERIPH_GPIO 0 /* CSPI_SS1 */
> + AT91_PIOB 23 AT91_PERIPH_GPIO 0 /* CSPI_RDY */
> + >;
> + };
> +
> + pinctrl_usba_vbus: usba-vbus {
> + atmel,pins = <
> + AT91_PIOE 10 AT91_PERIPH_GPIO 0 /* USBOTG_VBUSEN */
> + AT91_PIOD 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBOTG_OC */
> + >;
> + };
> +
> + pinctrl_usbb_vbus: usbb-vbus {
> + atmel,pins = <
> + AT91_PIOE 11 AT91_PERIPH_GPIO 0 /* USBH_VBUSEN */
> + AT91_PIOD 9 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBH_OC */
> + >;
> + };
> + };
> +};
> +
> +&slow_xtal {
> + clock-frequency = <32768>;
> +};
> +
> +&spi0 {
> + cs-gpios = <&pioB 21 0>, <&pioB 22 0>, <0>, <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi0 &pinctrl_spi0_cs>;
> + status = "okay";
> +};
> +
> +&usart0 {
> + status = "okay";
> +};
> +
> +&usart1 {
> + status = "okay";
> +};
> +
> +&usart3 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + atmel,vbus-gpio = <&pioE 10 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usba_vbus>;
> + status = "okay";
> +};
> +
> +&usb1 {
> + num-ports = <1>;
> + atmel,vbus-gpio = <&pioE 11 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbb_vbus>;
> + status = "okay";
> +};
> +
> +&watchdog {
> + status = "okay";
> +};
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules
@ 2016-01-25 13:40 ` Nicolas Ferre
0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2016-01-25 13:40 UTC (permalink / raw)
To: linux-arm-kernel
Le 20/01/2016 13:35, Lothar Wa?mann a ?crit :
> The TXA5-5010/-5011 are Computers On Module manufactured by
> Ka-Ro electronics GmbH with the following characteristics:
> Processor Atmel SAMA5D42, 528 MHz
> RAM 256MB 32-bit DDR2 SDRAM
> ROM 128MB NAND Flash (TXA5-5010) / 4GB eMMC (TXA5-5011)
> Power supply Single 3.1V to 5.5V
> Size 26mm SO-DIMM
> Temp. Range -40?C/-25?C to 85?C
>
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
Once remarks by Alexandre are addressed, you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
as well. It's good to see your board integrated in Linux Mainline:
thanks! We'll queue it in a couple of weeks for inclusion in at91-4.6-dt
branch.
Bye,
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts | 217 +++++++++++++++++++++++++++
> 2 files changed, 218 insertions(+)
> create mode 100644 arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index a4a6d70..8fbc0cb 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -49,6 +49,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
> sama5d35ek.dtb \
> sama5d36ek.dtb \
> at91-sama5d4_ma5d4evk.dtb \
> + at91-sama5d4-txa5-5010.dtb \
> at91-sama5d4_xplained.dtb \
> at91-sama5d4ek.dtb \
> at91-vinco.dtb
> diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> new file mode 100644
> index 0000000..fb4a253
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> @@ -0,0 +1,217 @@
> +/*
> + * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
> + *
> + * Copyright (C) 2015 Lothar Wa?mann <LW@KARO-electronics.de>
> + * based on: at91-sama5d4_xplained.dts
> + * Copyright (C) 2015 Atmel,
> + * 2015 Josh Wu <josh.wu@atmel.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +#include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> + model = "Ka-Ro SAMA5D4 TXA5";
> + compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
> +
> + aliases {
> + display = &display;
> + ethernet0 = &macb0;
> + serial0 = &usart0;
> + serial1 = &usart1;
> + serial2 = &usart3;
> + spi0 = &spi0;
> + };
> +
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + main_clock: clock at 0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&hlcdc_pwm 0 500000 PWM_POLARITY_INVERTED>;
> + };
> +
> + display: display {
> + display-timings {
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + status = "okay";
> +
> + heartbeat {
> + label = "heartbeat";
> + gpios = <&pioD 29 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +};
> +
> +&adc0 {
> + atmel,adc-vref = <3300>;
> + status = "okay";
> +};
> +
> +&hlcdc {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcd_rgb888>;
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +};
> +
> +&macb0 {
> + phy-mode = "rmii";
> + status = "okay";
> +
> + phy0: ethernet-phy at 1 {
> + interrupt-parent = <&pioE>;
> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> + reg = <1>;
> + };
> +};
> +
> +&main_xtal {
> + clock-frequency = <12000000>;
> +};
> +
> +&mmc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mmc1_clk_cmd_dat0 &pinctrl_mmc1_dat1_3 &pinctrl_mmc1_cd>;
> + status = "okay";
> + slot at 0 {
> + reg = <0>;
> + bus-width = <4>;
> + cd-gpios = <&pioE 3 0>;
> + };
> +};
> +
> +&nand0 {
> + nand-bus-width = <8>;
> + nand-ecc-mode = "hw";
> + nand-on-flash-bbt;
> + atmel,has-pmecc;
> + status = "okay";
> +};
> +
> +&pinctrl {
> + sama5d4-txa5 {
> + pinctrl_mmc1_cd: mmc1-cd {
> + atmel,pins = <AT91_PIOE 6 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> +
> + pinctrl_spi0_cs: spi0 {
> + atmel,pins = <
> + AT91_PIOB 21 AT91_PERIPH_GPIO 0 /* CSPI_SS0 */
> + AT91_PIOB 22 AT91_PERIPH_GPIO 0 /* CSPI_SS1 */
> + AT91_PIOB 23 AT91_PERIPH_GPIO 0 /* CSPI_RDY */
> + >;
> + };
> +
> + pinctrl_usba_vbus: usba-vbus {
> + atmel,pins = <
> + AT91_PIOE 10 AT91_PERIPH_GPIO 0 /* USBOTG_VBUSEN */
> + AT91_PIOD 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBOTG_OC */
> + >;
> + };
> +
> + pinctrl_usbb_vbus: usbb-vbus {
> + atmel,pins = <
> + AT91_PIOE 11 AT91_PERIPH_GPIO 0 /* USBH_VBUSEN */
> + AT91_PIOD 9 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* USBH_OC */
> + >;
> + };
> + };
> +};
> +
> +&slow_xtal {
> + clock-frequency = <32768>;
> +};
> +
> +&spi0 {
> + cs-gpios = <&pioB 21 0>, <&pioB 22 0>, <0>, <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi0 &pinctrl_spi0_cs>;
> + status = "okay";
> +};
> +
> +&usart0 {
> + status = "okay";
> +};
> +
> +&usart1 {
> + status = "okay";
> +};
> +
> +&usart3 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + atmel,vbus-gpio = <&pioE 10 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usba_vbus>;
> + status = "okay";
> +};
> +
> +&usb1 {
> + num-ports = <1>;
> + atmel,vbus-gpio = <&pioE 11 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbb_vbus>;
> + status = "okay";
> +};
> +
> +&watchdog {
> + status = "okay";
> +};
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2016-01-25 13:40 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-20 12:35 ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules Lothar Waßmann
2016-01-20 12:35 ` Lothar Waßmann
2016-01-20 12:35 ` [PATCH 1/3] ARM: dts: sama5d4: cleanup - add blank lines between pinctrl nodes Lothar Waßmann
2016-01-20 12:35 ` Lothar Waßmann
2016-01-25 11:18 ` Alexandre Belloni
2016-01-25 11:18 ` Alexandre Belloni
2016-01-25 11:18 ` Alexandre Belloni
2016-01-25 13:35 ` Nicolas Ferre
2016-01-25 13:35 ` Nicolas Ferre
2016-01-25 13:35 ` Nicolas Ferre
2016-01-20 12:35 ` [PATCH 2/3] ARM: dts: sama5d4: add labels for watchdog and " Lothar Waßmann
2016-01-20 12:35 ` Lothar Waßmann
2016-01-25 11:19 ` Alexandre Belloni
2016-01-25 11:19 ` Alexandre Belloni
2016-01-25 11:19 ` Alexandre Belloni
2016-01-25 13:35 ` Nicolas Ferre
2016-01-25 13:35 ` Nicolas Ferre
2016-01-25 13:35 ` Nicolas Ferre
2016-01-20 12:35 ` [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics TXA5 modules Lothar Waßmann
2016-01-20 12:35 ` Lothar Waßmann
2016-01-25 11:34 ` Alexandre Belloni
2016-01-25 11:34 ` Alexandre Belloni
2016-01-25 11:34 ` Alexandre Belloni
2016-01-25 13:40 ` Nicolas Ferre
2016-01-25 13:40 ` Nicolas Ferre
2016-01-25 13:40 ` Nicolas Ferre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.