From: Yuki Machida <machida.yuki@jp.fujitsu.com>
To: <netdev@vger.kernel.org>, <gregkh@linuxfoundation.org>
Cc: "Yuki Machida" <machida.yuki@jp.fujitsu.com>,
"Salva Peiró" <speirofr@gmail.com>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>
Subject: [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl
Date: Mon, 25 Jan 2016 19:42:18 +0900 [thread overview]
Message-ID: <1453718538-21691-1-git-send-email-machida.yuki@jp.fujitsu.com> (raw)
commit eda98796aff0d9bf41094b06811f5def3b4c333c upstream.
The vivid_fb_ioctl() code fails to initialize the 16 _reserved bytes of
struct fb_vblank after the ->hcount member. Add an explicit
memset(0) before filling the structure to avoid the info leak.
This fixes CVE-2015-7884.
Signed-off-by: Salva Peiró <speirofr@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Yuki Machida <machida.yuki@jp.fujitsu.com>
---
drivers/media/platform/vivid/vivid-osd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c
index 084d346..e15eef6 100644
--- a/drivers/media/platform/vivid/vivid-osd.c
+++ b/drivers/media/platform/vivid/vivid-osd.c
@@ -85,6 +85,7 @@ static int vivid_fb_ioctl(struct fb_info *info, unsigned cmd, unsigned long arg)
case FBIOGET_VBLANK: {
struct fb_vblank vblank;
+ memset(&vblank, 0, sizeof(vblank));
vblank.flags = FB_VBLANK_HAVE_COUNT | FB_VBLANK_HAVE_VCOUNT |
FB_VBLANK_HAVE_VSYNC;
vblank.count = 0;
--
1.9.1
next reply other threads:[~2016-01-25 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:42 Yuki Machida [this message]
2016-01-25 17:18 ` [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl Greg KH
2016-01-27 7:59 ` Yuki Machida
2016-01-25 23:44 ` Yuki Machida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453718538-21691-1-git-send-email-machida.yuki@jp.fujitsu.com \
--to=machida.yuki@jp.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=mchehab@osg.samsung.com \
--cc=netdev@vger.kernel.org \
--cc=speirofr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.