From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965965AbcA0XeT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jan 2016 18:34:19 -0500
Received: from LGEAMRELO11.lge.com ([156.147.23.51]:33159 "EHLO
	lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965150AbcA0XeQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jan 2016 18:34:16 -0500
X-Original-SENDERIP: 156.147.1.125
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 10.177.227.17
X-Original-MAILFROM: namhyung@kernel.org
Message-ID: <1453937649.11866.2.camel@kernel.org>
Subject: Re: [RFC/PATCH 10/10] perf tools: Change default calchain percent
 limit to 0.005%
From: Namhyung Kim <namhyung@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Wang Nan <wangnan0@huawei.com>, Taeung Song <treeze.taeung@gmail.com>
Date: Thu, 28 Jan 2016 08:34:09 +0900
In-Reply-To: <20160127160611.GI31686@two.firstfloor.org>
References: <1453909257-26015-1-git-send-email-namhyung@kernel.org>
	 <1453909257-26015-11-git-send-email-namhyung@kernel.org>
	 <20160127160611.GI31686@two.firstfloor.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.4 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andi,

On Wed, 2016-01-27 at 17:06 +0100, Andi Kleen wrote:
> On Thu, Jan 28, 2016 at 12:40:57AM +0900, Namhyung Kim wrote:
> > The current default limit of 0.5% is (mostly) for 'fractal' mode
> > which
> > calculates the percentage relatively.  As we changed the default
> > callchain mode to 'graph', the existing limit is too high IMHO.
> > Normally there're many entries under 0.5% overhead, it'd be
> > supprising
> > that they don't show callchains.
> 
> It's too small imho. On more complex workloads with a lot of user
> space
> code we often end up with default perf report --stdio callgraph output
> of several
> hundred KB, and most of it is useless as it is only very small.

Do you think it's better to keep current default?  Or do you suggest
different value?

Thanks,
Namhyung