All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/9] test/py: fix spawn.expect multiple match handling
Date: Wed, 27 Jan 2016 23:57:47 -0700	[thread overview]
Message-ID: <1453964274-9129-2-git-send-email-swarren@wwwdotorg.org> (raw)
In-Reply-To: <1453964274-9129-1-git-send-email-swarren@wwwdotorg.org>

From: Stephen Warren <swarren@nvidia.com>

Multiple patterns may be passed to spawn.expect(). The pattern which
matches at the earliest position should be designated as the match. This
aspect works correctly. When multiple patterns match at the same position,
priority should be given the the earliest entry in the list of patterns.
This aspect does not work correctly. This patch fixes it.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 test/py/u_boot_spawn.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/py/u_boot_spawn.py b/test/py/u_boot_spawn.py
index d50807599027..7451455671b9 100644
--- a/test/py/u_boot_spawn.py
+++ b/test/py/u_boot_spawn.py
@@ -132,7 +132,7 @@ class Spawn(object):
                     m = pattern.search(self.buf)
                     if not m:
                         continue
-                    if earliest_m and m.start() > earliest_m.start():
+                    if earliest_m and m.start() >= earliest_m.start():
                         continue
                     earliest_m = m
                     earliest_pi = pi
-- 
2.7.0

  reply	other threads:[~2016-01-28  6:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  6:57 [U-Boot] [PATCH 1/9] test/dm: clear unit test failure count each run Stephen Warren
2016-01-28  6:57 ` Stephen Warren [this message]
2016-01-29  3:47   ` [U-Boot] [PATCH 2/9] test/py: fix spawn.expect multiple match handling Simon Glass
2016-01-29  4:02     ` Simon Glass
2016-01-28  6:57 ` [U-Boot] [PATCH 3/9] test.py: calculate bad patterns on change only Stephen Warren
2016-01-29  3:47   ` Simon Glass
2016-01-29  4:02     ` Simon Glass
2016-01-28  6:57 ` [U-Boot] [PATCH 4/9] test/py: check for bad patterns everywhere we wait Stephen Warren
2016-01-29  3:47   ` Simon Glass
2016-01-29  4:02     ` Simon Glass
2016-01-28  6:57 ` [U-Boot] [PATCH 5/9] test/py: detect another "bad pattern" in console output Stephen Warren
2016-01-29  3:47   ` Simon Glass
2016-01-29  4:02     ` Simon Glass
2016-01-28  6:57 ` [U-Boot] [PATCH 6/9] test/py: correctly log xfail/xpass tests Stephen Warren
2016-01-29  3:47   ` Simon Glass
2016-01-29  4:02     ` Simon Glass
2016-01-28  6:57 ` [U-Boot] [PATCH 7/9] test/py: pass test DTB to sandbox Stephen Warren
2016-01-29  3:47   ` Simon Glass
2016-01-29  4:02     ` Simon Glass
2016-01-28  6:57 ` [U-Boot] [PATCH 8/9] test/py: run sandbox in source directory Stephen Warren
2016-01-29  3:47   ` Simon Glass
2016-01-29  4:02     ` Simon Glass
2016-01-28  6:57 ` [U-Boot] [PATCH 9/9] test/py: run C-based unit tests Stephen Warren
2016-01-29  3:47   ` Simon Glass
2016-01-29  3:46 ` [U-Boot] [PATCH 1/9] test/dm: clear unit test failure count each run Simon Glass
2016-01-29  4:02   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453964274-9129-2-git-send-email-swarren@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.